Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: flush SQL Stats to system tables when a node is draining #74413

Closed
Azhng opened this issue Jan 4, 2022 · 0 comments · Fixed by #76397
Closed

sql: flush SQL Stats to system tables when a node is draining #74413

Azhng opened this issue Jan 4, 2022 · 0 comments · Fixed by #76397
Labels
A-sql-observability Related to observability of the SQL layer C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@Azhng
Copy link
Contributor

Azhng commented Jan 4, 2022 •
edited by kevin-v-ngo
Loading

Is your feature request related to a problem? Please describe.

Currently, SQL Stats periodically flushes in-memory stats into system table, or when the in-memory buffer fills up.
Additionally, we would like to flush the SQL Stats into the system table when a node is shutting down. This is important is multi-tenant environment, where a SQL Pod is shutdown after a short period of inactivity.

Describe the solution you'd like
implementing #72045 and #74412

Epic: CC-5060
@Azhng Azhng added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Jan 4, 2022
@Azhng Azhng added the A-sql-observability Related to observability of the SQL layer label Jan 4, 2022
This was referenced Feb 10, 2022
Closed
Merged
@THardy98 THardy98 removed their assignment Feb 17, 2022
@craig craig bot closed this as completed in f2a722f Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-sql-observability Related to observability of the SQL layer C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

server: flush SQL stats during drain cameronnunez/cockroach
2 participants
@Azhng @THardy98