Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: equip the mt-start-sql server code with a drain process #74412

Closed
knz opened this issue Jan 4, 2022 · 2 comments · Fixed by #76294
Closed

server: equip the mt-start-sql server code with a drain process #74412

knz opened this issue Jan 4, 2022 · 2 comments · Fixed by #76294
Assignees
@knz
Labels
A-cli-server CLI commands that pertain to CockroachDB server processes A-server-architecture Relates to the internal APIs and src org for server code A-server-start-drain Pertains to server startup and shutdown sequences C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-server-and-security DB Server & Security

Comments

@knz
Copy link
Contributor

knz commented Jan 4, 2022

Epic CRDB-11087

This is a pre-req to solving #72045

To add a feature to "execute some SQL statements before a node starts draining" (#72045), we must have a draining process to start with. The start and start-single-node commands provide that, but mt start-sql doesn't.

Describe the solution you'd like

We want to provide a Drain RPC and a shutdown sequence to the mt start-sql server process that is using a common code path with the one used for regular DB nodes.
@knz knz added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-server-and-security DB Server & Security A-cli-server CLI commands that pertain to CockroachDB server processes A-server-architecture Relates to the internal APIs and src org for server code A-server-start-drain Pertains to server startup and shutdown sequences labels Jan 4, 2022
@knz knz mentioned this issue Jan 4, 2022
Closed
@knz knz added the A-multitenancy Related to multi-tenancy label Jan 4, 2022
@exalate-issue-sync exalate-issue-sync bot removed the A-multitenancy Related to multi-tenancy label Jan 4, 2022
@knz
Copy link
Contributor Author

knz commented Jan 4, 2022

cc @cameronnunez

@Azhng Azhng mentioned this issue Jan 4, 2022
Closed
@knz
Copy link
Contributor Author

knz commented Jan 5, 2022

Actually it's also needed for #73586 / #66319.

@Azhng Azhng mentioned this issue Feb 4, 2022
Closed
@knz knz mentioned this issue Feb 9, 2022
Merged
@craig craig bot closed this as completed in 2356961 Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knz knz

Labels
A-cli-server CLI commands that pertain to CockroachDB server processes A-server-architecture Relates to the internal APIs and src org for server code A-server-start-drain Pertains to server startup and shutdown sequences C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-server-and-security DB Server & Security
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

server: make the Drain interfaces available to SQL-only servers knz/cockroach
1 participant
@knz