remove and disallow testing packages in the cockroach binary #74120
Labels
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Comments
RaduBerinde
added
the
C-bug
This was referenced Dec 21, 2021
RaduBerinde
added a commit
to RaduBerinde/cockroach
that referenced
this issue
Dec 21, 2021
The `sql/randgen` package creates a lot of global datums, some of which use geospatial and require the loading of geospatial data. This package is meant for testing and should not be part of the cockroach binary. This change removes the non-testing uses of randgen. Tested via `go list -deps ./pkg/cmd/cockroach`. Note that the updated test is ineffectual for now (tracked by cockroachdb#74119). Informs cockroachdb#74120. Release note: None
craig bot
pushed a commit
that referenced
this issue
Dec 21, 2021
73941: roachtest: make crdb crash on span-use-after-Finish r=andreimatei a=andreimatei This patch makes roachtest pass an env var to crdb asking it to panic on mis-use of tracing spans. I've been battling such bugs, which become more problematic as I'm trying to introduce span reuse. In production we'll probably continue tolerating such bugs for the time being, but I want tests to yell. Unit tests are already running with this use-after-Finish detection, and so far so good. I've done a manual run of all the roachtests in this configuration and nothing crashed, so I don't expect a tragedy. Release note: None 74109: kv: rename gcQueue to mvccGCQueue r=tbg a=nvanbenschoten This commit renames the "GC queue" to the "MVCC GC queue" (which GC's old MVCC versions) to avoid confusion with the "replica GC queue" (which GC's abandoned replicas). We've already been using this terminology in various other contexts to avoid confusion, so this refactor updates the code to reflect this naming. This comes in response to #73838, which found a bug that had survived for three years and was a direct consequence of this ambiguous naming. The commit doesn't go quite as far as renaming the `pkg/kv/kvserver/gc` package, but that could be a follow-up to this commit. 74126: geo: move projection data to embedded compressed file r=RaduBerinde a=RaduBerinde The geoprojbase package embeds projection info as constants, leading to a 6MB code file. Large code files are undesirable especially from the perspective of static analysis tools, IDEs, etc. This change moves the projections data to an embedded json.gz file. We define the schema of this file in a new `embeddedproj` subpackage. The data is loaded lazily. The data file was obtained by modifying the existing constants to fill out an `embeddedproj.Data`: https://github.com/RaduBerinde/cockroach/blob/geospatial-proj-data/pkg/geo/geoprojbase/embeddedproj/data_test.go The `generate-spatial-ref-sys` command is also updated to generate this file from the `.csv`. The `make buildshort` binary size is decreased by ~7MB. Fixes #63969. Release note: None 74128: cockroach: don't import randgen in binary r=RaduBerinde a=RaduBerinde The `sql/randgen` package creates a lot of global datums, some of which use geospatial and require the loading of geospatial data. This package is meant for testing and should not be part of the cockroach binary. This change removes the non-testing uses of randgen. Tested via `go list -deps ./pkg/cmd/cockroach`. Note that the updated test is ineffectual for now (tracked by #74119). Informs #74120. Release note: None 74159: sql: default index recommendations to be off for logic tests r=nehageorge a=nehageorge **sql: refactor GlobalDefault for session variables** This commit refactors pkg/sql/vars.go to use globalFalse and globalTrue as the setting GlobalDefault where possible. Release note: None **sql: default index recommendations to be off for logic tests** This commit configures index recommendations to be off for logic tests. This is to avoid flaky tests, as the index recommendation output can vary depending on the best plan chosen by the optimizer. Fixes: #74069. Release note: None Co-authored-by: Andrei Matei <[email protected]> Co-authored-by: Nathan VanBenschoten <[email protected]> Co-authored-by: Radu Berinde <[email protected]> Co-authored-by: Neha George <[email protected]>
gustasva
pushed a commit
to gustasva/cockroach
that referenced
this issue
Jan 4, 2022
The `sql/randgen` package creates a lot of global datums, some of which use geospatial and require the loading of geospatial data. This package is meant for testing and should not be part of the cockroach binary. This change removes the non-testing uses of randgen. Tested via `go list -deps ./pkg/cmd/cockroach`. Note that the updated test is ineffectual for now (tracked by cockroachdb#74119). Informs cockroachdb#74120. Release note: None
|
We have marked this issue as stale because it has been inactive for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The main binary links a lot of packages that are supposed to be test-only (including the standard lib
testing!). #74119 tracks fixing the linters. This issue tracks removing and fixing these deps.Jira issue: CRDB-11926
The text was updated successfully, but these errors were encountered: