Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancel statement diagnostics #73863

Closed
lindseyjin opened this issue Dec 15, 2021 · 0 comments · Fixed by #73882
Closed

Cancel statement diagnostics #73863

lindseyjin opened this issue Dec 15, 2021 · 0 comments · Fixed by #73882
Assignees
@yuzefovich @lindseyjin
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-queries SQL Queries Team

Comments

@lindseyjin
Copy link
Contributor

lindseyjin commented Dec 15, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.
We want the ability to cancel statement diagnostics that are still waiting on a result. This will be later surfaced in the frontend statement diagnostics pages.

Additional context
Blocks cancellation flows for: #57634

https://www.figma.com/file/xdmwvnFQd6KkO9RJ0XLDH0/22.1_SQL-obsrv_query-performance?node-id=4722%3A123327
@lindseyjin lindseyjin added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Dec 15, 2021
@blathers-crl blathers-crl bot added the T-sql-queries SQL Queries Team label Dec 15, 2021
lindseyjin added a commit to lindseyjin/cockroach that referenced this issue Dec 15, 2021
@lindseyjin
<pkg>: <short description - lowercase, no final period>
d18e42c 
Resolves cockroachdb#73863

<what was there before: Previously, ...>
<why it needed to change: This was inadequate because ...>
<what you did about it: To address this, this patch ...>

Release note (<category, see below>): <what> <show> <why>
@lindseyjin lindseyjin mentioned this issue Dec 15, 2021
Closed
@yuzefovich yuzefovich mentioned this issue Dec 16, 2021
Merged
@craig craig bot closed this as completed in a7accab Dec 21, 2021
@lindseyjin lindseyjin mentioned this issue Dec 22, 2021
Closed
@mgartner mgartner moved this to Done in SQL Queries Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuzefovich yuzefovich

@lindseyjin lindseyjin

Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-queries SQL Queries Team
Projects
SQL Queries
Archived in project
Milestone
No milestone
2 participants
@yuzefovich @lindseyjin