Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: use version to enable block props in MakeIngestionSSTWriter #73768

Closed
dt opened this issue Dec 13, 2021 · 1 comment
Closed

storage: use version to enable block props in MakeIngestionSSTWriter #73768

dt opened this issue Dec 13, 2021 · 1 comment
Assignees
@nicktrav
Labels
A-storage Relating to our storage engine (Pebble) on-disk storage. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@dt
Copy link
Member

dt commented Dec 13, 2021

They have to be disabled if old nodes could be sent these new format SSTs, but but should be enabled once no old nodes are possible.
@dt dt added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-storage Relating to our storage engine (Pebble) on-disk storage. labels Dec 13, 2021
@dt dt self-assigned this Dec 13, 2021
@sumeerbhola sumeerbhola mentioned this issue Jan 7, 2022
Closed
@dt dt assigned nicktrav and unassigned dt Feb 11, 2022
@nicktrav
Copy link
Collaborator

Ack. #76278 should resolve this. Will update the commit.

@craig craig bot closed this as completed in 6e2a057 Feb 15, 2022
RajivTS pushed a commit to RajivTS/cockroach that referenced this issue Mar 6, 2022
@nicktrav @RajivTS
pkg/storage: make MakeIngestionWriterOptions version aware
42dc890 
With the introduction of block properties, and soon, range keys, which
introduce backward-incompatible changes at the SSTable level, all nodes
in a cluster must all have a sufficient store version in order to avoid
runtime incompatibilities.

Update `storage.MakeIngestionWriterOptions` to add a `context.Context`
and `cluster.Settings` as parameters, which allows for determining
whether a given cluster version is active (via
`(clusterversion.Handle).IsActive()`). This allows gating the enabling /
disabling of block properties (and soon, range keys), on all nodes being
at a sufficient cluster version.

Update various call-sites to pass in the `context.Context` and
`cluster.Settings`.

Closes cockroachdb#73768.

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicktrav nicktrav

Labels
A-storage Relating to our storage engine (Pebble) on-disk storage. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dt @nicktrav