Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: test with a nonexistant package path crashes with exit code 7 #73457

Closed
jordanlewis opened this issue Dec 3, 2021 · 1 comment · Fixed by #74808
Closed

dev: test with a nonexistant package path crashes with exit code 7 #73457

jordanlewis opened this issue Dec 3, 2021 · 1 comment · Fixed by #74808
Assignees
@postamar
Labels
A-build-system C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-dev-inf

Comments

@jordanlewis
Copy link
Member

jordanlewis commented Dec 3, 2021 •
edited by exalate-issue-sync bot
Loading

If I run dev test with a directory that doesn't exist, dev just exits with code 7 without an error message. Ideally, I'd like to see an error message that tells me what went wrong.

[18:02:1]% dev test pkg/blah                                                                                    
ERROR: exit status 7

Epic CRDB-8036

Epic CRDB-8036
@jordanlewis jordanlewis added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Dec 3, 2021
@rickystewart
Copy link
Collaborator

latest error message is more comprehensible, but still not ideal:

cockroach$ ./dev test pkg/blah
ERROR: failed to run `bazel query 'kind(go_test, //pkg/blah:all)'` (exit status 7)

@postamar postamar mentioned this issue Jan 13, 2022
Merged
craig bot pushed a commit that referenced this issue Jan 21, 2022
Merge #74808
0a40796 
74808: dev: improve package argument handling r=postamar a=postamar

This commit adds syntax and existence checks to handle bad package
arguments in a more robust way.

Fixes #73457.

Release note: None

Co-authored-by: Marius Posta <[email protected]>
@craig craig bot closed this as completed in a4da971 Jan 21, 2022
gtr pushed a commit to gtr/cockroach that referenced this issue Jan 24, 2022
dev: improve package argument handling
7ddfbfa 
This commit adds syntax and existence checks to handle bad package
arguments in a more robust way.

Fixes cockroachdb#73457.

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@postamar postamar

Labels
A-build-system C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-dev-inf
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dev: improve package argument handling postamar/cockroach
4 participants
@rail @jordanlewis @postamar @rickystewart