Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql/schemachanger/scplan: TestPlanAlterTable failed #72562

Closed
cockroach-teamcity opened this issue Nov 9, 2021 · 5 comments
Closed

sql/schemachanger/scplan: TestPlanAlterTable failed #72562

cockroach-teamcity opened this issue Nov 9, 2021 · 5 comments
Assignees
@fqazi
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@cockroach-teamcity
Copy link
Member

sql/schemachanger/scplan.TestPlanAlterTable failed with artifacts on master @ 5d68dff8e52616ed92798c1a01b370e62f57c6a8:

=== RUN   TestPlanAlterTable
    test_log_scope.go:79: test logs captured to: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestPlanAlterTable374271561
    test_log_scope.go:80: use -show-logs to present logs inline
=== CONT  TestPlanAlterTable
    plan_test.go:132: -- test log scope end --
test logs left over in: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestPlanAlterTable374271561
--- FAIL: TestPlanAlterTable (13.86s)
=== RUN   TestPlanAlterTable/drop_database
    plan_test.go:87: created relation with id 54
    plan_test.go:87: created relation with id 55
    plan_test.go:87: created relation with id 56
    plan_test.go:87: created relation with id 57
    plan_test.go:87: created relation with id 58
    plan_test.go:87: created relation with id 59
    plan_test.go:87: created relation with id 60
    plan_test.go:87: created relation with id 61
    plan_test.go:87: created relation with id 64
    plan_test.go:130: 
        testdata/drop_database:50: DROP DATABASE db1 CASCADE
        output didn't match expected:
        @@ -107,14 +107,14 @@
             DependedOnBy: 61
             TableID: 59
           *scop.MarkDescriptorAsDropped
             DescID: 58
           *scop.RemoveRelationDependedOnBy
        +    DependedOnBy: 60
        +    TableID: 58
        +  *scop.RemoveRelationDependedOnBy
             DependedOnBy: 59
        -    TableID: 58
        -  *scop.RemoveRelationDependedOnBy
        -    DependedOnBy: 60
             TableID: 58
           *scop.MarkDescriptorAsDropped
             DescID: 60
           *scop.MarkDescriptorAsDropped
             DescID: 64
    --- FAIL: TestPlanAlterTable/drop_database (2.74s)
Help

See also: [How To Investigate a Go Test Failure \(internal\)](https://cockroachlabs.atlassian.net/l/c/HgfXfJgM)Parameters in this failure:

  • TAGS=deadlock

  • GOFLAGS=-parallel=4

/cc @cockroachdb/sql-schema

This test on roachdash | Improve this report!
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Nov 9, 2021
@blathers-crl blathers-crl bot added the T-sql-schema-deprecated Use T-sql-foundations instead label Nov 9, 2021
@cockroach-teamcity
Copy link
Member Author

sql/schemachanger/scplan.TestPlanAlterTable failed with artifacts on master @ 5d68dff8e52616ed92798c1a01b370e62f57c6a8:

=== RUN   TestPlanAlterTable
    test_log_scope.go:79: test logs captured to: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestPlanAlterTable605495772
    test_log_scope.go:80: use -show-logs to present logs inline
=== CONT  TestPlanAlterTable
    plan_test.go:132: -- test log scope end --
test logs left over in: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestPlanAlterTable605495772
--- FAIL: TestPlanAlterTable (19.28s)
=== RUN   TestPlanAlterTable/drop_schema
    plan_test.go:87: created relation with id 53
    plan_test.go:87: created relation with id 54
    plan_test.go:87: created relation with id 55
    plan_test.go:87: created relation with id 56
    plan_test.go:87: created relation with id 57
    plan_test.go:87: created relation with id 58
    plan_test.go:87: created relation with id 61
    plan_test.go:130: 
        testdata/drop_schema:119: DROP SCHEMA defaultdb.SC1 CASCADE
        output didn't match expected:
        @@ -56,14 +56,14 @@
             DependedOnBy: 61
             TableID: 58
           *scop.MarkDescriptorAsDropped
             DescID: 56
           *scop.RemoveRelationDependedOnBy
        -    DependedOnBy: 57
        +    DependedOnBy: 58
             TableID: 56
           *scop.RemoveRelationDependedOnBy
        -    DependedOnBy: 58
        +    DependedOnBy: 57
             TableID: 56
           *scop.MarkDescriptorAsDropped
             DescID: 55
           *scop.RemoveRelationDependedOnBy
             DependedOnBy: 56
    --- FAIL: TestPlanAlterTable/drop_schema (3.11s)
Help

See also: [How To Investigate a Go Test Failure \(internal\)](https://cockroachlabs.atlassian.net/l/c/HgfXfJgM)Parameters in this failure:

  • GOFLAGS=-race -parallel=4

/cc @cockroachdb/sql-schema

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

sql/schemachanger/scplan.TestPlanAlterTable failed with artifacts on master @ 5d68dff8e52616ed92798c1a01b370e62f57c6a8:

=== RUN   TestPlanAlterTable
    test_log_scope.go:79: test logs captured to: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestPlanAlterTable804088119
    test_log_scope.go:80: use -show-logs to present logs inline
=== CONT  TestPlanAlterTable
    plan_test.go:132: -- test log scope end --
test logs left over in: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestPlanAlterTable804088119
--- FAIL: TestPlanAlterTable (9.30s)
=== RUN   TestPlanAlterTable/drop_schema
    plan_test.go:87: created relation with id 53
    plan_test.go:87: created relation with id 54
    plan_test.go:87: created relation with id 55
    plan_test.go:87: created relation with id 56
    plan_test.go:87: created relation with id 57
    plan_test.go:87: created relation with id 58
    plan_test.go:87: created relation with id 61
    plan_test.go:130: 
        testdata/drop_schema:119: DROP SCHEMA defaultdb.SC1 CASCADE
        output didn't match expected:
        @@ -56,14 +56,14 @@
             DependedOnBy: 61
             TableID: 58
           *scop.MarkDescriptorAsDropped
             DescID: 56
           *scop.RemoveRelationDependedOnBy
        -    DependedOnBy: 57
        +    DependedOnBy: 58
             TableID: 56
           *scop.RemoveRelationDependedOnBy
        -    DependedOnBy: 58
        +    DependedOnBy: 57
             TableID: 56
           *scop.MarkDescriptorAsDropped
             DescID: 55
           *scop.RemoveRelationDependedOnBy
             DependedOnBy: 56
    --- FAIL: TestPlanAlterTable/drop_schema (1.47s)
Help

See also: [How To Investigate a Go Test Failure \(internal\)](https://cockroachlabs.atlassian.net/l/c/HgfXfJgM)Parameters in this failure:

  • GOFLAGS=-json

/cc @cockroachdb/sql-schema

This test on roachdash | Improve this report!

@fqazi fqazi self-assigned this Nov 9, 2021
@fqazi
Copy link
Collaborator

fqazi commented Nov 9, 2021

The flake is linked to the sorting change inside: #67266. Let me take a look.

fqazi added a commit to fqazi/cockroach that referenced this issue Nov 9, 2021
@fqazi
sql: new schema changer does not deterministically rank nodes
a1de3ad 
Fixes: cockroachdb#72562, cockroachdb#72561

Previously, when we updated the sorting inside the new schema changer
to a rank based approach we incorrectly assumed that DepEdges will always
be generated in a deterministic fashion. Unfortunately, this turned
out to be false, which can lead to ranks for neighbour edges to
be unstable. To address this, this patch iterates over DepEdges
in a ordered fashion based on the To nodes, fixing intermittent
failures inside the new schema changer tests.

Release note: None
@fqazi fqazi mentioned this issue Nov 9, 2021
Closed
@cockroach-teamcity
Copy link
Member Author

sql/schemachanger/scplan.TestPlanAlterTable failed with artifacts on master @ 82c3d0b4e93d4a6dac6f9c94feaaa2f2199996c3:

=== RUN   TestPlanAlterTable
    test_log_scope.go:79: test logs captured to: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestPlanAlterTable956755241
    test_log_scope.go:80: use -show-logs to present logs inline
=== CONT  TestPlanAlterTable
    plan_test.go:132: -- test log scope end --
test logs left over in: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestPlanAlterTable956755241
--- FAIL: TestPlanAlterTable (21.01s)
=== RUN   TestPlanAlterTable/drop_view
    plan_test.go:87: created relation with id 52
    plan_test.go:87: created relation with id 53
    plan_test.go:87: created relation with id 54
    plan_test.go:87: created relation with id 55
    plan_test.go:87: created relation with id 56
    plan_test.go:87: created relation with id 59
    plan_test.go:130: 
        testdata/drop_view:55: DROP VIEW defaultdb.v1 CASCADE
        output didn't match expected:
        @@ -33,14 +33,14 @@
             DependedOnBy: 56
             TableID: 54
           *scop.MarkDescriptorAsDropped
             DescID: 53
           *scop.RemoveRelationDependedOnBy
        -    DependedOnBy: 54
        +    DependedOnBy: 55
             TableID: 53
           *scop.RemoveRelationDependedOnBy
        -    DependedOnBy: 55
        +    DependedOnBy: 54
             TableID: 53
           *scop.MarkDescriptorAsDropped
             DescID: 55
           *scop.MarkDescriptorAsDropped
             DescID: 59
    --- FAIL: TestPlanAlterTable/drop_view (3.06s)
Help

See also: [How To Investigate a Go Test Failure \(internal\)](https://cockroachlabs.atlassian.net/l/c/HgfXfJgM)Parameters in this failure:

  • GOFLAGS=-json

/cc @cockroachdb/sql-schema

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

sql/schemachanger/scplan.TestPlanAlterTable failed with artifacts on master @ 5d68dff8e52616ed92798c1a01b370e62f57c6a8:

=== RUN   TestPlanAlterTable
    test_log_scope.go:79: test logs captured to: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestPlanAlterTable886244216
    test_log_scope.go:80: use -show-logs to present logs inline
=== CONT  TestPlanAlterTable
    plan_test.go:132: -- test log scope end --
test logs left over in: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestPlanAlterTable886244216
--- FAIL: TestPlanAlterTable (24.35s)
=== RUN   TestPlanAlterTable/drop_schema
    plan_test.go:87: created relation with id 53
    plan_test.go:87: created relation with id 54
    plan_test.go:87: created relation with id 55
    plan_test.go:87: created relation with id 56
    plan_test.go:87: created relation with id 57
    plan_test.go:87: created relation with id 58
    plan_test.go:87: created relation with id 61
    plan_test.go:130: 
        testdata/drop_schema:119: DROP SCHEMA defaultdb.SC1 CASCADE
        output didn't match expected:
        @@ -56,14 +56,14 @@
             DependedOnBy: 61
             TableID: 58
           *scop.MarkDescriptorAsDropped
             DescID: 56
           *scop.RemoveRelationDependedOnBy
        -    DependedOnBy: 57
        +    DependedOnBy: 58
             TableID: 56
           *scop.RemoveRelationDependedOnBy
        -    DependedOnBy: 58
        +    DependedOnBy: 57
             TableID: 56
           *scop.MarkDescriptorAsDropped
             DescID: 55
           *scop.RemoveRelationDependedOnBy
             DependedOnBy: 56
    --- FAIL: TestPlanAlterTable/drop_schema (3.93s)
Help

See also: [How To Investigate a Go Test Failure \(internal\)](https://cockroachlabs.atlassian.net/l/c/HgfXfJgM)Parameters in this failure:

  • GOFLAGS=-json

/cc @cockroachdb/sql-schema

This test on roachdash | Improve this report!

fqazi added a commit to fqazi/cockroach that referenced this issue Nov 10, 2021
@fqazi
sql: new schema changer does not deterministically rank nodes
1b1815d 
Fixes: cockroachdb#72562, cockroachdb#72561

Previously, when we updated the sorting inside the new schema changer
to a rank based approach we incorrectly assumed that DepEdges will always
be generated in a deterministic fashion. This does not happen because
the database and rule matching is not fully determentistic.
Unfortunately, this turned ouut to be false, which can lead
to ranks for neighbour edges to be unstable. To address this,
this patch iterates over DepEdges in a ordered fashion based
on the To nodes, fixing intermittent failures inside the new
schema changer tests.

Release note: None
fqazi added a commit to fqazi/cockroach that referenced this issue Nov 10, 2021
@fqazi
sql: new schema changer does not deterministically rank nodes
d478482 
Fixes: cockroachdb#72562, cockroachdb#72561

Previously, when we updated the sorting inside the new schema changer
to a rank based approach we incorrectly assumed that DepEdges will always
be generated in a deterministic fashion. This does not happen because
the database and rule matching is not fully determentistic.
Unfortunately, this turned ouut to be false, which can lead
to ranks for neighbour edges to be unstable. To address this,
this patch iterates over DepEdges in a ordered fashion based
on the To nodes, fixing intermittent failures inside the new
schema changer tests.

Release note: None
fqazi added a commit to fqazi/cockroach that referenced this issue Nov 11, 2021
@fqazi
sql: new schema changer does not deterministically rank nodes
362b1dc 
Fixes: cockroachdb#72562, cockroachdb#72561

Previously, when we updated the sorting inside the new schema changer
to a rank based approach we incorrectly assumed that DepEdges will always
be generated in a deterministic fashion. This does not happen because
the database and rule matching is not fully determentistic.
Unfortunately, this turned ouut to be false, which can lead
to ranks for neighbour edges to be unstable. To address this,
this patch iterates over DepEdges in a ordered fashion based
on the To nodes, fixing intermittent failures inside the new
schema changer tests.

Release note: None
@craig craig bot closed this as completed in 8d189c8 Nov 12, 2021
@exalate-issue-sync exalate-issue-sync bot added T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) and removed T-sql-schema-deprecated Use T-sql-foundations instead labels May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fqazi fqazi

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: new schema changer does not deterministically rank nodes fqazi/cockroach
2 participants
@fqazi @cockroach-teamcity