Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage/metamorphic: TestPebbleRestarts failed #72269

Closed
cockroach-teamcity opened this issue Oct 31, 2021 · 0 comments · Fixed by #72288
Closed

storage/metamorphic: TestPebbleRestarts failed #72269

cockroach-teamcity opened this issue Oct 31, 2021 · 0 comments · Fixed by #72288
Assignees
@itsbilal
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-storage Storage Team

Comments

@cockroach-teamcity
Copy link
Member

storage/metamorphic.TestPebbleRestarts failed with artifacts on master @ a15b840db34de504bf060b2599276e049cc64799:

Fatal error:

panic: min timestamp hint set without max timestamp hint [recovered]
	panic: min timestamp hint set without max timestamp hint

Stack:

goroutine 1160642 [running]:
testing.tRunner.func1.2(0x12d4340, 0x168b1d0)
	/usr/local/go/src/testing/testing.go:1143 +0x332
testing.tRunner.func1(0xc008ea8600)
	/usr/local/go/src/testing/testing.go:1146 +0x4b6
panic(0x12d4340, 0x168b1d0)
	/usr/local/go/src/runtime/panic.go:965 +0x1b9
github.com/cockroachdb/cockroach/pkg/storage.(*pebbleIterator).init(0xc007e03e60, 0x16c0e20, 0xc0098b8000, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0xc0040da290, ...)
	/go/src/github.com/cockroachdb/cockroach/pkg/storage/pebble_iterator.go:157 +0x92f
github.com/cockroachdb/cockroach/pkg/storage.newPebbleIterator(0x16c0e20, 0xc0098b8000, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0xc0040da290, 0xe, ...)
	/go/src/github.com/cockroachdb/cockroach/pkg/storage/pebble_iterator.go:90 +0xd8
github.com/cockroachdb/cockroach/pkg/storage.(*Pebble).NewMVCCIterator(0xc003fc8100, 0x1, 0x0, 0x0, 0x0, 0x0, 0xc0040da290, 0xe, 0xe, 0x0, ...)
	/go/src/github.com/cockroachdb/cockroach/pkg/storage/pebble.go:861 +0x1e5
github.com/cockroachdb/cockroach/pkg/storage.NewMVCCIncrementalIterator(0x16d0510, 0xc003fc8100, 0x1, 0xc0040da290, 0xe, 0xe, 0x0, 0x0, 0x0, 0x0, ...)
	/go/src/github.com/cockroachdb/cockroach/pkg/storage/mvcc_incremental_iterator.go:177 +0x235
github.com/cockroachdb/cockroach/pkg/storage.MVCCClearTimeRange(0x16c55b0, 0xc000040108, 0x7fd6484e61f0, 0xc003fc8100, 0xc002027860, 0xc0040da260, 0xc, 0xc, 0xc0040da290, 0xe, ...)
	/go/src/github.com/cockroachdb/cockroach/pkg/storage/mvcc.go:2269 +0x298
github.com/cockroachdb/cockroach/pkg/storage/metamorphic.mvccClearTimeRangeOp.run(0xc008ea8900, 0x14b86d5, 0x6, 0xc0040da260, 0xc, 0xc, 0xc0040da290, 0xe, 0xe, 0x0, ...)
	/go/src/github.com/cockroachdb/cockroach/pkg/storage/metamorphic/operations.go:308 +0x1c5
github.com/cockroachdb/cockroach/pkg/storage/metamorphic.(*metaTestRunner).generateAndRun(0xc008ea8900, 0x186a0)
	/go/src/github.com/cockroachdb/cockroach/pkg/storage/metamorphic/generator.go:303 +0x142
github.com/cockroachdb/cockroach/pkg/storage/metamorphic.runMetaTestForEngines(0x16c55b0, 0xc000040108, 0xc008ea8600, 0x1, 0x2bd7e626847cbc94, 0x1, 0x0, 0x0, 0x16a3340, 0xc0093fa128, ...)
	/go/src/github.com/cockroachdb/cockroach/pkg/storage/metamorphic/meta_test.go:89 +0x465
github.com/cockroachdb/cockroach/pkg/storage/metamorphic.runMetaTest.func2(0xc008ea8600)
	/go/src/github.com/cockroachdb/cockroach/pkg/storage/metamorphic/meta_test.go:155 +0x4b8
testing.tRunner(0xc008ea8600, 0xc004884f90)
	/usr/local/go/src/testing/testing.go:1193 +0xef
created by testing.(*T).Run
	/usr/local/go/src/testing/testing.go:1238 +0x2b3
Log preceding fatal error 

=== RUN   TestPebbleRestarts
    test_log_scope.go:79: test logs captured to: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestPebbleRestarts639386760
    test_log_scope.go:80: use -show-logs to present logs inline
first run output file: /go/src/github.com/cockroachdb/cockroach/artifacts/TestPebbleRestarts753048135/output.meta
--- FAIL: TestPebbleRestarts (0.80s)
=== RUN   TestPebbleRestarts/engine/standard
check file = 
output file = /go/src/github.com/cockroachdb/cockroach/artifacts/TestPebbleRestarts753048135/output.meta
store path = /go/src/github.com/cockroachdb/cockroach/artifacts/TestPebbleRestarts_engine_standard728976401/store
    --- FAIL: TestPebbleRestarts/engine/standard (0.78s)

Help

See also: [How To Investigate a Go Test Failure \(internal\)](https://cockroachlabs.atlassian.net/l/c/HgfXfJgM)Parameters in this failure:

  • GOFLAGS=-parallel=4

/cc @cockroachdb/storage itsbilal

This test on roachdash | Improve this report!
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Oct 31, 2021
@blathers-crl blathers-crl bot added the T-storage Storage Team label Oct 31, 2021
@itsbilal itsbilal self-assigned this Nov 1, 2021
@itsbilal itsbilal mentioned this issue Nov 1, 2021
Merged
craig bot pushed a commit that referenced this issue Nov 1, 2021
@itsbilal
Merge #72288
039ed5f 
72288: storage/metamorphic: Increment endTime in ClearTimeRange r=nicktrav a=itsbilal

Eliminates a panic when endTime ends up being the zero
timestamp, and startTime is slightly ahead of endTime
as it gets next()'d in TBI creation but endTime doesn't.

Fixes #72269
Fixes #72261

Release note: None.

Co-authored-by: Bilal Akhtar <[email protected]>
@craig craig bot closed this as completed in d54673d Nov 1, 2021
@craig craig bot closed this as completed in #72288 Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@itsbilal itsbilal

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-storage Storage Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

storage/metamorphic: Increment endTime in ClearTimeRange itsbilal/cockroach
2 participants
@itsbilal @cockroach-teamcity