Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: add 'Interval Start Time' column in statements and transactions table #69648

Closed
xinhaoz opened this issue Aug 31, 2021 · 0 comments · Fixed by #70282
Closed

ui: add 'Interval Start Time' column in statements and transactions table #69648

xinhaoz opened this issue Aug 31, 2021 · 0 comments · Fixed by #70282
Assignees
@xinhaoz
Labels
A-sql-console-general SQL Observability issues on the DB console spanning multiple areas. Includes Cockroach Cloud Console C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) GA-blocker

Comments

@xinhaoz
Copy link
Member

xinhaoz commented Aug 31, 2021

Follow up to #68831

On statements page, add Execution time interval column to the statements table, which shows the aggregation interval for the statement.

This will require adding the agg_interval field from crdb_internal.statements_statistics to the statements stats response.

Designs: https://www.figma.com/file/MoSPFkEyJfGipCmQvvLg1a/21.2_SQL-obsrv_query-performance?node-id=2874%3A118363
@xinhaoz xinhaoz added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-observability A-sql-console-general SQL Observability issues on the DB console spanning multiple areas. Includes Cockroach Cloud Console labels Aug 31, 2021
@xinhaoz xinhaoz changed the title sql: add 'Execution time interval' column in statements table sql: add 'Interval Start Time' column in statements table Sep 16, 2021
@xinhaoz xinhaoz changed the title sql: add 'Interval Start Time' column in statements table sql: add 'Interval Start Time' column in statements and transactions table Sep 16, 2021
xinhaoz added a commit to xinhaoz/cockroach that referenced this issue Sep 16, 2021
@xinhaoz
ui/cluster-ui: add 'Interval Start Time' column to stmts/txns tables
01c333c 
Resolves cockroachdb#69648

This commit adds the `Interval Start Time (UTC)` column to stmt and txn
tables. Statements and transactions are now both grouped by their `aggregated_ts`
field in addition to the stmt / fingerprint id.

To support viewing of statements grouped by aggregation interval start time,
a new query parameter has been added to statement details pages.
If `aggregated_ts` is set, it will display the statement details for statements
aggregated at that interval, using data from combined statements API response.
If unset, we will fetch and show statement data from in-memory stats.

Release note (ui change): A new column, 'Interval Start Time (UTC)', has
been added to both statement and transaction tables. The column represents
the start time in UTC of the stats aggregation interval for a statement.
By default, the aggregation interval is 1 hour.

A new query parameter has been added to statement details pages.
If the search param `aggregated_ts` is set, it will display the statement details
for statements aggregated at that interval. If unset, we will display the statement
details for the statement collected from the last hour.
@xinhaoz xinhaoz mentioned this issue Sep 16, 2021
Merged
xinhaoz added a commit to xinhaoz/cockroach that referenced this issue Sep 21, 2021
@xinhaoz
ui/cluster-ui: add 'Interval Start Time' column to stmts/txns tables
2051127 
Resolves cockroachdb#69648

This commit adds the `Interval Start Time (UTC)` column to stmt and txn
tables. Statements and transactions are now both grouped by their `aggregated_ts`
field in addition to the stmt / fingerprint id.

To support viewing of statements grouped by aggregation interval start time,
a new query parameter has been added to statement details pages.
If `aggregated_ts` is set, it will display the statement details for statements
aggregated at that interval, using data from combined statements API response.
If unset, we will show data aggregated over the current date range.

Release note (ui change): A new column, 'Interval Start Time (UTC)', has
been added to both statement and transaction tables. The column represents
the start time in UTC of the stats aggregation interval for a statement.
By default, the aggregation interval is 1 hour.

A new query parameter has been added to statement details pages.
If the search param `aggregated_ts` is set, it will display the statement details
for statements aggregated at that interval. If unset, we will display the statement
details for the statement aggregated over the current date range.
@xinhaoz xinhaoz changed the title sql: add 'Interval Start Time' column in statements and transactions table ui: add 'Interval Start Time' column in statements and transactions table Sep 23, 2021
xinhaoz added a commit to xinhaoz/cockroach that referenced this issue Sep 28, 2021
@xinhaoz
ui/cluster-ui: add 'Interval Start Time' column to stmts/txns tables
0d29090 
Resolves cockroachdb#69648, cockroachdb#70545

This commit adds the `Interval Start Time (UTC)` column to stmt and txn
tables. Statements and transactions are now both grouped by their `aggregated_ts`
field in addition to the stmt / fingerprint id. On the statement details page,
the 'Interval Start Time' has also been added to the details panel.

To support viewing of statements grouped by aggregation interval start time,
a new query parameter has been added to statement details pages.
If `aggregated_ts` is set, it will display the statement details for statements
aggregated at that interval, using data from combined statements API response.
If unset, we will show data aggregated over the current date range.

Release note (ui change): A new column, 'Interval Start Time (UTC)', has
been added to both statement and transaction tables. The column represents
the start time in UTC of the stats aggregation interval for a statement.
By default, the aggregation interval is 1 hour. 'Interval Start Time' has
been added to the statement details page under 'Statement Details'.

A new query parameter has been added to statement details pages.
If the search param `aggregated_ts` is set, it will display the statement details
for statements aggregated at that interval. If unset, we will display the statement
details for the statement aggregated over the current date range.
craig bot pushed a commit that referenced this issue Sep 29, 2021
@xinhaoz @ajwerner
Merge #70282 #70871
03d3160 
70282: ui/cluster-ui: add 'Interval Start Time' column to stmts/txns tables r=maryliag a=xinhaoz

Resolves #69648, #70545

This commit adds the `Interval Start Time (UTC)` column to stmt and txn
tables. Statements and transactions are now both grouped by their `aggregated_ts`
field in addition to the stmt / fingerprint id. On the statement details page,
the 'Interval Start Time' has also been added to the details panel.

To support viewing of statements grouped by aggregation interval start time,
a new query parameter has been added to statement details pages.
If `aggregated_ts` is set, it will display the statement details for statements
aggregated at that interval, using data from combined statements API response.
If unset, we will show data aggregated over the current date range.

Release note (ui change): A new column, 'Interval Start Time (UTC)', has
been added to both statement and transaction tables. The column represents
the start time in UTC of the stats aggregation interval for a statement.
By default, the aggregation interval is 1 hour. 'Interval Start Time' has
been added to the statement details page under 'Statement Details'.

A new query parameter has been added to statement details pages.
If the search param `aggregated_ts` is set, it will display the statement details
for statements aggregated at that interval. If unset, we will display the statement
details for the statement aggregated over the current date range.

--------------------------------------
Statements Table:
![image](https://user-images.githubusercontent.com/20136951/133510793-b8d3ad12-f1f1-442c-9f03-d19e1ba73739.png)

Transactions Table:
![image](https://user-images.githubusercontent.com/20136951/133510849-b8578f2c-165c-486f-a685-55a4c4b549d7.png)

details page:
![image](https://user-images.githubusercontent.com/20136951/134553530-7d9d1985-60b9-4d1b-80fa-c33e9654fe92.png)


70871: scripts: add todo_diff.sh r=ajwerner a=ajwerner

Adds a shell script to find `TODO`s that have been added between two commits.

Relates to #62552.

Release note: None

Co-authored-by: Xin Hao Zhang <[email protected]>
Co-authored-by: Andrew Werner <[email protected]>
@craig craig bot closed this as completed in 58bc805 Sep 29, 2021
@xinhaoz xinhaoz mentioned this issue Sep 29, 2021
Merged
xinhaoz added a commit to xinhaoz/cockroach that referenced this issue Sep 30, 2021
@xinhaoz
ui/cluster-ui: add 'Interval Start Time' column to stmts/txns tables
aa9ea4d 
Resolves cockroachdb#69648, cockroachdb#70545

Release justification: category 4

This commit adds the `Interval Start Time (UTC)` column to stmt and txn
tables. Statements and transactions are now both grouped by their `aggregated_ts`
field in addition to the stmt / fingerprint id. On the statement details page,
the 'Interval Start Time' has also been added to the details panel.

To support viewing of statements grouped by aggregation interval start time,
a new query parameter has been added to statement details pages.
If `aggregated_ts` is set, it will display the statement details for statements
aggregated at that interval, using data from combined statements API response.
If unset, we will show data aggregated over the current date range.

Release note (ui change): A new column, 'Interval Start Time (UTC)', has
been added to both statement and transaction tables. The column represents
the start time in UTC of the stats aggregation interval for a statement.
By default, the aggregation interval is 1 hour. 'Interval Start Time' has
been added to the statement details page under 'Statement Details'.

A new query parameter has been added to statement details pages.
If the search param `aggregated_ts` is set, it will display the statement details
for statements aggregated at that interval. If unset, we will display the statement
details for the statement aggregated over the current date range.
andy-kimball pushed a commit that referenced this issue Oct 6, 2021
@xinhaoz @andy-kimball
ui/cluster-ui: add 'Interval Start Time' column to stmts/txns tables
32e66fa 
Resolves #69648, #70545

Release justification: category 4

This commit adds the `Interval Start Time (UTC)` column to stmt and txn
tables. Statements and transactions are now both grouped by their `aggregated_ts`
field in addition to the stmt / fingerprint id. On the statement details page,
the 'Interval Start Time' has also been added to the details panel.

To support viewing of statements grouped by aggregation interval start time,
a new query parameter has been added to statement details pages.
If `aggregated_ts` is set, it will display the statement details for statements
aggregated at that interval, using data from combined statements API response.
If unset, we will show data aggregated over the current date range.

Release note (ui change): A new column, 'Interval Start Time (UTC)', has
been added to both statement and transaction tables. The column represents
the start time in UTC of the stats aggregation interval for a statement.
By default, the aggregation interval is 1 hour. 'Interval Start Time' has
been added to the statement details page under 'Statement Details'.

A new query parameter has been added to statement details pages.
If the search param `aggregated_ts` is set, it will display the statement details
for statements aggregated at that interval. If unset, we will display the statement
details for the statement aggregated over the current date range.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xinhaoz xinhaoz

Labels
A-sql-console-general SQL Observability issues on the DB console spanning multiple areas. Includes Cockroach Cloud Console C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) GA-blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ui/cluster-ui: add 'Interval Start Time' column to stmts/txns tables xinhaoz/cockroach
2 participants
@maryliag @xinhaoz