Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: teach dev how to lint #68547

Closed
rickystewart opened this issue Aug 6, 2021 · 0 comments · Fixed by #68559
Closed

dev: teach dev how to lint #68547

rickystewart opened this issue Aug 6, 2021 · 0 comments · Fixed by #68559
Assignees
@rickystewart
Labels
A-build-system C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-dev-inf

Comments

@rickystewart
Copy link
Collaborator

Epic CRDB-8036
@rickystewart rickystewart added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-build-system T-dev-inf labels Aug 6, 2021
@rickystewart rickystewart self-assigned this Aug 6, 2021
@rickystewart rickystewart added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) and removed C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. labels Aug 6, 2021
@rickystewart rickystewart mentioned this issue Aug 6, 2021
Merged
rickystewart added a commit to rickystewart/cockroach that referenced this issue Aug 6, 2021
@rickystewart
dev: teach dev how to lint
968165e 
Closes cockroachdb#68547.

Release note: None
craig bot pushed a commit that referenced this issue Aug 9, 2021
@rickystewart
Merge #68559
5473933 
68559: dev: teach dev how to lint r=rail a=rickystewart

(Only the most recent commit applies for this review, the other is from #68514)

Closes #68547.

Release note: None

Co-authored-by: Ricky Stewart <[email protected]>
@craig craig bot closed this as completed in ae6eb78 Aug 9, 2021
sajjadrizvi pushed a commit to sajjadrizvi/cockroach that referenced this issue Aug 10, 2021
@rickystewart
dev: teach dev how to lint
ad92af7 
Closes cockroachdb#68547.

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rickystewart rickystewart

Labels
A-build-system C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-dev-inf
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dev: teach dev how to lint rickystewart/cockroach
1 participant
@rickystewart