sql: creating new tables using crdb_internal.unsafe_upsert_descriptor should affect ID generation
#68230
Assignees
Labels
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
T-sql-foundations
SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Comments
ajwerner
added
the
C-bug
|
This should only fast-forward the counter if the |
craig bot
pushed a commit
that referenced
this issue
Aug 13, 2021
68662: sql: unsafe_upsert_descriptor to bump descriptor ID sequence r=postamar a=postamar Previously, it was possible to use this descriptor repair function to insert a new descriptor with an ID greater than any descriptor in the cluster and would not update the descriptor ID sequence value. Subsequent CREATE statements would therefore write descriptors with IDs smaller or equal to the descriptor inserted previously. In the equal case, this corrupts the schema. This commit adds a test that checks that the ID is less than the value stored in the descriptor ID sequence. When that is not the case: - an error is returned when the `force` flag is not set, - otherwise, the sequence value is incremented appropriately. Fixes #68230. Release note: None Co-authored-by: Marius Posta <[email protected]>
ajwerner
pushed a commit
to ajwerner/cockroach
that referenced
this issue
Oct 19, 2021
Previously, it was possible to use this descriptor repair function to insert a new descriptor with an ID greater than any descriptor in the cluster and would not update the descriptor ID sequence value. Subsequent CREATE statements would therefore write descriptors with IDs smaller or equal to the descriptor inserted previously. In the equal case, this corrupts the schema. This commit adds a test that checks that the ID is less than the value stored in the descriptor ID sequence. When that is not the case: - an error is returned when the `force` flag is not set, - otherwise, the sequence value is incremented appropriately. Fixes cockroachdb#68230. Release note: None
exalate-issue-sync
bot
added
T-sql-foundations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the problem
If you use a tool like
cockroach debug doctor recreateto add descriptors, it will not change the ID generation counter. That means that subsequent descriptor creation may fail due to a conflict with existing descriptors.The text was updated successfully, but these errors were encountered: