importccl: Bundle format imports do not support UDT #67983
Labels
A-import
Issues related to IMPORT syntax
C-enhancement
Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
T-sql-queries
SQL Queries Team
Comments
adityamaru
added
C-enhancement
|
cc: @nihalpednekar since you have been working in this area |
This was referenced Jul 23, 2021
craig bot
pushed a commit
that referenced
this issue
Aug 5, 2021
67994: importccl: fail PGDUMP IMPORT if we see a UDT r=pbardea a=adityamaru In 21.1 we added `ignore_unsupported_statements` that ignored all statements that we didnt support while parsing the PGDUMP file. We don't support `CREATE TYPE` and its subsequent usage, and this currently causes a NPE. While we work on adding UDT support to PGDUMP we should make an exception to the ignore option and fail the import instead. Informs: #67983 Release note (bug fix): IMPORT PGDUMP with a UDT would result in a nil pointer exception. This change makes it fail gracefully. Co-authored-by: Aditya Maru <[email protected]>
exalate-issue-sync
bot
added
T-sql-foundations
rafiss
removed
the
T-sql-foundations
exalate-issue-sync
bot
added
T-sql-foundations
rafiss
added
T-sql-queries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bundle formats such as PGDUMP and MYSQLDUMP do not support user-defined types. Today, PGDUMP files with
CREATE TYPEstatements will either fail or ignore the create type based on whetherignore_unsupported_statementswas passed.If a column in a table in the dump file uses the UDT then this leads to all sorts of undefined behavior (currently a NPE). Since bundle formats offer us the guarantee that we will only use objects that are in the dump file itself, we should add support for
CREATE TYPEsimilar to how we handle UDS.Jira issue: CRDB-8814
Epic CRDB-8353
The text was updated successfully, but these errors were encountered: