streamclient: panic in TestIdleExit #67592
Labels
A-disaster-recovery
C-test-failure
Broken test (automatically or manually discovered).
T-disaster-recovery
Comments
knz
added
C-test-failure
knz
changed the title
streamclient
adityamaru
added a commit
to adityamaru/cockroach
that referenced
this issue
Jul 28, 2021
Previously, the close implementation of channelFeedSource closed the `eventCh` as a means of shutting down the client. This seems wrong since the client is the "owner" of this channel and should be the only one responsible for closing it. In cases where the method `consumeUntil` hit an error (max wait timeout in our case) we would close the eventCh as part of calling channelFeedSource's Close(), and we would attempt a double close in the sinkless client itself. This change switches to cancelling the sinkless client's context to indicate to the client that it should shutdown. I was not able to reproduce this error (5000 stress runs), but I bumped the timeout from 10 seconds to 20 seconds based on stack traces in the failed builds. Fixes: cockroachdb#68168 Fixes: cockroachdb#67592 Release note: None
craig bot
pushed a commit
that referenced
this issue
Jul 28, 2021
66735: sql: add datadriven tests for multiregion tables r=arulajmani a=pawalt Previously, we only had datadriven tests for GLOBAL tables. This patch adds datadriven tests for REGIONAL BY TABLE tables. Release note: None 68017: bazel: bazelfy logging documentation r=rail a=rickystewart In doing so, I also noticed a couple generated `.go` files that weren't yet bazelfied, so I took care of them too. Closes #65812. Release note: None 68078: bazel: add build target for generated bnf's r=rail a=rickystewart Closes #65815. Release note: None 68189: streamingccl: fix double close in test feed source r=miretskiy a=adityamaru Previously, the close implementation of channelFeedSource closed the `eventCh` as a means of shutting down the client. This seems wrong since the client is the "owner" of this channel and should be the only one responsible for closing it. In cases where the method `consumeUntil` hit an error (max wait timeout in our case) we would close the eventCh as part of calling channelFeedSource's Close(), and we would attempt a double close in the sinkless client itself. This change switches to cancelling the sinkless client's context to indicate to the client that it should shutdown. I was not able to reproduce this error (5000 stress runs), but I bumped the timeout from 10 seconds to 20 seconds based on stack traces in the failed builds. Fixes: #68168 Fixes: #67592 Release note: None Co-authored-by: Peyton Walters <[email protected]> Co-authored-by: Ricky Stewart <[email protected]> Co-authored-by: Aditya Maru <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
and others
From
https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_UnitTests/3181970?
Epic CRDB-7778
The text was updated successfully, but these errors were encountered: