Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: build and consume x86_64-apple-darwin cross toolchain in CI #66210

Closed
rickystewart opened this issue Jun 8, 2021 · 0 comments · Fixed by #66921
Closed

bazel: build and consume x86_64-apple-darwin cross toolchain in CI #66210

rickystewart opened this issue Jun 8, 2021 · 0 comments · Fixed by #66921
Labels
A-build-system C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-dev-inf

Comments

@rickystewart
Copy link
Collaborator

rickystewart commented Jun 8, 2021

Epic CRDB-8036

@rickystewart rickystewart added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-build-system labels Jun 8, 2021
craig bot pushed a commit that referenced this issue Jun 28, 2021
66811: clusterversion: make some room for a v21.1PLUS "release" r=RaduBerinde a=RaduBerinde

The summer serverless offering requires an "in-between" release which
is v21.1.x plus multitenant-specific functionality. We will call this
the v21.1PLUS release. It has not yet been decided if v21.1PLUS
changes will become part of the 21.1.x branch or whether it will live
on its own branch.

This commit shifts cluster versions around to make some space for
migrations specific to this release:
 - we shift existing v21.2 versions (Major=21, Minor=1, Internal=2
   to Internal=102 through 112. Consequently, any existing cluster
   running `master` will rerun all the 21.2 migrations (which is ok
   since they are required to be idempotent).

 - we start a new chunk of v21.1PLUS versions at Major=21, Minor=1,
   Internal=14. We start at a value higher than the current master to
   avoid any confusion on clusters running master.

Any new v21.1PLUS feature that needs a migration will be developed on
master and will add a v21.2 version, e.g.
```
   {
     Key:     DeleteDeprecatedNamespaceTableDescriptorMigration,
     Version: roachpb.Version{Major: 21, Minor: 1, Internal: 112},
   },
+  {
+    Key:     SomeServerlessSpecificFeature,
+    Version: roachpb.Version{Major: 21, Minor: 1, Internal: 114},
+  },
```

When that change is backported to v21.1PLUS, this will become a
v21.2PLUS version:
```
   {
     Key: Start21_1PLUS,
     Version: roachpb.Version{Major: 21, Minor: 1, Internal: 14},
   },
+  {
+    Key:     SomeServerlessSpecificFeature,
+    Version: roachpb.Version{Major: 21, Minor: 1, Internal: 16},
+  },
```

Release note: None

66886: admission: optimizations to admission.WorkQueue r=sumeerbhola a=sumeerbhola

These small optimizations reduce memory allocations and
the length of the critical sections.

A 10s mutex profile of kv50 with cpu overload had
~1.2s (of a total of 2s) in the admission package.
This was correlated with what showed up in the
corresponding cpu profile, which directed these
changes.

Release note: None

66921: build: add script for build config to cross-compile to macos r=rail a=rickystewart

Also generalize some scripts that were unnecessarily repetitive.

Closes #66210

Release note: None

66957: Add dev-inf as codeowners for /build/ r=rail,rickystewart a=jlinder

Before: no owners were set for /build/

Why: dev-inf owns /build/

Now: dev-inf is set as code owners for /build/

Release note: None

Co-authored-by: Radu Berinde <[email protected]>
Co-authored-by: sumeerbhola <[email protected]>
Co-authored-by: Ricky Stewart <[email protected]>
Co-authored-by: James H. Linder <[email protected]>
@craig craig bot closed this as completed in 8333dd9 Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-build-system C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-dev-inf
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants