Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: add build targets for function/operator documentation #65811

Closed
rickystewart opened this issue May 27, 2021 · 0 comments · Fixed by #65866
Closed

bazel: add build targets for function/operator documentation #65811

rickystewart opened this issue May 27, 2021 · 0 comments · Fixed by #65866
Assignees
Labels
A-build-system C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@rickystewart
Copy link
Collaborator

Build function and operator documentation with Bazel.

  • This is generated with docgen.

Blocks #65070.

@rickystewart rickystewart added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-build-system labels May 27, 2021
@rickystewart rickystewart self-assigned this May 28, 2021
craig bot pushed a commit that referenced this issue Jun 1, 2021
65474: changefeedccl: Support enum columns in avro encoding r=[miretskiy] a=HonoreDB

In the JSON encoder, enums are rendered as strings,
and if a type is altered, this is reflected in future messages
but doesn't backfill. Because a backfill would be nontrivial,
we're doing the same thing in the avro encoder rather than use
the Avro enum type.

Note that enums are not a built-in type and therefore not
hit in avro_test.go. I'm hoping to figure out how to fix that
before merging this commit, or as a followup.

Release note (bug fix): Enum columns can be encoded in avro changefeeds

65683: server: Reject SQL Pods with an invalid tenant id. r=ajwerner a=rimadeodhar

This commit fixes an issue where attempting to start a SQL Pod
through cockroach mt start-sql command returns an error if the
tenant id has not been created before. Previously, attempting to
start a SQL Pod with a non existent tenant id would crash. Even
worse, it would poison the tenant id causing future
crdb_internal.create_sql_tenant calls to fail.
With this fix, the cockroach mt start-sql command returns an error
for non existent tenant ids and future calls to
crdb_internal.create_sql_tenant are successful.

Resolves: #64963

Release note (bug fix): The cockroach mt start-sql command with a
non existent tenant id returns an error. Previously, it would
crash and poison the tenant id for future usage.

65750: sql: fix schema privileges on descriptor read r=ajwerner a=RichardJCai

Release note (bug fix): Previously a schema's privilege descriptor
could become corrupted upon executing ALTER DATABASE ...
CONVERT TO SCHEMA due to privileges that are invalid on a schema
being copied over to the schema rendering the schema inusable due
to invalid privileges.

Fixes #65697

65866: bazel: add targets to generate cluster setting/functions documentation r=rail a=rickystewart

I validated that these work and have a clean `diff` with what's in tree.

Closes #65808.
Closes #65811.

Release note: None

65907:  opt: normalize x=True, x=False, x != True, and x != False to x or NOT x r=rytaft a=rytaft

This commit adds four normalization rules, `FoldEqTrue`, `FoldEqFalse`, 
`FoldNeTrue`, and `FoldNeFalse`, which normalize `x=True` to `x`, `x=False` to
`NOT x`, `x != True` to `NOT x`, and `x != False` to `x`. These rules are
important since they can unlock other types of optimizations, such
as constrained index scans.

Fixes #65684

Release note (performance improvement): Fixed an issue in the optimizer
that prevented spatial predicates of the form `(column && value) = true` from
being index-accelerated. These queries can now use a spatial index if one is
available.

65960: bazel: bump size of `//pkg/sql:sql_test` r=rail a=rickystewart

This has been routinely timing out in CI.

Release note: None

Co-authored-by: Aaron Zinger <[email protected]>
Co-authored-by: rimadeodhar <[email protected]>
Co-authored-by: richardjcai <[email protected]>
Co-authored-by: Ricky Stewart <[email protected]>
Co-authored-by: Rebecca Taft <[email protected]>
@craig craig bot closed this as completed in e20d10a Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-build-system C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant