Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv/kvserver: TestReliableIntentCleanup failed #65447

Closed
cockroach-teamcity opened this issue May 19, 2021 · 0 comments · Fixed by #65592
Closed

kv/kvserver: TestReliableIntentCleanup failed #65447

cockroach-teamcity opened this issue May 19, 2021 · 0 comments · Fixed by #65592
Assignees
@erikgrinaker
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.

Comments

@cockroach-teamcity
Copy link
Member

kv/kvserver.TestReliableIntentCleanup failed with artifacts on master @ 35789fc888598b0bb4b37b5fcb6cf42f38e70acb:

=== RUN   TestReliableIntentCleanup
    test_log_scope.go:73: test logs captured to: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestReliableIntentCleanup999028237
    test_log_scope.go:74: use -show-logs to present logs inline
=== CONT  TestReliableIntentCleanup
    intent_resolver_integration_test.go:430: -- test log scope end --
test logs left over in: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestReliableIntentCleanup999028237
--- FAIL: TestReliableIntentCleanup (324.06s)
=== RUN   TestReliableIntentCleanup/ForceSyncIntentResolution=false
    --- FAIL: TestReliableIntentCleanup/ForceSyncIntentResolution=false (152.90s)
=== RUN   TestReliableIntentCleanup/ForceSyncIntentResolution=false/numKeys=100000/singleRange=false/txn=true/finalize=abort
    intent_resolver_integration_test.go:414: 
        	Error Trace:	intent_resolver_integration_test.go:340
        	            				intent_resolver_integration_test.go:414
        	            				subtest.go:34
        	Error:      	Received unexpected error:
        	            	TransactionRetryWithProtoRefreshError: TransactionAbortedError(ABORT_REASON_CLIENT_REJECT): "test" meta={id=6385d9df key="key\x00\x98\xc7Q\n" pri=0.01362632 epo=0 ts=1621403211.923940725,1 min=1621403211.231436946,0 seq=30001} lock=true stat=PENDING rts=1621403211.231436946,0 wto=false gul=1621403211.731436946,0
        	Test:       	TestReliableIntentCleanup/ForceSyncIntentResolution=false/numKeys=100000/singleRange=false/txn=true/finalize=abort
                    --- FAIL: TestReliableIntentCleanup/ForceSyncIntentResolution=false/numKeys=100000/singleRange=false/txn=true/finalize=abort (2.11s)
=== RUN   TestReliableIntentCleanup/ForceSyncIntentResolution=false/numKeys=100000/singleRange=false/txn=true
                --- FAIL: TestReliableIntentCleanup/ForceSyncIntentResolution=false/numKeys=100000/singleRange=false/txn=true (24.52s)
=== RUN   TestReliableIntentCleanup/ForceSyncIntentResolution=false/numKeys=100000/singleRange=false
            --- FAIL: TestReliableIntentCleanup/ForceSyncIntentResolution=false/numKeys=100000/singleRange=false (30.39s)
=== RUN   TestReliableIntentCleanup/ForceSyncIntentResolution=false/numKeys=100000
        --- FAIL: TestReliableIntentCleanup/ForceSyncIntentResolution=false/numKeys=100000 (136.36s)
Reproduce

To reproduce, try: 

make stressrace TESTS=TestReliableIntentCleanup PKG=./pkg/kv/kvserver TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1

Parameters in this failure:

  • GOFLAGS=-json

/cc @cockroachdb/kv erikgrinaker

This test on roachdash | Improve this report!
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels May 19, 2021
@erikgrinaker erikgrinaker self-assigned this May 19, 2021
This was referenced May 19, 2021
Closed
Merged
craig bot pushed a commit that referenced this issue May 19, 2021
@erikgrinaker
Merge #65461
95b6c1f 
65461: kvserver: skip TestReliableIntentCleanup r=tbg a=erikgrinaker

This test is flaky because it does not retry transaction failures.
However, the retries uncovered additional bugs, so skipping the test for
now to avoid CI flake.

Touches #65447 and #65458.

Release note: None

/cc @cockroachdb/kv 

Co-authored-by: Erik Grinaker <[email protected]>
This was referenced May 23, 2021
Merged
Closed
Closed
@craig craig bot closed this as completed in b479177 May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erikgrinaker erikgrinaker

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

kvcoord: prevent concurrent EndTxn requests erikgrinaker/cockroach
2 participants
@erikgrinaker @cockroach-teamcity