-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: TestCancelQueryPermissions flaking #63547
Comments
Interesting.. I unskipped this a month ago since I couldn't reproduce the flake under stress: #62132 |
This has gotten much more prevalent, skipping this test. The problem is that the test is doing illegal things. It leaks a bunch of goroutines that outlive the subtest and may end up accessing |
(It uses |
Refs: cockroachdb#63547 Reason: https://cockroachlabs.slack.com/archives/C016CAD2HQ8/p1627290710022700 Generated by bin/skip-test. Release justification: non-production code changes Release note: None
I should also mention, I tried to fix this test, but it's not easy since |
(One way to do it is to set up a new testserver for each subtest) |
68038: build: remove pointless rebuilds of cluster-ui r=jordanlewis a=jordanlewis Since 60916fb, any change to any file in any subdirectory of pkg/ui would cause a full rebuild of pkg/ui/cluster-ui, which would then cause a full rebuild of pkg/ui as well. Now, pkg/ui/cluster-ui's source files are tracked separately, so changes to pkg/ui/ that don't touch cluster-ui won't force a rebuild of cluster-ui. This should save a lot of time, hopefully. Touching a single .tsx file in pkg/ui/src used to cause 30+ seconds of build time due to this issue, now it is significantly faster since the various webpack caches can actually be used again. Release note: None cc @cockroachdb/cluster-ui-prs @cockroachdb/sql-observability 68059: sql: skip TestCancelQueryPermissions r=irfansharif a=tbg Refs: #63547 Reason: https://cockroachlabs.slack.com/archives/C016CAD2HQ8/p1627290710022700 Generated by bin/skip-test. Release justification: non-production code changes Release note: None Co-authored-by: Jordan Lewis <[email protected]> Co-authored-by: Tobias Grieger <[email protected]>
The
TestCancelQueryPermissions
flaked with:Flake can be found at - https://teamcity.cockroachdb.com/viewLog.html?buildId=2876992&buildTypeId=Cockroach_UnitTests
Not skipping for now, as we have only seen one instance of it.
The text was updated successfully, but these errors were encountered: