Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: Add multi-region testing for CREATE TABLE AS #62326

Closed
ajstorm opened this issue Mar 21, 2021 · 0 comments
Closed

sql: Add multi-region testing for CREATE TABLE AS #62326

ajstorm opened this issue Mar 21, 2021 · 0 comments
Labels
A-multiregion Related to multi-region C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@ajstorm
Copy link
Collaborator

ajstorm commented Mar 21, 2021

We currently don’t have any testing around CREATE TABLE AS from a table with a table locality assigned. We should validate the basic interaction between CTAS works with table locality configurations.

Notes:

  • Do we want to allow setting of localities here?
  • In multi-region database will it assign a locality config?
  • Follow up with Product to see if it’s acceptable that this only creates a RBT table
@ajstorm ajstorm added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-multiregion Related to multi-region labels Mar 21, 2021
ajstorm added a commit to ajstorm/cockroach that referenced this issue Apr 21, 2021
@ajstorm
sql: Add test for CREATE TABLE AS on REGIONAL BY ROW table
d97ffb7 
Previously we were unable to make CREATE TABLE AS run on a REGIONAL BY
ROW TABLE end up with a table that was (nearly) identical to the
original REGIONAL BY ROW table. This was due to the fact that we didn't
support setting a column to be NOT VISIBLE. With cockroachdb#63052 we added the
support for NOT VISIBLE on ALTER COLUMN which makes getting pretty close
to a REGIONAL BY ROW TABLE now possible when starting from CREATE TABLE
AS. This commit adds a test case to illustrate this fact.

Resolves cockroachdb#62326.

Release note: None
@craig craig bot closed this as completed in 92d1b7c Apr 22, 2021
ajstorm added a commit to ajstorm/cockroach that referenced this issue May 28, 2021
@ajstorm
sql: Add test for CREATE TABLE AS on REGIONAL BY ROW table
cd09155 
Previously we were unable to make CREATE TABLE AS run on a REGIONAL BY
ROW TABLE end up with a table that was (nearly) identical to the
original REGIONAL BY ROW table. This was due to the fact that we didn't
support setting a column to be NOT VISIBLE. With cockroachdb#63052 we added the
support for NOT VISIBLE on ALTER COLUMN which makes getting pretty close
to a REGIONAL BY ROW TABLE now possible when starting from CREATE TABLE
AS. This commit adds a test case to illustrate this fact.

Resolves cockroachdb#62326.

Release note: None
ajstorm added a commit to ajstorm/cockroach that referenced this issue May 31, 2021
@ajstorm
sql: Add test for CREATE TABLE AS on REGIONAL BY ROW table
d7f1a92 
Previously we were unable to make CREATE TABLE AS run on a REGIONAL BY
ROW TABLE end up with a table that was (nearly) identical to the
original REGIONAL BY ROW table. This was due to the fact that we didn't
support setting a column to be NOT VISIBLE. With cockroachdb#63052 we added the
support for NOT VISIBLE on ALTER COLUMN which makes getting pretty close
to a REGIONAL BY ROW TABLE now possible when starting from CREATE TABLE
AS. This commit adds a test case to illustrate this fact.

Resolves cockroachdb#62326.

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-multiregion Related to multi-region C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ajstorm