Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workload/schemachange: add multi-region syntaxes #62191

Closed
4 of 6 tasks
otan opened this issue Mar 18, 2021 · 2 comments
Closed
4 of 6 tasks

workload/schemachange: add multi-region syntaxes #62191

otan opened this issue Mar 18, 2021 · 2 comments
Labels
A-multiregion Related to multi-region C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) no-issue-activity T-multiregion X-stale

Comments

@otan
Copy link
Contributor

otan commented Mar 18, 2021 •
edited by cockroach-jira-scripts
Loading

  • Add regions to schema changer setup
  • Add ADD REGION
  • Add DROP REGION to schema changer
  • Add SURVIVE to schema changer
  • Add LOCALITY changes to schema changer
  • Add validation of zone configs to the schema changer

Jira issue: CRDB-2826
@otan otan added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-multiregion Related to multi-region labels Mar 18, 2021
@otan otan self-assigned this Mar 18, 2021
@otan otan mentioned this issue Mar 30, 2021
Merged
craig bot pushed a commit that referenced this issue Mar 30, 2021
@otan
Merge #62784
8639dd1 
62784: workload/schemachange: add ALTER TABLE ... LOCALITY r=ajwerner a=otan

Added LOCALITY for REGIONAL BY TABLE and GLOBAL tables. Held off on
REGIONAL BY ROW for now as that requires rejecting everything else
in the transaction, which requires more massaging.

Refs: #62191 

Release note: None

Co-authored-by: Oliver Tan <[email protected]>
@otan otan changed the title schemachanger: add multi-region syntaxes workload/schemachange: add multi-region syntaxes May 4, 2021
@otan
Copy link
Contributor Author

otan commented May 4, 2021 •
edited
Loading

deferring the remaining work because workload/schemachange is broken and blocked by #63328

@otan otan removed their assignment May 4, 2021
@github-actions
Copy link

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-multiregion Related to multi-region C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) no-issue-activity T-multiregion X-stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jlinder @otan