-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roachtest: tpccbench/nodes=9/cpu=4/multi-region failed [overload,closed ts regressing from X to Y] #61981
Comments
Here's this test's history: The same analysis as #61973 (comment) applies. (tl;dr #59992 made things worse ~Feb 15; #61777 improved things ~ Mar 13th). As for the particular failure above:
Seems unrelated to everything? |
Same as #61181? @nvanbenschoten, know what's up? |
(roachtest).tpccbench/nodes=9/cpu=4/multi-region failed on master@597e4a8c487e3c23d64885563d608a692b59055c:
More
Artifacts: /tpccbench/nodes=9/cpu=4/multi-region
See this test on roachdash |
(roachtest).tpccbench/nodes=9/cpu=4/multi-region failed on master@36dea46f8cedf42df31b57dd70db7e0f1fd7a453:
More
Artifacts: /tpccbench/nodes=9/cpu=4/multi-region
See this test on roachdash |
(roachtest).tpccbench/nodes=9/cpu=4/multi-region failed on master@ee9f47b9ec9476a693464e2dcd09a01bf9d39ad2:
More
Artifacts: /tpccbench/nodes=9/cpu=4/multi-region
See this test on roachdash |
(roachtest).tpccbench/nodes=9/cpu=4/multi-region failed on master@3d19b2cf6b290a152b23722fc32e995eed3b437b:
More
Artifacts: /tpccbench/nodes=9/cpu=4/multi-region
See this test on roachdash |
(roachtest).tpccbench/nodes=9/cpu=4/multi-region failed on master@893643b63ea0b1cfa4888c6b73b5c68a9c100c3a:
More
Artifacts: /tpccbench/nodes=9/cpu=4/multi-region
See this test on roachdash |
(roachtest).tpccbench/nodes=9/cpu=4/multi-region failed on master@53bf501e233c337b9863755914d9c00010517329:
More
Artifacts: /tpccbench/nodes=9/cpu=4/multi-region
See this test on roachdash |
(roachtest).tpccbench/nodes=9/cpu=4/multi-region failed on master@9fa4b125bfb07552b43ba4fd52c9301afd7a937b:
More
Artifacts: /tpccbench/nodes=9/cpu=4/multi-region
See this test on roachdash |
(roachtest).tpccbench/nodes=9/cpu=4/multi-region failed on master@cbebc6e05491c6951216993ed5e12e22504624f2:
More
Artifacts: /tpccbench/nodes=9/cpu=4/multi-region
See this test on roachdash |
This patch adds historical information to the assertion against closed timestamp regressions. We've seen that assertion fire in cockroachdb#61981. The replica now maintains info about what command last bumped the ClosedTimestamp. Release note: None
Added GA-blocker due to the closed timestamp regression in #61981 (comment) Some more context: #62655 (comment) |
This patch adds historical information to the assertion against closed timestamp regressions. We've seen that assertion fire in cockroachdb#61981. The replica now maintains info about what command last bumped the ClosedTimestamp. Release note: None
This patch adds historical information to the assertion against closed timestamp regressions. We've seen that assertion fire in cockroachdb#61981. The replica now maintains info about what command last bumped the ClosedTimestamp. Release note: None
This patch adds historical information to the assertion against closed timestamp regressions. We've seen that assertion fire in cockroachdb#61981. The replica now maintains info about what command last bumped the ClosedTimestamp. Release note: None
This patch adds historical information to the assertion against closed timestamp regressions. We've seen that assertion fire in cockroachdb#61981. The replica now maintains info about what command last bumped the ClosedTimestamp. Release note: None
This patch adds historical information to the assertion against closed timestamp regressions. We've seen that assertion fire in cockroachdb#61981. The replica now maintains info about what command last bumped the ClosedTimestamp. Release note: None
This patch improves the closed timestamp regression assertion we've seen fire in cockroachdb#61981 to include a tail of the Raft log. Hopefully we never see that assertion fire again, but still I'd like to introduce a precedent for easily printing the log programatically. Also, the assertion now tells people about COCKROACH_RAFT_CLOSEDTS_ASSERTIONS_ENABLED. If the assertion fires and crashes nodes, those nodes will continue crashing on restart as they try to apply the same entries over and over. Release note: None
I've removed the GA-blocker since I couldn't repro the closed ts regression and it hasn't shown up through other channels since either. I think it's time to let go. My hope is that we've fixed the issue somehow. If not, the respective assertion will give us more info next time it happens... |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
#61981 (comment) is infra fluke
Great |
See cockroachdb#61981 (comment). Release note: None
#61981 (comment) had n5 die during the initial rebalancing period. The logs look very unhappy, overloaded basically with a number of unavailable ranges due to snapshot problems. This is running with
The SHA didn't have #64060, which is why I hope that the next repro will look cleaner. I am tempted to ignore it this time for that reason. |
Will the assertion lead us to this issue? I would like to close this issue to take it off the docket since it's now unactionable. |
This patch improves the closed timestamp regression assertion we've seen fire in cockroachdb#61981 to include a tail of the Raft log. Hopefully we never see that assertion fire again, but still I'd like to introduce a precedent for easily printing the log programatically. Also, the assertion now tells people about COCKROACH_RAFT_CLOSEDTS_ASSERTIONS_ENABLED. If the assertion fires and crashes nodes, those nodes will continue crashing on restart as they try to apply the same entries over and over. Release note: None
This patch improves the closed timestamp regression assertion we've seen fire in cockroachdb#61981 to include a tail of the Raft log. Hopefully we never see that assertion fire again, but still I'd like to introduce a precedent for easily printing the log programatically. Also, the assertion now tells people about COCKROACH_RAFT_CLOSEDTS_ASSERTIONS_ENABLED. If the assertion fires and crashes nodes, those nodes will continue crashing on restart as they try to apply the same entries over and over. Release note: None
See cockroachdb#61981 (comment). Release note: None
(roachtest).tpccbench/nodes=9/cpu=4/multi-region failed on master@bdff5338ca725bf1cfddf7e3f648bbf02ab42999:
More
Artifacts: /tpccbench/nodes=9/cpu=4/multi-region
Related:
roachtest: tpccbench/nodes=9/cpu=4/multi-region failed #61710 roachtest: tpccbench/nodes=9/cpu=4/multi-region failed C-test-failure O-roachtest O-robot branch-release-21.1 release-blocker
roachtest: tpccbench/nodes=9/cpu=4/multi-region failed [attempt to create load generator failed] #61181 roachtest: tpccbench/nodes=9/cpu=4/multi-region failed [attempt to create load generator failed] C-test-failure O-roachtest O-robot branch-release-20.2
See this test on roachdash
powered by pkg/cmd/internal/issues
The text was updated successfully, but these errors were encountered: