Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: postgres diff tool detects indexes as tables #61860

Closed
mnovelodou opened this issue Mar 11, 2021 · 1 comment · Fixed by #62559
Closed

sql: postgres diff tool detects indexes as tables #61860

mnovelodou opened this issue Mar 11, 2021 · 1 comment · Fixed by #62559
Assignees
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. X-blathers-triaged blathers was able to find an owner

Comments

@mnovelodou
Copy link
Contributor

Describe the problem
Diff tool is reporting missing tables tables such as pg_aggregate_fnoid_index as missing tables

To Reproduce

  1. Remove the expected diffs (pkg/sql/testdata/pg_catalog_test_expected_diffs.json)
  2. Run diff tool, you'll get pg_aggregate_fnoid_index and other indexes reported

Expected behavior
Diff tool should report only tables

Additional data / screenshots

Environment:

  • CockroachDB version: master branch
  • Server OS: OSX
  • Client app: Unit Test

Additional context
What was the impact?
We are adding indexes as tables in the pg_catalog

Add any other context about the problem here.
Need to update the query that retrieves the tables in postgres

@mnovelodou mnovelodou added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Mar 11, 2021
@mnovelodou mnovelodou self-assigned this Mar 11, 2021
@blathers-crl
Copy link

blathers-crl bot commented Mar 11, 2021

Hello, I am Blathers. I am here to help you get the issue triaged.

Hoot - a bug! Though bugs are the bane of my existence, rest assured the wretched thing will get the best of care here.

I have CC'd a few people who may be able to assist you:

If we have not gotten back to your issue within a few business days, you can try the following:

  • Join our community slack channel and ask on #cockroachdb.
  • Try find someone from here if you know they worked closely on the area and CC them.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl blathers-crl bot added O-community Originated from the community X-blathers-triaged blathers was able to find an owner labels Mar 11, 2021
@rafiss rafiss removed the O-community Originated from the community label Mar 11, 2021
craig bot pushed a commit that referenced this issue Mar 25, 2021
62308: cli/haproxy: tweak the generated haproxy config r=stevendanna a=knz

Fixes #54347.

See #54347
for discussion.

Release note (cli change): the number of connection retries
and connection timeouts for configurations generated
by `cockroach gen haproxy` have been tweaked.



62336: cli/connect: fix typo in informational output r=stevendanna a=knz

First commit from #62335. 
Fixes #61613.



62559: sql: fixed pulling indexes as tables on difftool r=RichardJCai a=mnovelodou

Previously, diff tool was pulling indexes on pg_catalog as tables
This was inadequate because it is a false positive and can be created
as table in diff tool
To address this, this patch fixed the query to identify and filter out
indexes

Release note: None

Fixes #61860

Co-authored-by: Raphael 'kena' Poss <[email protected]>
Co-authored-by: MiguelNovelo <[email protected]>
@craig craig bot closed this as completed in 45c5e91 Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. X-blathers-triaged blathers was able to find an owner
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants