Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql/ui: add tooltips to explain plans in db console #61764

Closed
awoods187 opened this issue Mar 10, 2021 · 6 comments · Fixed by #70568
Closed

sql/ui: add tooltips to explain plans in db console #61764

awoods187 opened this issue Mar 10, 2021 · 6 comments · Fixed by #70568
Assignees
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) GA-blocker

Comments

@awoods187
Copy link
Contributor

@RaduBerinde outlined a proposal today to help others better understand EXPLAIN. EXPLAIN plans contain a lot of information. It can confusing to consume them directly. It would be great if we could provide tooltips in the DB Console for the various parts of explain and also in the SQL Shell (via verbose mode?).

cc @Annebirzin

@awoods187 awoods187 added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Mar 10, 2021
@Annebirzin
Copy link

Right now we still show the logical plan in db-console correct? So adding tooltips to the explain would rely on us updating the logical plan tab to the new explain plan?

@RaduBerinde
Copy link
Member

The logical plan in the db-console is pretty much the new explain plan, it's just formatted differently.

@awoods187
Copy link
Contributor Author

As an aside, we should probably update the explain in the db console to match the SQL shell as much as possible.

This item is about adding tooltips in the db console for defining what a span is, or an index, or distributed, vectorized, etc. Similarly, this could be an option in the SQL shell via verbose but I think its less needed.

@Annebirzin
Copy link

Designs for adding tooltips to the Explain Plan in the DB console can be found here (cc @maryliag): https://www.figma.com/file/MoSPFkEyJfGipCmQvvLg1a/21.1_SQL-obsrv_query-performance?node-id=2727%3A118388

@kevin-v-ngo @ianjevans I think we'll need your help defining which keywords to add tooltips for and what the messaging should be.

Note: These designs include a style and structural update to the current Logical Plan visualized in the DB console. This design aligns with the latest Explain plans in the SQL shell (this may need a separate ticket).

We should also name this tab 'Explain plan' rather than 'Logical plan' to stay consistent with the SQL shell. Let me know any thoughts.

@maryliag
Copy link
Contributor

maryliag commented Jul 7, 2021

Created the issue for matching the format at #67328

@kevin-v-ngo kevin-v-ngo changed the title sql/ui: add tooltips to explain plans in db console/sql shell sql/ui: add tooltips to explain plans in db console Sep 21, 2021
xinhaoz added a commit to xinhaoz/cockroach that referenced this issue Sep 22, 2021
Resolves: cockroachdb#61764

This commit adds tooltips to explain plan operators and node
attributes, providing more information to explain plans.

Release justification: low-risk, high benefit changes to existing
functionality

Release note (ui change): On the explain plan tab in statement
details, Users will be able to hover over underlined explain
plan attributes to get tooltips with more information on the
attribute.
xinhaoz added a commit to xinhaoz/cockroach that referenced this issue Sep 22, 2021
Resolves: cockroachdb#61764

This commit adds tooltips to explain plan operators and node
attributes, providing more information to explain plans.

Release justification: low-risk, high benefit changes to existing
functionality

Release note (ui change): On the explain plan tab in statement
details, Users will be able to hover over underlined explain
plan attributes to get tooltips with more information on the
attribute.
xinhaoz added a commit to xinhaoz/cockroach that referenced this issue Sep 22, 2021
Resolves: cockroachdb#61764

This commit adds tooltips to explain plan operators and node
attributes, providing more information to explain plans.

Release justification: low-risk, high benefit changes to existing
functionality

Release note (ui change): On the explain plan tab in statement
details, Users will be able to hover over underlined explain
plan attributes to get tooltips with more information on the
attribute.
xinhaoz added a commit to xinhaoz/cockroach that referenced this issue Sep 22, 2021
Resolves: cockroachdb#61764

This commit adds tooltips to explain plan operators and node
attributes, providing more information to explain plans.

Release justification: low-risk, high benefit changes to existing
functionality

Release note (ui change): On the explain plan tab in statement
details, Users will be able to hover over underlined explain
plan attributes to get tooltips with more information on the
attribute.
xinhaoz added a commit to xinhaoz/cockroach that referenced this issue Sep 23, 2021
Resolves: cockroachdb#61764

This commit adds tooltips to explain plan operators and node
attributes, providing more information to explain plans.

Release justification: low-risk, high benefit changes to existing
functionality

Release note (ui change): On the explain plan tab in statement
details, Users will be able to hover over underlined explain
plan attributes to get tooltips with more information on the
attribute.
craig bot pushed a commit that referenced this issue Sep 23, 2021
70441: importccl: fix test for duplicate collated string primary keys r=rhu713 a=rhu713

Previously the test for duplicate collated string primary keys had an
incorrectly formed CSV as the test data. This change fixes the test data by
adding the collation to all of the rows in the CSV.

Release note: None

70540: build: fix incorrect argument name when checking container memory limits r=AlexTalks a=AlexTalks

This change fixes a typo where when checking if a build failed due to
the Docker container memory limits being too low, the script checked for
`xmkrelease` instead of `mkrelease`.  This caused developers to
potentially fail builds (for example, with MacOS Docker resource
defaults) without realizing the reason why.

Release note: None

70568: cluster-ui: add tooltips to explain plan r=Azhng,maryliag,matthewtodd a=xinhaoz

Resolves: #61764

This commit adds tooltips to explain plan operators and node
attributes, providing more information to explain plans.

Release justification: low-risk, high benefit changes to existing
functionality

Release note (ui change): On the explain plan tab in statement
details, Users will be able to hover over underlined explain
plan attributes to get tooltips with more information on the
attribute.

-----------------------------------------------------------------------
![image](https://user-images.githubusercontent.com/20136951/134358090-02d05792-9edb-4820-b476-41ab06d84282.png)

![image](https://user-images.githubusercontent.com/20136951/134358143-a75889d4-e300-4e5f-b42f-46a686f4fd70.png)


Co-authored-by: Rui Hu <[email protected]>
Co-authored-by: Alex Sarkesian <[email protected]>
Co-authored-by: Xin Hao Zhang <[email protected]>
@craig craig bot closed this as completed in 81873a2 Sep 23, 2021
blathers-crl bot pushed a commit that referenced this issue Sep 23, 2021
Resolves: #61764

This commit adds tooltips to explain plan operators and node
attributes, providing more information to explain plans.

Release justification: low-risk, high benefit changes to existing
functionality

Release note (ui change): On the explain plan tab in statement
details, Users will be able to hover over underlined explain
plan attributes to get tooltips with more information on the
attribute.
@xinhaoz xinhaoz reopened this Sep 23, 2021
@blathers-crl
Copy link

blathers-crl bot commented Sep 23, 2021

Hi @xinhaoz, please add branch-* labels to identify which branch(es) this release-blocker affects.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) GA-blocker
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants