Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: support IntervalStyle session parameter #61167

Closed
rafiss opened this issue Feb 26, 2021 · 1 comment · Fixed by #67000
Closed

sql: support IntervalStyle session parameter #61167

rafiss opened this issue Feb 26, 2021 · 1 comment · Fixed by #67000
Assignees
@otan
Labels
A-sql-pgcompat Semantic compatibility with PostgreSQL C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-starter Might be suitable for a starter project for new employees or team members. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@rafiss
Copy link
Collaborator

rafiss commented Feb 26, 2021 •
edited by elinorgarcia
Loading

We should add support for the IntervalStyle session parameter, which describes how an interval type is formatted in output.

See official docs here: https://www.postgresql.org/docs/9.4/datatype-datetime.html#INTERVAL-STYLE-OUTPUT-TABLE
See a tutorial here: https://www.postgresqltutorial.com/postgresql-interval/

Epic CRDB-2508
@rafiss rafiss added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-sql-pgcompat Semantic compatibility with PostgreSQL E-starter Might be suitable for a starter project for new employees or team members. labels Feb 26, 2021
@rafiss rafiss mentioned this issue Feb 26, 2021
Closed
@mneverov
Copy link
Contributor

hi, i'd like to work on this

@mneverov mneverov mentioned this issue Mar 20, 2021
Closed
mneverov added a commit to mneverov/cockroach that referenced this issue Mar 23, 2021
@mneverov
sql: support iso_8601 and sql_standard interval style session settings
8476c7a 
Fixes cockroachdb#61167

Release note (sql change): support iso_8601 sql_standard interval style session
settings.
mneverov added a commit to mneverov/cockroach that referenced this issue Apr 12, 2021
@mneverov
sql: support iso_8601 and sql_standard interval style session settings
ff7a125 
Fixes cockroachdb#61167

Release note (sql change): support iso_8601 sql_standard interval style session
settings.
@rafiss rafiss added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label May 12, 2021
@otan otan mentioned this issue Jun 29, 2021
Merged
@craig craig bot closed this as completed in 5c3adfc Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@otan otan

Labels
A-sql-pgcompat Semantic compatibility with PostgreSQL C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-starter Might be suitable for a starter project for new employees or team members. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: implement IntervalStyle otan-cockroach/cockroach
3 participants
@mneverov @rafiss @otan