roachtest: tpccbench/nodes=9/cpu=4/multi-region failed #59428
Labels
branch-master
Failures and bugs on the master branch.
C-test-failure
Broken test (automatically or manually discovered).
O-roachtest
O-robot
Originated from a bot.
Comments
cockroach-teamcity
added
branch-master
|
Should no longer be a release blocker as long as the release is picking up #59431. |
irfansharif
removed
the
release-blocker
|
(roachtest).tpccbench/nodes=9/cpu=4/multi-region failed on master@4736b8dd2c36b58fffbb0a665690e2c0e719d7c3: More
Artifacts: /tpccbench/nodes=9/cpu=4/multi-region
See this test on roachdash |
|
(roachtest).tpccbench/nodes=9/cpu=4/multi-region failed on master@c584f62067a45aa540c26fc9081a83e460bfe37a: More
Artifacts: /tpccbench/nodes=9/cpu=4/multi-region
See this test on roachdash |
This was referenced Feb 9, 2021
|
(roachtest).tpccbench/nodes=9/cpu=4/multi-region failed on master@57de93a997db31d97cd7e23fb866fe0e44f90de2: More
Artifacts: /tpccbench/nodes=9/cpu=4/multi-region
See this test on roachdash |
|
(roachtest).tpccbench/nodes=9/cpu=4/multi-region failed on master@3c223f5f5162103110a790743b687ef2bf952489: More
Artifacts: /tpccbench/nodes=9/cpu=4/multi-region
See this test on roachdash |
|
(roachtest).tpccbench/nodes=9/cpu=4/multi-region failed on master@83e70ce84b740e27e721c3b73c38a4b8b515094a: More
Artifacts: /tpccbench/nodes=9/cpu=4/multi-region
See this test on roachdash |
|
(roachtest).tpccbench/nodes=9/cpu=4/multi-region failed on master@64c4aef909f4382523cd9248341ca9f4448d841a: More
Artifacts: /tpccbench/nodes=9/cpu=4/multi-region
See this test on roachdash |
|
(roachtest).tpccbench/nodes=9/cpu=4/multi-region failed on master@bf9744bad5a416a4b06907f0f3dd42896f7342f3: More
Artifacts: /tpccbench/nodes=9/cpu=4/multi-region
See this test on roachdash |
nvanbenschoten
added a commit
to nvanbenschoten/cockroach
that referenced
this issue
Feb 23, 2021
Fixes cockroachdb#60852. Fixes cockroachdb#60833. Fixes cockroachdb#58298. Fixes cockroachdb#59428. Fixes cockroachdb#60756. Fixes cockroachdb#60848. Fixes cockroachdb#60849. In cockroachdb#60852 and related issues, we saw that the introduction of a non-nullable `RaftCommand.ClosedTimestamp`, coupled with the `ClosedTimestampFooter` encoding strategy we use, led to encoded `RaftCommand` protos with their ClosedTimestamp field set twice. This is ok from a correctness perspective, at least as protobuf is concerned, but it led to a subtle interaction where the process of passing through sideloading (`maybeInlineSideloadedRaftCommand(maybeSideloadEntriesImpl(e))`) would reduce the size of an encoded RaftCommand by 3 bytes (the encoded size of an empty `hlc.Timestamp`). This was resulting in an `uncommittedSize` leak in Raft, which was eventually stalling on its `MaxUncommittedEntriesSize` limit. This commit fixes this issue by making `RaftCommand.ClosedTimestamp` nullable. With the field marked as nullable, it will no longer be encoded as an empty timestamp when unset, ensuring that when the encoded `ClosedTimestampFooter` is appended, it contains the only instance of the `ClosedTimestamp` field.
|
(roachtest).tpccbench/nodes=9/cpu=4/multi-region failed on master@5cfd7e5553a3072a1490d392390dddf968844215: More
Artifacts: /tpccbench/nodes=9/cpu=4/multi-region
See this test on roachdash |
craig bot
pushed a commit
that referenced
this issue
Feb 23, 2021
60836: opt: support UPDATE with partial UNIQUE WITHOUT INDEX constraints r=mgartner a=mgartner This commit add uniqueness checks for partial `UNIQUE WITHOUT INDEX` constraints during `UPDATE` statements. As partial of this change, I discovered that #60535 introduced a regression where columns not required by uniqueness checks are not pruned. I've left TODOs in the column pruning tests and plan on fixing this in a follow-up PR. There is no release note because these constraints are gated behind the experimental_enable_unique_without_index_constraints session variable. Release note: None 60992: kv: make RaftCommand.ClosedTimestamp nullable r=nvanbenschoten a=nvanbenschoten Fixes #60852. Fixes #60833. Fixes #58298. Fixes #59428. Fixes #60756. Fixes #60848. Fixes #60849. In #60852 and related issues, we saw that the introduction of a non-nullable `RaftCommand.ClosedTimestamp`, coupled with the `ClosedTimestampFooter` encoding strategy we use, led to encoded `RaftCommand` protos with their ClosedTimestamp field set twice. This is ok from a correctness perspective, at least as protobuf is concerned, but it led to a subtle interaction where the process of passing through sideloading (`maybeInlineSideloadedRaftCommand(maybeSideloadEntriesImpl(e))`) would reduce the size of an encoded RaftCommand by 3 bytes (the encoded size of an empty `hlc.Timestamp`). This was resulting in an `uncommittedSize` leak in Raft, which was eventually stalling on its `MaxUncommittedEntriesSize` limit. This commit fixes this issue by making `RaftCommand.ClosedTimestamp` nullable. With the field marked as nullable, it will no longer be encoded as an empty timestamp when unset, ensuring that when the encoded `ClosedTimestampFooter` is appended, it contains the only instance of the `ClosedTimestamp` field. cc. @cockroachdb/bulk-io Co-authored-by: Marcus Gartner <[email protected]> Co-authored-by: Nathan VanBenschoten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
(roachtest).tpccbench/nodes=9/cpu=4/multi-region failed on master@d86781c07065421f4a4d8bf5d988900ab07fdce5:
More
Artifacts: /tpccbench/nodes=9/cpu=4/multi-region
Related:
See this test on roachdash
powered by pkg/cmd/internal/issues
The text was updated successfully, but these errors were encountered: