Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util/stop: TestStopperCloserConcurrent failed #59368

Closed
cockroach-teamcity opened this issue Jan 25, 2021 · 2 comments · Fixed by #59381
Closed

util/stop: TestStopperCloserConcurrent failed #59368

cockroach-teamcity opened this issue Jan 25, 2021 · 2 comments · Fixed by #59381
Assignees
@tbg
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.

Comments

@cockroach-teamcity
Copy link
Member

(util/stop).TestStopperCloserConcurrent failed on master@48fbbe7313fc70f889fa66c5749914f57ddd5a91:

=== RUN   TestStopperCloserConcurrent
I210125 08:44:42.607473 13 util/stop/stopper.go:561  quiescing
I210125 08:44:42.607557 15 util/stop/stopper.go:561  quiescing
I210125 08:44:42.607611 98 util/stop/stopper.go:561  quiescing
I210125 08:44:42.607654 100 util/stop/stopper.go:561  quiescing
    stopper_test.go:264: expected true; got false
I210125 08:44:42.607736 40 util/stop/stopper.go:561  quiescing
I210125 08:44:42.607839 42 util/stop/stopper.go:561  quiescing
I210125 08:44:42.607873 44 util/stop/stopper.go:561  quiescing
I210125 08:44:42.607909 46 util/stop/stopper.go:561  quiescing
I210125 08:44:42.607944 48 util/stop/stopper.go:561  quiescing
I210125 08:44:42.607989 114 util/stop/stopper.go:561  quiescing
--- FAIL: TestStopperCloserConcurrent (0.00s)
More

Parameters:

  • TAGS=
  • GOFLAGS=-parallel=4
make stressrace TESTS=TestStopperCloserConcurrent PKG=./pkg/util/stop TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1

See this test on roachdash
powered by pkg/cmd/internal/issues
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Jan 25, 2021
@nvanbenschoten
Copy link
Member

@tbg the timing of this indicates that it is likely fallout from #59041.

@nvanbenschoten nvanbenschoten assigned tbg and unassigned nvanbenschoten Jan 25, 2021
@tbg tbg mentioned this issue Jan 25, 2021
Merged
@cockroach-teamcity
Copy link
Member Author

(util/stop).TestStopperCloserConcurrent failed on master@b51d9f1271a6a8277a24003ca32623fbdfcd591a:

=== RUN   TestStopperCloserConcurrent
I210125 17:27:38.599387 52 util/stop/stopper.go:561  quiescing
I210125 17:27:38.599823 54 util/stop/stopper.go:561  quiescing
I210125 17:27:38.600372 56 util/stop/stopper.go:561  quiescing
I210125 17:27:38.600764 58 util/stop/stopper.go:561  quiescing
I210125 17:27:38.601097 60 util/stop/stopper.go:561  quiescing
I210125 17:27:38.601465 62 util/stop/stopper.go:561  quiescing
I210125 17:27:38.602126 15 util/stop/stopper.go:561  quiescing
I210125 17:27:38.602727 82 util/stop/stopper.go:561  quiescing
    stopper_test.go:264: expected true; got false
I210125 17:27:38.603305 84 util/stop/stopper.go:561  quiescing
I210125 17:27:38.603928 86 util/stop/stopper.go:561  quiescing
--- FAIL: TestStopperCloserConcurrent (0.01s)
More

Parameters:

  • GOFLAGS=-json
make stressrace TESTS=TestStopperCloserConcurrent PKG=./pkg/util/stop TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1

See this test on roachdash
powered by pkg/cmd/internal/issues

craig bot pushed a commit that referenced this issue Jan 25, 2021
@tbg @rickystewart
Merge #59381 #59385
1aa232c 
59381: stop: ensure Closer called exactly once r=nvanbenschoten a=tbg

Due to a bug introduced in #59041, `AddCloser` could add a closer that
would never be called in the event that the closer was concurrently
Stop'ping. This commit fixes it.

Fixes #59368.

Release note: None


59385: build,bazel: delete stale references breaking bazel build r=rickystewart a=rickystewart

These dependencies marked `keep` aren't actually necessary any more and
now introduce cyclic dependency errors, so remove them.

Release note: None

Co-authored-by: Tobias Grieger <[email protected]>
Co-authored-by: Ricky Stewart <[email protected]>
@craig craig bot closed this as completed in 1a27b4b Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tbg tbg

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

stop: ensure Closer called exactly once tbg/cockroach
3 participants
@tbg @nvanbenschoten @cockroach-teamcity