Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdc: pass an (arbitrary) kafka topic name in the destination path string #59300

Closed
florence-crl opened this issue Jan 22, 2021 · 0 comments · Fixed by #62377
Closed

cdc: pass an (arbitrary) kafka topic name in the destination path string #59300

florence-crl opened this issue Jan 22, 2021 · 0 comments · Fixed by #62377
Assignees
Labels
A-cdc Change Data Capture C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@florence-crl
Copy link

florence-crl commented Jan 22, 2021

Is your feature request related to a problem? Please describe.
A customer has the following use case:

All of their table names have underscores in their names (Ex: sample_table) but when they try to create a k8s KafkaTopic with the same name, they get an error because k8s uses hyphens ('-') instead of underscores ('_') for names.
k8s_error

The problem is they can not create tables with hyphens in their name because of database naming standards and they cannot create k8s KafkaTopic's with underscore because of k8s naming standards. How do they map the topics to tables for changefeed in this scenario?

Describe the solution you'd like
A possible solution would be to pass an (arbitrary) kafka topic name in the destination path string

Describe alternatives you've considered
An alternative they tried was adding spec.topicName: strimzi/strimzi-kafka-operator#2931.
In the crdb_kafka.yaml, they tried modifying name and adding topicName:

metadata:
  name: cdc-demo
...
spec:
  topicName: cdc_demo

topicName

Additional context
A related issue is: #58302

@florence-crl florence-crl added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-cdc Change Data Capture labels Jan 22, 2021
@HonoreDB HonoreDB self-assigned this Mar 22, 2021
@craig craig bot closed this as completed in 822187c Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cdc Change Data Capture C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants