Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple changefeed jobs to emit to the same topic #58302

Closed
kevinkokomani opened this issue Dec 28, 2020 · 6 comments · Fixed by #62377
Closed

Allow multiple changefeed jobs to emit to the same topic #58302

kevinkokomani opened this issue Dec 28, 2020 · 6 comments · Fixed by #62377
Assignees
Labels
A-cdc Change Data Capture A-disaster-recovery C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-cdc

Comments

@kevinkokomani
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently, when you create a changefeed job for a table, the job will publish to a topic named after the table. If a database has N tables, you will need to create N Kafka topics, which can be an annoyance.

Describe the solution you'd like
Ideally, you would be able to tell multiple change feed jobs to emit to the same topic, so you can have one topic per database (and every change feed will emit to that database topic).

Describe alternatives you've considered
There don't appear to be any alternatives to the current flow.

@blathers-crl
Copy link

blathers-crl bot commented Dec 28, 2020

Hi @kevinkokomani, I've guessed the C-ategory of your issue and suitably labeled it. Please re-label if inaccurate.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl blathers-crl bot added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Dec 28, 2020
@RoachietheSupportRoach
Copy link
Collaborator

Zendesk ticket #7116 has been linked to this issue.

@mwang1026 mwang1026 removed their assignment Dec 28, 2020
@mwang1026 mwang1026 added T-cdc A-cdc Change Data Capture labels Dec 28, 2020
@mwang1026
Copy link

I think we should be careful about implementing it as described. Do they have thoughts on how they might disambiguate data between tables? Does it need to be separate changefeeds to the same topic vs just one changefeed that writes to a single topic?

Long way of saying, we've had a number of requests lately about output formats (which is great!) but we should be mindful of thinking about the UX as a whole. Having some clarification about the above (as well as why it's less of an operational than having to parse different table data out from a single topic) would be helpful for prioritization and UX design.

@eliancss
Copy link

eliancss commented Jan 5, 2021

Hi, initially we don't have a specific preference on number of changefeeds, what is more important is reducing the number of topics, 1 per DB (or make it configurable) would be ideal.

Thank you!

@amruss
Copy link
Contributor

amruss commented Jan 5, 2021

Hi @eliancss could you give us more context into what output you're looking for here?

Could this be solved by creating one changefeed job for all of the tables in your DB?

@eliancss
Copy link

eliancss commented Jan 5, 2021

Yes! @amruss as long as that job outputs to a single (the same) kafka topic. Currently we require 1 job per table (and that job needs a new topic too).

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cdc Change Data Capture A-disaster-recovery C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-cdc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants