Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/bazel: build is broken at HEAD #59052

Closed
rickystewart opened this issue Jan 15, 2021 · 0 comments · Fixed by #59056
Closed

build/bazel: build is broken at HEAD #59052

rickystewart opened this issue Jan 15, 2021 · 0 comments · Fixed by #59056
Assignees
Labels
A-build-system C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@rickystewart
Copy link
Collaborator

Broken by 92b52f8fc1dcef5bd1f03836d16ed5d3015990d9, which introduced a new generated file without making the corresponding change in Bazel.

@rickystewart rickystewart added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-build-system labels Jan 15, 2021
irfansharif pushed a commit to alan-mas/cockroach that referenced this issue Jan 15, 2021
We broke the bazel build in 52c5f51 when we introduced a new .eg.go
file, without updating the bazel target. We do that here.

Fixes: cockroachdb#59052.

Release note: None
craig bot pushed a commit that referenced this issue Jan 15, 2021
59008: kvnemesis: add lease transfers r=nvanbenschoten a=nvanbenschoten

This commit adds lease transfers to KV nemesis. This will be useful in validating that I don't mess anything up when addressing #57688 or when performing the precursor refactor to pull lease checks below latching.

I stressed this for 50,000 iterations on a 20 node roachprod cluster without failure, so it looks like lease transfers aren't already broken!

59056: bazel,colexec: generate crossjoiner.eg.go within bazel  r=rickystewart a=alan-mas

We broke the bazel build in 52c5f51 when we introduced a new .eg.go
file, without updating the bazel target. We do that here.

Fixes #59052

59070: cmd/roachtest: add workload F to pebble roachtest r=petermattis a=jbowens

Run workload F (100% inserts) in the nightly Pebble benchmarks. A
performance regression in the 100%-insert workload went unnoticed.
Adding it to the nightly benchmarks will help detect future regressions.

Release note: none

Co-authored-by: Nathan VanBenschoten <[email protected]>
Co-authored-by: Alanmas <[email protected]>
Co-authored-by: Jackson Owens <[email protected]>
@craig craig bot closed this as completed in 651a537 Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-build-system C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants