sql: Modify all REGIONAL BY ROW tables on ALTER DATABASE ADD/DROP REGION #58340
Assignees
Labels
A-multiregion
Related to multi-region
C-enhancement
Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Comments
ajstorm
added
C-enhancement
arulajmani
added a commit
to arulajmani/cockroach
that referenced
this issue
Feb 22, 2021
Closes cockroachdb#58340 Release note (sql change): `ALTER DATABASE ... DROP REGION ...` repartitions regional by row tables to remove the partition for the removed region and removes the zone congfiguration for the partition as well.
craig bot
pushed a commit
that referenced
this issue
Feb 22, 2021
58627: kvserver: support atomic promotions and demotions of non-voting replicas r=aayushshah15 a=aayushshah15 This PR teaches `AdminChangeReplicas` to atomically promote voters to non-voters, demote voters to non-voters or swap voters with non-voters via joint consensus. The approach followed by this PR tries to coalesce `ReplicationChanges` of types `ADD_VOTER` and `REMOVE_NON_VOTER` on a given target as promotions of non-voters into voters and likewise, `ADD_NON_VOTER` and `REMOVE_VOTER` changes for a given target as demotions of voters into non-voters. When all 4 of these operations are simultaneously passed into a `ChangeReplicasRequest`, the patch will try to execute them as one atomic swap of a voter with a non-voter. Fixes #58499 Informs #51943 Release note: None 60799: sql: include virtual table names in crash reports r=knz a=rafiss This uses the functionality that we already had in place for telemetry data. This might potentially make some crash reports more useful without compromising privacy. Release note (general change): Crash reports that are sent to Cockroach Labs now no longer redact the names of builtin virtual tables from the crdb_internal, information_schema, and pg_catalog schemas. 60938: sql: drop partitions and zone configs from RBR tables on region drop r=otan a=arulajmani Closes #58340 Release note (sql change): `ALTER DATABASE ... DROP REGION ...` repartitions regional by row tables to remove the partition for the removed region and removes the zone congfiguration for the partition as well. 60939: bazel: correct BUILD file generation order r=irfansharif a=irfansharif pkg/BUILD.bazel has the (auto-generated) directive that instructs bazel to strip out the /pkg prefix. If we start off without pkg/BUILD.bazel[1], the earlier gazelle invocations don't learn about the prefix strip. [1]: Maybe we shouldn't be able to, I was testing to see if there were no extraneous diffs by re-generating the file entirely. Release note: None Co-authored-by: Aayush Shah <[email protected]> Co-authored-by: Rafi Shamim <[email protected]> Co-authored-by: arulajmani <[email protected]> Co-authored-by: irfan sharif <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When regions are added or dropped from a database, REGIONAL BY ROW tables must be modified to add/drop the corresponding partitions.
The text was updated successfully, but these errors were encountered: