-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roachtest: acceptance/version-upgrade failed: invalid attempted write of database descriptor #58307
Comments
Yikes, the version switch happens mid-statement and we hit the panic. |
Ah yeah so we're not doing the gate check for user defined schemas properly. I think the window for this crash is very small but it's still worthy of a fix. |
(roachtest).acceptance/version-upgrade failed on release-20.2@91e4d8ab9d996a2c168c81371b3862115219a3fe:
More
Artifacts: /acceptance/version-upgrade
See this test on roachdash |
Hit an instance of this in the wild #59752. |
(roachtest).acceptance/version-upgrade failed on release-20.2@8c79e2bc4b35d36c8527f4c40c974f03d9034f46:
More
Artifacts: /acceptance/version-upgrade
See this test on roachdash |
(roachtest).acceptance/version-upgrade failed on release-20.2@b0012907c1bc9627ae2de83e6099c4930a32699e:
More
Artifacts: /acceptance/version-upgrade
See this test on roachdash |
(roachtest).acceptance/version-upgrade failed on release-20.2@e0d26e817d5bdaa280a4692a3346f3eef0d4cce7:
More
Artifacts: /acceptance/version-upgrade
See this test on roachdash |
Happened again at the tip of release-20.2: @postamar did you look into this at all? |
No I haven't, it was in our backlog. That being said if it's a low-hanging fruit I'll take a look ASAP. |
This is low-hanging fruit for the 20.1->20.2 upgrade. We've got a problem with how we check the gate on User Defined Schemas. That being said, it's a transient error that is not super common to come up so we deprioritized it. |
(roachtest).acceptance/version-upgrade failed on release-20.2@e3bc5c226cae9970108803c743119619f3125f3e:
More
Artifacts: /acceptance/version-upgrade
See this test on roachdash |
(roachtest).acceptance/version-upgrade failed on release-20.2@3ebdf340cb2e9f995a4e969d75dcc53fcc8daefa:
More
Artifacts: /acceptance/version-upgrade
See this test on roachdash |
The cluster version which enables user-defined schemas comes after the activation of the version which enables leasing database descriptors. However the usability of leased database descriptors is checked at the beginning of the transaction to ensure that the use remains stable throughout the life of the transaction. The use of leased database descriptors is a requirement to create user-defined schemas. This difference in when the two conditions are checked leads to a window for a crash whereby we attempt to create a new-style database due to a `CREATE SCHEMA` statement in a transaction which does not have those databases enabled. We fix this by checking both conditions in the `CREATE SCHEMA` execution. Fixes cockroachdb#58307. Release note (bug fix): Fixed a rare bug which can cause a crash if CREATE SCHEMA is run in a transaction which began prior to a cluster version update which enables that statement.
(roachtest).acceptance/version-upgrade failed on release-20.2@dfe5778eddb408f0ceb8152538be7c34401866e2:
More
Artifacts: /acceptance/version-upgrade
See this test on roachdash |
While bumping Pebble in the release-20.2 branch, my PR #58304 hit this roachtest failure that appears to be unrelated to the change:
https://teamcity.cockroachdb.com/viewLog.html?buildId=2547260&buildTypeId=Cockroach_UnitTests_Roachtest&tab=buildResultsDiv
The text was updated successfully, but these errors were encountered: