Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: Update more roachtests to use encryption-at-rest on some random runs #57997

Closed
itsbilal opened this issue Dec 16, 2020 · 1 comment · Fixed by #58622
Closed

roachtest: Update more roachtests to use encryption-at-rest on some random runs #57997

itsbilal opened this issue Dec 16, 2020 · 1 comment · Fixed by #58622
Assignees
Labels

Comments

@itsbilal
Copy link
Member

Currently, the only roachtests that run with encryption-at-rest enabled are:

  1. All the kv{0,95}/enc=true/* tests
  2. Half of all clearrange/checks={false,true} runs (since roachtest: Use encryption-at-rest in some random clearrange runs #57086).
  3. All of engine/switch/encrypted/nodes=*
  4. All of encryption/nodes=1

To aid in detecting any issues concerning interactions with encryption-at-rest, we should be running a wider variety of roachtests with encryption-at-rest enabled. This could be implemented using a random boolean at cluster start time, similar to how it's done for clearrange, as that would avoid doubling the number of roachtests we run.

@blathers-crl
Copy link

blathers-crl bot commented Dec 16, 2020

Hi @itsbilal, please add a C-ategory label to your issue. Check out the label system docs.

While you're here, please consider adding an A- label to help keep our repository tidy.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@itsbilal itsbilal added the O-qa label Dec 16, 2020
@itsbilal itsbilal self-assigned this Jan 6, 2021
itsbilal added a commit to itsbilal/cockroach that referenced this issue Jan 7, 2021
…tests

Currently, encryption-at-rest is only used in roachtests that either have
`enc=true`, `encryption` or `encrypted` in their name. In addition, the other
roachtest to use encryption-at-rest is `clearrange/*`, and only on some random
runs.

This change updates many more roachtests to use encryption-at-rest on about
half of all runs (chosen by a random var):
 * backup/2TB/*
 * acceptance/many-splits
 * import/tpc{c,h}/*
 * tpcc/*, tpcc-nowait/*, schemachange/*tpcc*, scrub/*tpcc* (NOT tpccbench/*)
 * restore2TB/*

Fixes cockroachdb#57997.

Release note: None
itsbilal added a commit to itsbilal/cockroach that referenced this issue Jan 13, 2021
…tests

Currently, encryption-at-rest is only used in roachtests that either have
`enc=true`, `encryption` or `encrypted` in their name. In addition, the other
roachtest to use encryption-at-rest is `clearrange/*`, and only on some random
runs.

This change updates many more roachtests to use encryption-at-rest on about
half of all runs (chosen by a random var):
 * backup/2TB/*
 * acceptance/many-splits
 * import/tpc{c,h}/*
 * tpcc/*, tpcc-nowait/*, schemachange/*tpcc*, scrub/*tpcc* (NOT tpccbench/*)
 * restore2TB/*

Fixes cockroachdb#57997.

Release note: None
craig bot pushed a commit that referenced this issue Jan 14, 2021
58622: roachtest: Enable encryption-at-rest in many storage-heavy non-bench tests r=sumeerbhola a=itsbilal


Currently, encryption-at-rest is only used in roachtests that either have
`enc=true`, `encryption` or `encrypted` in their name. In addition, the other
roachtest to use encryption-at-rest is `clearrange/*`, and only on some random
runs.

This change updates many more roachtests to use encryption-at-rest on about
half of all runs (chosen by a random var):
 * `backup/2TB/*`
 * `acceptance/many-splits`
 * `import/tpc{c,h}/*`
 * `tpcc/*, tpcc-nowait/*, schemachange/*tpcc*, scrub/*tpcc*` (NOT tpccbench/*)
 * `restore2TB/*`

Fixes #57997.

Release note: None

Co-authored-by: Bilal Akhtar <[email protected]>
@craig craig bot closed this as completed in bf19a5d Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant