Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: psycopg failed #57986

Closed
cockroach-teamcity opened this issue Dec 16, 2020 · 4 comments · Fixed by #58036
Closed

roachtest: psycopg failed #57986

cockroach-teamcity opened this issue Dec 16, 2020 · 4 comments · Fixed by #58036
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.

Comments

@cockroach-teamcity
Copy link
Member

(roachtest).psycopg failed on master@de91557c0634ab3797356d445ba39e37d45d8205:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/psycopg/run_1
	orm_helpers.go:228,orm_helpers.go:154,psycopg.go:122,psycopg.go:135,test_runner.go:760: 
		Tests run on Cockroach v21.1.0-alpha.1-400-gde91557c06
		Tests run against psycopg 2_8_6
		452 Total Tests Run
		450 tests passed
		2 tests failed
		320 tests skipped
		3 tests ignored
		0 tests passed unexpectedly
		1 test failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- FAIL: tests.test_module.ExceptionsTestCase.test_9_6_diagnostics (unexpected)
		For a full summary look at the psycopg artifacts 
		
		An updated blocklist (psycopgBlockList21_1) is available in the artifacts' psycopg log

More

Artifacts: /psycopg

See this test on roachdash
powered by pkg/cmd/internal/issues

@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Dec 16, 2020
@arulajmani
Copy link
Collaborator

This test wasn't run earlier because our previous pg version was 9.5 was less than the version above which this test is run (9.6). After the version bump, this test needs to be explicitly skipped for CRDB, for the same reason as test_9_3_diagnostics, which is skipped for CRDB. Therefore, this failure is expected after the version bump.

I've opened up a PR here: psycopg/psycopg2#1211 to change this upstream. @rafiss, since you're the one most familiar w this stuff, is there anything else I need to do here or are we in the green?

@rafiss
Copy link
Collaborator

rafiss commented Dec 17, 2020

Thanks @arulajmani ! the last step here will be to change the version of psycopg2 that we test with in roachtest/psycopg,go

Though we would probably need to wait for the next release of psycopg2. In the meantime, we can just mark this test as failing in psycopg_blocklist.go

@cockroach-teamcity
Copy link
Member Author

(roachtest).psycopg failed on master@eda9189cecbbc279f1857f6e6b992bdfd363397e:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/psycopg/run_1
	orm_helpers.go:228,orm_helpers.go:154,psycopg.go:122,psycopg.go:135,test_runner.go:760: 
		Tests run on Cockroach v21.1.0-alpha.1-429-geda9189cec
		Tests run against psycopg 2_8_6
		452 Total Tests Run
		450 tests passed
		2 tests failed
		320 tests skipped
		3 tests ignored
		0 tests passed unexpectedly
		1 test failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- FAIL: tests.test_module.ExceptionsTestCase.test_9_6_diagnostics (unexpected)
		For a full summary look at the psycopg artifacts 
		
		An updated blocklist (psycopgBlockList21_1) is available in the artifacts' psycopg log

More

Artifacts: /psycopg

See this test on roachdash
powered by pkg/cmd/internal/issues

@cockroach-teamcity
Copy link
Member Author

(roachtest).psycopg failed on master@46919380225dba7122130c338744b561d7eb6c56:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/psycopg/run_1
	orm_helpers.go:228,orm_helpers.go:154,psycopg.go:122,psycopg.go:135,test_runner.go:760: 
		Tests run on Cockroach v21.1.0-alpha.1-455-g4691938022
		Tests run against psycopg 2_8_6
		452 Total Tests Run
		450 tests passed
		2 tests failed
		320 tests skipped
		3 tests ignored
		0 tests passed unexpectedly
		1 test failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- FAIL: tests.test_module.ExceptionsTestCase.test_9_6_diagnostics (unexpected)
		For a full summary look at the psycopg artifacts 
		
		An updated blocklist (psycopgBlockList21_1) is available in the artifacts' psycopg log

More

Artifacts: /psycopg

See this test on roachdash
powered by pkg/cmd/internal/issues

craig bot pushed a commit that referenced this issue Dec 18, 2020
57650: migration: introduce various other bells and whistles... r=irfansharif a=irfansharif

...to pave the way for real migrations

This PR cannibalizes most of our prototype in #57445 and shimmies in a few
interfaces to make it all unit-testable. While here, we:
- parallelize the execution of the EveryNode primitive
- introduce the IterateRangeDescriptors primitive
- re-write the migration registration process for better ergonomics
- introduce a more structured Migration type, to annotate it with migration
  specific metadata (it also paves the way for logging the progress of an
  ongoing migration to a system table).

See individual commits for details. 


58036: roachtest: add test_9_6_diagnostics to psycopg blocklist r=rafiss a=arulajmani

Previously, this test was skipped as our pg server version (9.5) did
not meet the threshold (9.6) for this test to run. After the pg server
version bump to 13 this is no longer the case. A change to explicitly
skip this test for CRDB has been merged upstream, but it won't apply
until the next release (psycopg_2_8_7) comes out and we switch to
testing against that. Until then, this test lives in the blocklist.

Closes #57986

Release note: None

Co-authored-by: irfan sharif <[email protected]>
Co-authored-by: arulajmani <[email protected]>
@craig craig bot closed this as completed in b0a6d3e Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants