-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roachtest: psycopg failed #57986
Comments
This test wasn't run earlier because our previous pg version was 9.5 was less than the version above which this test is run (9.6). After the version bump, this test needs to be explicitly skipped for CRDB, for the same reason as test_9_3_diagnostics, which is skipped for CRDB. Therefore, this failure is expected after the version bump. I've opened up a PR here: psycopg/psycopg2#1211 to change this upstream. @rafiss, since you're the one most familiar w this stuff, is there anything else I need to do here or are we in the green? |
Thanks @arulajmani ! the last step here will be to change the version of psycopg2 that we test with in roachtest/psycopg,go Though we would probably need to wait for the next release of psycopg2. In the meantime, we can just mark this test as failing in psycopg_blocklist.go |
(roachtest).psycopg failed on master@eda9189cecbbc279f1857f6e6b992bdfd363397e:
|
(roachtest).psycopg failed on master@46919380225dba7122130c338744b561d7eb6c56:
|
57650: migration: introduce various other bells and whistles... r=irfansharif a=irfansharif ...to pave the way for real migrations This PR cannibalizes most of our prototype in #57445 and shimmies in a few interfaces to make it all unit-testable. While here, we: - parallelize the execution of the EveryNode primitive - introduce the IterateRangeDescriptors primitive - re-write the migration registration process for better ergonomics - introduce a more structured Migration type, to annotate it with migration specific metadata (it also paves the way for logging the progress of an ongoing migration to a system table). See individual commits for details. 58036: roachtest: add test_9_6_diagnostics to psycopg blocklist r=rafiss a=arulajmani Previously, this test was skipped as our pg server version (9.5) did not meet the threshold (9.6) for this test to run. After the pg server version bump to 13 this is no longer the case. A change to explicitly skip this test for CRDB has been merged upstream, but it won't apply until the next release (psycopg_2_8_7) comes out and we switch to testing against that. Until then, this test lives in the blocklist. Closes #57986 Release note: None Co-authored-by: irfan sharif <[email protected]> Co-authored-by: arulajmani <[email protected]>
(roachtest).psycopg failed on master@de91557c0634ab3797356d445ba39e37d45d8205:
More
Artifacts: /psycopg
See this test on roachdash
powered by pkg/cmd/internal/issues
The text was updated successfully, but these errors were encountered: