Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: logged events for changes to table/view/seq ownership do not qualify the object name #57960

Closed
knz opened this issue Dec 15, 2020 · 1 comment · Fixed by #58504
Closed

sql: logged events for changes to table/view/seq ownership do not qualify the object name #57960

knz opened this issue Dec 15, 2020 · 1 comment · Fixed by #58504
Labels
A-logging In and around the logging infrastructure. A-schema-changes C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@knz
Copy link
Contributor

knz commented Dec 15, 2020

See:

 alter_table_owner         |       52 |           1 | {"EventType":"alter_table_owner","Statement":"ALTER TABLE defaultdb.public.foo OWNER TO foo","User":"demo","InstanceID":1,"DescriptorID":52,"TableName":"foo","Owner":"foo"}

The TableName is just foo, should be defaultdb.public.foo.

cc @thtruo for tracking.
@knz knz added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-schema-changes labels Dec 15, 2020
@jordanlewis jordanlewis added the A-logging In and around the logging infrastructure. label Dec 22, 2020
@knz
Copy link
Contributor Author

knz commented Dec 22, 2020

Discussed with @aaron-crl : lower priority

@the-ericwang35 the-ericwang35 mentioned this issue Jan 6, 2021
Merged
craig bot pushed a commit that referenced this issue Jan 12, 2021
@yuzefovich @the-ericwang35
Merge #58013 #58504 #58743
158601d 
58013: colexec: fix spilling queue r=yuzefovich a=yuzefovich

This commit refactors `enqueue` method of the spilling queue to
deep-copy the passed-in batches if they are kept in memory. Previous
behavior was suboptimal because it was forcing the caller to always
allocate a new batch. Additionally, the spilling queue will now perform
a coalescing step by attempting to append as many tuples to the tail
in-memory batch as possible. The in-memory batches are allocated with
dynamically increasing capacity.

This allows us to significantly simplify the code of the router outputs
which were performing the coalescing step previously.

Additionally, this commit fixes a couple of uses of `enqueue` method
(the router outputs and the merge joiner) in which they forgot to
enqueue a zero-length batch which is necessary when the disk queue is
initialized.

Fixes: #47062.

Release note: None

58504: sql: qualify table name for alter_table_owner event log r=ajwerner a=the-ericwang35

Fixes #57960.

Previously, event logs were not capturing the qualified table names
for ALTER TABLE OWNER commands.
This PR changes the event logs to use the qualified table name.
Tests were fixed to reflect these changes.

Release note (bug fix): qualify table name for alter_table_owner event log

58743: colexec: fix decimal/interval overload error propagation r=yuzefovich a=yuzefovich

Fixes: #57773.

Release note (bug fix): CockroachDB could previously return an internal
error when evaluating a binary expression between a Decimal and an
Interval that required a cast to a Float when the value is out of range,
and now a more user-friendly error is returned instead.

Co-authored-by: Yahor Yuzefovich <[email protected]>
Co-authored-by: Eric Wang <[email protected]>
@craig craig bot closed this as completed in 81e0172 Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-logging In and around the logging infrastructure. A-schema-changes C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: qualify table name for alter_table_owner event log
2 participants
@jordanlewis @knz