pgwire: clean up old cluster versions passed to RegisterAuthMethod #56398
Assignees
Labels
C-cleanup
Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.
Comments
thoszhang
added
the
C-cleanup
irfansharif
added a commit
to irfansharif/cockroach
that referenced
this issue
Nov 26, 2020
It's an old cluster version, introduced in the 19.2 release cycle. It's now safe to remove. Part of cockroachdb#47447. Fixes cockroachdb#56398. Release note: None
irfansharif
added a commit
to irfansharif/cockroach
that referenced
this issue
Nov 27, 2020
It's an old cluster version, introduced in the 19.2 release cycle. It's now safe to remove. Part of cockroachdb#47447. Fixes cockroachdb#56398. Release note: None
craig bot
pushed a commit
that referenced
this issue
Nov 27, 2020
57118: migration,server: plumb in initial version to the migration manager r=irfansharif a=irfansharif It'll let us return early, and makes the manager "more functional" in its behavior. We also promote the clusterversion type to a first-class citizen in the external facing API for pkg/migration. This package concerns itself with migrations between cluster versions and we should have our API reflect as much. The proto changes are safe, we haven't had a major release with the previous proto definitions. Release note: None 57155: clusterversion,*: remove VersionContainsEstimatesCounter r=irfansharif a=irfansharif This, and all surrounding migration code and tests, are now safe to remove. It mostly served as documentation, which we've moved to the field itself. Part of #47447. Fixes #56401. (While here, Let's also tell git that `versionkey_string.go` is a generated file.) Release note: None --- First commit is from #57154. 57156: sql,clusterversion: remove VersionAuthLocalAndTrustRejectMethods r=irfansharif a=irfansharif It's an old cluster version, introduced in the 19.2 release cycle. It's now safe to remove. Part of #47447. Fixes #56398. Release note: None --- See only last commit. First two are from #57154 and #57155 respectively. Co-authored-by: irfan sharif <[email protected]>
craig bot
pushed a commit
that referenced
this issue
Nov 28, 2020
57155: clusterversion,*: remove VersionContainsEstimatesCounter r=irfansharif a=irfansharif This, and all surrounding migration code and tests, are now safe to remove. It mostly served as documentation, which we've moved to the field itself. Part of #47447. Fixes #56401. (While here, Let's also tell git that `versionkey_string.go` is a generated file.) Release note: None --- First commit is from #57154. 57156: sql,clusterversion: remove VersionAuthLocalAndTrustRejectMethods r=irfansharif a=irfansharif It's an old cluster version, introduced in the 19.2 release cycle. It's now safe to remove. Part of #47447. Fixes #56398. Release note: None --- See only last commit. First two are from #57154 and #57155 respectively. Co-authored-by: irfan sharif <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently,
pgwire.RegisterAuthMethodtakes aclusterversion.VersionKeyindicating the minimum cluster version for the method, which makes it tricky to get rid of old cluster versions. Currently it's called withVersion19_1andVersionAuthLocalAndTrustRejectMethods.Part of #47447.
The text was updated successfully, but these errors were encountered: