Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: scbench/randomload/nodes=3/ops=10000/conc=20 failed #56230

Closed
cockroach-teamcity opened this issue Nov 3, 2020 · 382 comments · Fixed by #105919
Closed

roachtest: scbench/randomload/nodes=3/ops=10000/conc=20 failed #56230

cockroach-teamcity opened this issue Nov 3, 2020 · 382 comments · Fixed by #105919
Assignees
@rimadeodhar
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. skipped-test T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Nov 3, 2020 •
edited by cockroach-jira-scripts
Loading

(jayshrivastava) resolved by #56379, but there still some different errors left to solve in the comments

(roachtest).scbench/randomload/nodes=3/ops=10000/conc=20 failed on master@e25ee7ad4bcdeda49f40eb52c24d2d1b1aa67a86:

		  | I201103 08:13:21.524996 1 workload/cli/run.go:356  creating load generator...
		  | I201103 08:13:21.597243 1 workload/cli/run.go:387  creating load generator... done (took 72.246217ms)
		  | Error: ***UNEXPECTED ERROR: ERROR: restart transaction: TransactionRetryWithProtoRefreshError: TransactionRetryError: retry txn (RETRY_WRITE_TOO_OLD - WriteTooOld flag converted to WriteTooOldError): "sql txn" meta={id=24fa1aae key=/Table/SystemConfigSpan/Start pri=0.05040495 epo=0 ts=1604391209.856504541,1 min=1604391209.226930126,0 seq=6} lock=true stat=PENDING rts=1604391209.226930126,0 wto=false max=1604391209.226930126,0 (SQLSTATE 40001)
		  | Error: COMMAND_PROBLEM: exit status 1
		  | (1) COMMAND_PROBLEM
		  | Wraps: (2) Node 1. Command with error:
		  |   | ```
		  |   | ./workload run schemachange --verbose=1 --tolerate-errors=false  --histograms=perf/stats.json --max-ops 10000 --concurrency 20
		  |   | ```
		  | Wraps: (3) exit status 1
		  | Error types: (1) errors.Cmd (2) *hintdetail.withDetail (3) *exec.ExitError
		  |
		  | stdout:
		  | <... some data truncated by circular buffer; go to artifacts for details ...>
		  | opOk
		  |     8.0s        0            3.0            6.5    771.8    872.4    872.4    872.4 txnCmtErr
		  |     8.0s        0            1.0            3.1     16.3     16.3     16.3     16.3 txnOk
		  |     8.0s        0           25.0           20.1      2.4    268.4    469.8    469.8 txnRbk
		  | BEGIN
		  |   ALTER TABLE public.table309 DROP COLUMN "col309_368";
		  | ROLLBACK; ERROR: column "col309_368" does not exist (SQLSTATE 42703)
		  | BEGIN
		  |   ALTER TABLE public.table309 ALTER COLUMN "col303_1" SET DATA TYPE public.enum370;
		  | ROLLBACK; ERROR: type "public.enum370" does not exist (SQLSTATE 42704)
		  | BEGIN
		  |   ALTER TABLE public.table309 DROP CONSTRAINT "table303_col303_15_col303_17_col303_8_col303_13_col303_18_col303_10_col303_14_key";
		  | ROLLBACK; ERROR: unimplemented: cannot drop UNIQUE constraint "table303_col303_15_col303_17_col303_8_col303_13_col303_18_col303_10_col303_14_key" using ALTER TABLE DROP CONSTRAINT, use DROP INDEX CASCADE instead (SQLSTATE 0A000)
		  | BEGIN
		  |   ALTER TABLE public.table309 ALTER COLUMN "col303_3" SET DATA TYPE varchar;
		  | ROLLBACK; ERROR: ALTER COLUMN TYPE from float4 to varchar is only supported experimentally (SQLSTATE 0A000)
		  | BEGIN
		  |   ALTER TABLE public.table309 ALTER COLUMN "col303_16" SET DATA TYPE "char";
		  | ROLLBACK; ERROR: ALTER COLUMN TYPE from timestamp to "char" is only supported experimentally (SQLSTATE 0A000)
		  | BEGIN
		  |   ALTER TABLE public.table309 DROP COLUMN "col303_16";
		  | ROLLBACK; ERROR: restart transaction: TransactionRetryWithProtoRefreshError: TransactionRetryError: retry txn (RETRY_WRITE_TOO_OLD - WriteTooOld flag converted to WriteTooOldError): "sql txn" meta={id=3fa1992f key=/Table/SystemConfigSpan/Start pri=0.01312331 epo=0 ts=1604391209.856504541,1 min=1604391209.458920462,0 seq=7} lock=true stat=PENDING rts=1604391209.458920462,0 wto=false max=1604391209.458920462,0 (SQLSTATE 40001)
		  | BEGIN
		  |   ALTER TABLE public.table309 RENAME TO public.table369;
		  | ROLLBACK; ERROR: restart transaction: TransactionRetryWithProtoRefreshError: TransactionRetryError: retry txn (RETRY_WRITE_TOO_OLD - WriteTooOld flag converted to WriteTooOldError): "sql txn" meta={id=9dc0ce92 key=/Table/SystemConfigSpan/Start pri=0.00709184 epo=0 ts=1604391209.856504541,1 min=1604391209.302654671,0 seq=6} lock=true stat=PENDING rts=1604391209.302654671,0 wto=false max=1604391209.302654671,0 (SQLSTATE 40001)
		  | BEGIN
		  |   DROP TABLE public.table309;
		  | ROLLBACK; ERROR: restart transaction: failed to mark job 603982425192792065 as as successful: TransactionRetryWithProtoRefreshError: TransactionRetryError: retry txn (RETRY_WRITE_TOO_OLD - WriteTooOld flag converted to WriteTooOldError): "sql txn" meta={id=9be48adb key=/Table/SystemConfigSpan/Start pri=0.01119124 epo=0 ts=1604391209.863562534,1 min=1604391209.523850704,0 seq=5} lock=true stat=PENDING rts=1604391209.523850704,0 wto=false max=1604391209.523850704,0 (SQLSTATE 40001)
		  | BEGIN
		  |   CREATE INDEX IF NOT EXISTS index309_372 ON public.table309 (col303_9 DESC, col303_14 ASC, col303_17, col303_3 DESC, col303_2 DESC, col303_10, col303_12 ASC, col303_5, col303_13 ASC, col303_18, col303_6, col303_0 ASC, col303_7 DESC, col303_1 DESC, col303_11 DESC, col303_16, col303_15 DESC, col303_8 ASC);
		  | ROLLBACK; ERROR: restart transaction: TransactionRetryWithProtoRefreshError: TransactionRetryError: retry txn (RETRY_WRITE_TOO_OLD - WriteTooOld flag converted to WriteTooOldError): "sql txn" meta={id=26768ce1 key=/Table/SystemConfigSpan/Start pri=0.02456629 epo=0 ts=1604391209.856504541,1 min=1604391209.422275976,0 seq=6} lock=true stat=PENDING rts=1604391209.422275976,0 wto=false max=1604391209.422275976,0 (SQLSTATE 40001)
		  | BEGIN
		  |   ALTER TABLE public.table309 ADD COLUMN col309_371 TIME NOT NULL;
		  | ***FAIL; Expected no errors, but got ERROR: restart transaction: TransactionRetryWithProtoRefreshError: TransactionRetryError: retry txn (RETRY_WRITE_TOO_OLD - WriteTooOld flag converted to WriteTooOldError): "sql txn" meta={id=24fa1aae key=/Table/SystemConfigSpan/Start pri=0.05040495 epo=0 ts=1604391209.856504541,1 min=1604391209.226930126,0 seq=6} lock=true stat=PENDING rts=1604391209.226930126,0 wto=false max=1604391209.226930126,0 (SQLSTATE 40001)
		Wraps: (4) exit status 20
		Error types: (1) *withstack.withStack (2) *errutil.withPrefix (3) *main.withCommandDetails (4) *exec.ExitError
More

Artifacts: /scbench/randomload/nodes=3/ops=10000/conc=20

See this test on roachdash
powered by pkg/cmd/internal/issues

Jira issue: CRDB-2965
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Nov 3, 2020
@cockroach-teamcity cockroach-teamcity added this to the 20.2 milestone Nov 3, 2020
@cockroach-teamcity

This comment has been minimized.

Sign in to view
@cockroach-teamcity

This comment has been minimized.

Sign in to view
@cockroach-teamcity

This comment has been minimized.

Sign in to view
@jayshrivastava
Copy link
Contributor

jayshrivastava commented Nov 6, 2020 •
edited
Loading

The schemachange after write error will be anticipated and handled after #56184 is merged in

This was referenced Nov 6, 2020
Merged
Merged
@cockroach-teamcity

This comment has been minimized.

Sign in to view
@cockroach-teamcity

This comment has been minimized.

Sign in to view
@cockroach-teamcity

This comment has been minimized.

Sign in to view
@cockroach-teamcity

This comment has been minimized.

Sign in to view
@cockroach-teamcity cockroach-teamcity mentioned this issue Nov 10, 2020
Closed
@cockroach-teamcity

This comment has been minimized.

Sign in to view
@cockroach-teamcity

This comment has been minimized.

Sign in to view
@cockroach-teamcity

This comment has been minimized.

Sign in to view
@cockroach-teamcity

This comment has been minimized.

Sign in to view
craig bot pushed a commit that referenced this issue Nov 15, 2020
@jayshrivastava
Merge #56184
117d32e 
56184: workload/schemachange: screen for errors in operations r=ajwerner a=jayshrivastava

workload/schemachange: screen for errors in operations

These changes add error screening for the following (#56119):
- createEnum op
- createSchema op
- dropColumn op
- dropColumnDefault op
- dropColumnNotNull op
- dropSchema op
- renameColumn op
- renameTable op
- renameView op

Also, errors caused by schema changes after writes in the same txn are handled (#56230)

It also resolves a bug related to ambiguity in column names that was caused by views/tables referencing the same columns (#56235). 


Co-authored-by: Jayant Shrivastava <[email protected]>
@cockroach-teamcity

This comment has been minimized.

Sign in to view
@cockroach-teamcity

This comment has been minimized.

Sign in to view
@cockroach-teamcity

This comment has been minimized.

Sign in to view
@thoszhang thoszhang removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Nov 19, 2020
@cockroach-teamcity
Copy link
Member Author

roachtest.scbench/randomload/nodes=3/ops=10000/conc=20 failed with artifacts on master @ 4c65a10fea9762b97559c1a488cd5b96cb2cf81a:

		  |   "ALTER DATABASE schemachange SURVIVE REGION FAILURE"
		  |  ],
		  |  "expectedExecErrors": "22023,42602",
		  |  "expectedCommitErrors": "",
		  |  "message": "ROLLBACK; Successfully got expected execution error: ERROR: database must have associated regions before a survival goal can be set (SQLSTATE 42602)"
		  | }
		  | {
		  |  "workerId": 0,
		  |  "clientTimestamp": "07:53:50.217497",
		  |  "ops": [
		  |   "BEGIN",
		  |   "CREATE TYPE public.enum703 AS ENUM ('aff', 'sd', 'fad', 'fds', 'ds')",
		  |   "COMMIT"
		  |  ],
		  |  "expectedExecErrors": "",
		  |  "expectedCommitErrors": "",
		  |  "message": ""
		  | }
		  | {
		  |  "workerId": 0,
		  |  "clientTimestamp": "07:53:49.385098",
		  |  "ops": [
		  |   "BEGIN",
		  |   "ALTER SEQUENCE schema158.seq529 RENAME TO schema158.seq649"
		  |  ],
		  |  "expectedExecErrors": "",
		  |  "expectedCommitErrors": "",
		  |  "message": "ERROR: restart transaction: TransactionRetryWithProtoRefreshError: TransactionAbortedError(ABORT_REASON_PUSHER_ABORTED): \"sql txn\" meta={id=dbe5fd02 key=/Table/3/1/200/2/1 pri=0.00775196 epo=0 ts=1645516430.124789642,1 min=1645516429.385009294,0 seq=1} lock=true stat=ABORTED rts=1645516429.385009294,0 wto=false gul=1645516429.885009294,0 (SQLSTATE 40001)"
		  | }
		  | {
		  |  "workerId": 0,
		  |  "clientTimestamp": "07:53:49.918621",
		  |  "ops": [
		  |   "BEGIN",
		  |   "SELECT 'validating all objects', crdb_internal.validate_multi_region_zone_configs()",
		  |   "SELECT 'validating all objects', crdb_internal.validate_multi_region_zone_configs()",
		  |   "CREATE TABLE IF NOT EXISTS schema3.table688 (col688_689 BOX2D NOT NULL, col688_690 \"char\" NOT NULL, col688_691 CHAR NOT NULL, col688_692 INTERVAL NOT NULL, col688_693 REGPROCEDURE NOT NULL, col688_694 INTERVAL NOT NULL, col688_695 INT8 NOT NULL, col688_696 \"char\" NOT NULL, col688_697 REGPROCEDURE NOT NULL, col688_698 FLOAT8, col688_699 STRING NOT NULL AS (CASE WHEN col688_692 IS NULL THEN '':::STRING ELSE e'\\n\\x1f\\x0b':::STRING END) VIRTUAL, col688_700 STRING NOT NULL AS (lower(CAST(col688_689 AS STRING))) VIRTUAL, col688_701 STRING NOT NULL AS (lower(col688_696)) STORED, PRIMARY KEY (col688_693 ASC, col688_701, col688_700 DESC, col688_692 ASC, col688_689, col688_696 DESC, col688_699, col688_694, col688_695 ASC), UNIQUE (col688_692 DESC, col688_698 DESC, (CASE WHEN col688_697 IS NULL THEN 'X':::STRING ELSE 'Xa;u':::STRING END), lower(CAST(col688_689 AS STRING)) DESC), UNIQUE (col688_693 ASC, lower(col688_690), col688_695) STORING (col688_690, col688_691), UNIQUE (col688_691 DESC, col688_701 DESC, lower(col688_690), col688_689 DESC, col688_697, col688_692, col688_698 ASC, col688_690 DESC, col688_699 DESC), UNIQUE (col688_692 ASC, lower(col688_690) DESC, lower(CAST(col688_689 AS STRING)) DESC, col688_699 DESC, col688_690, col688_691, col688_697 DESC, col688_693, col688_689 DESC, col688_700 DESC, col688_701 ASC, col688_695), INDEX (col688_693, col688_690, lower(col688_691) ASC, col688_692 DESC, col688_691 ASC, col688_694))",
		  |   "ALTER TABLE schema3.table688 ALTER COLUMN \"col688_689\" DROP NOT NULL"
		  |  ],
		  |  "expectedExecErrors": "",
		  |  "expectedCommitErrors": "",
		  |  "message": "***UNEXPECTED ERROR; Received an unexpected execution error: ERROR: column \"col688_689\" is in a primary index (SQLSTATE 42P16)"
		  | }
		Wraps: (4) COMMAND_PROBLEM
		Wraps: (5) Node 1. Command with error:
		  | ``````
		  | ./workload run schemachange --verbose=1 --tolerate-errors=false  --histograms=perf/stats.json --max-ops 10000 --concurrency 20 --txn-log /mnt/data1/cockroach/transactions.json
		  | ``````
		Wraps: (6) exit status 1
		Error types: (1) *withstack.withStack (2) *errutil.withPrefix (3) *cluster.WithCommandDetails (4) errors.Cmd (5) *hintdetail.withDetail (6) *exec.ExitError
Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.scbench/randomload/nodes=3/ops=10000/conc=20 failed with artifacts on master @ 1d13605e2aeb1af0a5536f1f460e45d557119128:

		  |  ],
		  |  "expectedExecErrors": "42P01",
		  |  "expectedCommitErrors": "",
		  |  "message": "ROLLBACK; Successfully got expected execution error: ERROR: relation \"public.table89\" does not exist (SQLSTATE 42P01)"
		  | }
		  | {
		  |  "workerId": 0,
		  |  "clientTimestamp": "07:36:24.236494",
		  |  "ops": [
		  |   "BEGIN",
		  |   "ALTER DATABASE schemachange PRIMARY REGION \"us-east1\"",
		  |   "DROP SEQUENCE IF EXISTS public.seq90",
		  |   "SELECT 'validating all objects', crdb_internal.validate_multi_region_zone_configs()",
		  |   "COMMIT"
		  |  ],
		  |  "expectedExecErrors": "",
		  |  "expectedCommitErrors": "",
		  |  "message": "TXN RETRY ERROR; ERROR: restart transaction: TransactionRetryWithProtoRefreshError: TransactionRetryError: retry txn (RETRY_SERIALIZABLE - failed preemptive refresh due to a conflict: intent on key /Table/3/1/123/2/1): \"sql txn\" meta={id=2fe35409 key=/Table/15/1/739021241109151745/0 pri=0.00827345 epo=0 ts=1645601784.702747656,1 min=1645601784.236408192,0 seq=24} lock=true stat=PENDING rts=1645601784.236408192,0 wto=false gul=1645601784.736408192,0 (SQLSTATE 40001)"
		  | }
		  | {
		  |  "workerId": 0,
		  |  "clientTimestamp": "07:36:24.488098",
		  |  "ops": [
		  |   "BEGIN",
		  |   "CREATE TABLE public.table92 AS SELECT public.table88.col84_85, public.table88.col84_85, public.table88.col84_86, public.table88.col84_86, public.table88.col84_85 FROM public.table88, public.table88, public.table88"
		  |  ],
		  |  "expectedExecErrors": "42701,42712",
		  |  "expectedCommitErrors": "",
		  |  "message": "ROLLBACK; Successfully got expected execution error: ERROR: source name \"table88\" specified more than once (missing AS clause) (SQLSTATE 42712)"
		  | }
		  | {
		  |  "workerId": 0,
		  |  "clientTimestamp": "07:36:24.450215",
		  |  "ops": [
		  |   "BEGIN",
		  |   "ALTER DATABASE schemachange PRIMARY REGION \"us-east1\"",
		  |   "SELECT 'validating all objects', crdb_internal.validate_multi_region_zone_configs()",
		  |   "ALTER TABLE public.table88 ALTER COLUMN \"col84_86\" DROP NOT NULL"
		  |  ],
		  |  "expectedExecErrors": "",
		  |  "expectedCommitErrors": "",
		  |  "message": "***UNEXPECTED ERROR; Received an unexpected execution error: ERROR: column \"col84_86\" is in a primary index (SQLSTATE 42P16)"
		  | }
		Wraps: (4) COMMAND_PROBLEM
		Wraps: (5) Node 1. Command with error:
		  | ``````
		  | ./workload run schemachange --verbose=1 --tolerate-errors=false  --histograms=perf/stats.json --max-ops 10000 --concurrency 20 --txn-log /mnt/data1/cockroach/transactions.json
		  | ``````
		Wraps: (6) exit status 1
		Error types: (1) *withstack.withStack (2) *errutil.withPrefix (3) *cluster.WithCommandDetails (4) errors.Cmd (5) *hintdetail.withDetail (6) *exec.ExitError
Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.scbench/randomload/nodes=3/ops=10000/conc=20 failed with artifacts on master @ a7449866f3229872d92e1de973e209838f07de35:

		  |  "expectedCommitErrors": "",
		  |  "message": "TXN RETRY ERROR; ERROR: restart transaction: TransactionRetryWithProtoRefreshError: TransactionRetryError: retry txn (RETRY_SERIALIZABLE - failed preemptive refresh due to a conflict: intent on key /Table/3/1/177/2/1): \"sql txn\" meta={id=f4715cff key=/Table/3/1/151/2/1 pri=0.00326559 epo=0 ts=1645688381.204802526,1 min=1645688380.983769905,0 seq=13} lock=true stat=PENDING rts=1645688380.983769905,0 wto=false gul=1645688381.483769905,0 (SQLSTATE 40001)"
		  | }
		  | {
		  |  "workerId": 0,
		  |  "clientTimestamp": "07:39:40.942659",
		  |  "ops": [
		  |   "BEGIN",
		  |   "SELECT 'validating all objects', crdb_internal.validate_multi_region_zone_configs()",
		  |   "ALTER TABLE public.table104 ALTER COLUMN \"col104_114\" DROP DEFAULT",
		  |   "CREATE UNIQUE INDEX IF NOT EXISTS index104_229 ON public.table104 (col104_108) STORING (col104_109, col104_122, col104_121, col104_119, col104_112, col104_105, col104_116, col104_114, col104_111, col104_120, col104_118, col104_106, col104_107, col104_113)"
		  |  ],
		  |  "expectedExecErrors": "XXUUU",
		  |  "expectedCommitErrors": "",
		  |  "message": "ROLLBACK; Successfully got expected execution error: ERROR: relation \"table104\" (151): index \"index104_229\" cannot store virtual column \"col104_122\" (SQLSTATE XXUUU)"
		  | }
		  | {
		  |  "workerId": 0,
		  |  "clientTimestamp": "07:39:41.053079",
		  |  "ops": [
		  |   "BEGIN",
		  |   "ALTER TABLE public.table104 ADD COLUMN col104_199 TIME NOT NULL UNIQUE",
		  |   "DROP TABLE public.table104 RESTRICT",
		  |   "CREATE TYPE public.enum230 AS ENUM ('sfsafs', 'sa', 'sf', 'fsafa', 'fss')",
		  |   "SELECT 'validating all objects', crdb_internal.validate_multi_region_zone_configs()",
		  |   "COMMIT"
		  |  ],
		  |  "expectedExecErrors": "",
		  |  "expectedCommitErrors": "",
		  |  "message": "TXN RETRY ERROR; ERROR: restart transaction: TransactionRetryWithProtoRefreshError: TransactionRetryError: retry txn (RETRY_SERIALIZABLE - failed preemptive refresh due to a conflict: intent on key /Table/3/1/177/2/1): \"sql txn\" meta={id=ab81c015 key=/Table/3/1/151/2/1 pri=0.03646337 epo=0 ts=1645688381.204802526,1 min=1645688381.053001754,0 seq=29} lock=true stat=PENDING rts=1645688381.053001754,0 wto=false gul=1645688381.553001754,0 (SQLSTATE 40001)"
		  | }
		  | {
		  |  "workerId": 0,
		  |  "clientTimestamp": "07:39:40.948719",
		  |  "ops": [
		  |   "BEGIN",
		  |   "ALTER TABLE public.table104 ALTER COLUMN \"col104_119\" DROP NOT NULL",
		  |   "ALTER TABLE public.table104 ALTER COLUMN \"col104_118\" SET NOT NULL"
		  |  ],
		  |  "expectedExecErrors": "",
		  |  "expectedCommitErrors": "",
		  |  "message": "***UNEXPECTED ERROR; Failed to generate a random operation: Validation FAIL:\nid 151, db schemachange, schema public, name table104: mutation job 739305002021224449: job not found"
		  | }
		Wraps: (4) COMMAND_PROBLEM
		Wraps: (5) Node 1. Command with error:
		  | ``````
		  | ./workload run schemachange --verbose=1 --tolerate-errors=false  --histograms=perf/stats.json --max-ops 10000 --concurrency 20 --txn-log /mnt/data1/cockroach/transactions.json
		  | ``````
		Wraps: (6) exit status 1
		Error types: (1) *withstack.withStack (2) *errutil.withPrefix (3) *cluster.WithCommandDetails (4) errors.Cmd (5) *hintdetail.withDetail (6) *exec.ExitError
Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

tbg added a commit to tbg/cockroach that referenced this issue Feb 24, 2022
@tbg
roachtest: skip scbench
85ba5e0 
See cockroachdb#56230.

I don't usually go around skipping other team's tests, but this one
regularly times out, occupying a cluster for 10h, and possibly
contributing to timeouts of the roachtest suite as a whole.

Looking at the failure issue it's also clear that the owning team is not
deriving any signal whatsoever from this test at the moment.

Release note: None
@tbg tbg mentioned this issue Feb 24, 2022
Merged
@tbg
Copy link
Member

tbg commented Feb 24, 2022

Skipping this test in #76970.

craig bot pushed a commit that referenced this issue Feb 24, 2022
@tbg
Merge #76970
96fe1ea 
76970: roachtest: skip scbench r=otan a=tbg

See #56230.

I don't usually go around skipping other team's tests, but this one
regularly times out, occupying a cluster for 10h, and possibly
contributing to timeouts of the roachtest suite as a whole.

Looking at the failure issue it's also clear that the owning team is not
deriving any signal whatsoever from this test at the moment.

Release note: None


Co-authored-by: Tobias Grieger <[email protected]>
maryliag pushed a commit to maryliag/cockroach that referenced this issue Feb 28, 2022
@tbg @maryliag
roachtest: skip scbench
3d3bc40 
See cockroachdb#56230.

I don't usually go around skipping other team's tests, but this one
regularly times out, occupying a cluster for 10h, and possibly
contributing to timeouts of the roachtest suite as a whole.

Looking at the failure issue it's also clear that the owning team is not
deriving any signal whatsoever from this test at the moment.

Release note: None
RajivTS pushed a commit to RajivTS/cockroach that referenced this issue Mar 6, 2022
@tbg @RajivTS
roachtest: skip scbench
127fe87 
See cockroachdb#56230.

I don't usually go around skipping other team's tests, but this one
regularly times out, occupying a cluster for 10h, and possibly
contributing to timeouts of the roachtest suite as a whole.

Looking at the failure issue it's also clear that the owning team is not
deriving any signal whatsoever from this test at the moment.

Release note: None
@postamar
Copy link
Contributor

Retriaging to either unskip or remove. I can't remember why I closed this.

@postamar postamar reopened this Jul 20, 2022
@exalate-issue-sync exalate-issue-sync bot added T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) and removed T-sql-schema-deprecated Use T-sql-foundations instead labels May 10, 2023
@rafiss
Copy link
Collaborator

rafiss commented Jun 20, 2023

As per the convo in https://cockroachlabs.slack.com/archives/C04N0AS14CT/p1686856008458059, let's just remove this test.

@rafiss rafiss assigned rimadeodhar and unassigned fqazi Jun 20, 2023
@rimadeodhar rimadeodhar mentioned this issue Jun 30, 2023
Merged
craig bot pushed a commit that referenced this issue Jun 30, 2023
@gtr @rimadeodhar
Merge #105771 #105919
6179bae 
105771:  sql: increase time buffer for TestCaptureIndexUsageStats r=gtr a=gtr

Note to reviewers: this builds on top of #105755, please only consider the second commit.

Previously, the `pkg/sql/scheduleslogging/TestCaptureIndexUsageStats`
test failed on CI, despire passing locally. This commit increases the
time buffer from 3s to 4s to give a larger tolerance for
non-determinism.

Fixes #102980
Release note: None

105919: roachtest: Delete scbench randomload test r=rafiss a=rimadeodhar

This test has been skipped for a year and based
on the history of the test hasn't been providing
much value. We can delete it now. Random
schema change testing is covered by schemachange/randomload.

Epic: none
Fixes: #56230
Release note: None

Co-authored-by: gtr <[email protected]>
Co-authored-by: rimadeodhar <[email protected]>
@craig craig bot closed this as completed in 63c1553 Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rimadeodhar rimadeodhar

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. skipped-test T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

roachtest: Delete scbench randomload test rimadeodhar/cockroach
9 participants
@jlinder @rafiss @fqazi @postamar @thoszhang @tbg @jayshrivastava @cockroach-teamcity @rimadeodhar