Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doctor: ensure that parentSchemaID is in parentID #55716

Closed
ajwerner opened this issue Oct 19, 2020 · 1 comment · Fixed by #58875
Closed

doctor: ensure that parentSchemaID is in parentID #55716

ajwerner opened this issue Oct 19, 2020 · 1 comment · Fixed by #58875
Assignees
@postamar
Labels
A-debug-automation Issues or feature requests for debug automation C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@ajwerner
Copy link
Contributor

Is your feature request related to a problem? Please describe.

This is a handy check for the doctor to perform. See #55710 (comment).
@ajwerner ajwerner added the A-debug-automation Issues or feature requests for debug automation label Oct 19, 2020
@blathers-crl
Copy link

blathers-crl bot commented Oct 19, 2020

Hi @ajwerner, I've guessed the C-ategory of your issue and suitably labeled it. Please re-label if inaccurate.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl blathers-crl bot added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Oct 19, 2020
@ajwerner ajwerner mentioned this issue Oct 19, 2020
Closed
@postamar postamar self-assigned this Dec 3, 2020
postamar pushed a commit to postamar/cockroach that referenced this issue Jan 12, 2021
sql: add doctor check for parent schema in parent db
6bbd2a3 
With this patch, doctor now also checks that the parent id of an object
matches the parent id of the parent schema of the object.

Fixes cockroachdb#55716.

Release note: None
@postamar postamar mentioned this issue Jan 12, 2021
Merged
postamar pushed a commit to postamar/cockroach that referenced this issue Jan 14, 2021
sql: add doctor check for parent schema in parent db
af9d6fb 
With this patch, doctor now also checks that the parent id of an object
matches the parent id of the parent schema of the object.

Fixes cockroachdb#55716.

Release note: None
craig bot pushed a commit that referenced this issue Jan 14, 2021
Merge #58875 #58947
b1f5a62 
58875: sql: add doctor check for parent schema in parent db r=postamar a=postamar

With this patch, doctor now also checks that the parent id of an object
matches the parent id of the parent schema of the object.

Fixes #55716.

Release note: None

58947: sql: fix index column direction lookup bugs r=postamar a=postamar

This patch fixes a couple of instances in which we look up an index's
column directions using a wrong ordinal when the index has implicit
columns due to it being sharded or partitioned.

Fixes #58945.

Release note (bug fix): The indoption column in pg_catalog.index is now
populated correctly.

Co-authored-by: Marius Posta <[email protected]>
@craig craig bot closed this as completed in 943ecdd Jan 14, 2021
@postamar postamar mentioned this issue Jan 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@postamar postamar

Labels
A-debug-automation Issues or feature requests for debug automation C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: add doctor check for parent schema in parent db postamar/cockroach
2 participants
@ajwerner @postamar