Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: minor bugfixes for Transactions Page #55131

Closed
dhartunian opened this issue Oct 1, 2020 · 1 comment · Fixed by #55325
Closed

ui: minor bugfixes for Transactions Page #55131

dhartunian opened this issue Oct 1, 2020 · 1 comment · Fixed by #55325
Assignees
@vladlos
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@dhartunian
Copy link
Collaborator

  • Move the Transactions link to appear between "Active Sessions" and "Statements" in the left-hand nav
  • Show 20 items at a time in transactions list pages (currently set to 10)
  • Update txn font to RobotoMono-Medium hex #475872 (match jobs and statements font)
  • Fix bug where filtering by "greater than 0 seconds" produces fewer results than no filter at all.

Testing Requirements

  • filtering bug should have corresponding unit test that reproduces the error
@blathers-crl
Copy link

blathers-crl bot commented Oct 1, 2020

Hi @dhartunian, I've guessed the C-ategory of your issue and suitably labeled it. Please re-label if inaccurate.

While you're here, please consider adding an A- label to help keep our repository tidy.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl blathers-crl bot added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Oct 1, 2020
vladlos added a commit to vladlos/cockroach that referenced this issue Oct 8, 2020
@vladlos
ui: minor bugfixes for Transactions Page
132dc06 
Move the Transactions link to appear between "Active Sessions" and "Statements" in the left-hand nav

Resolves: cockroachdb#55131

Release note (ui): none
@vladlos vladlos mentioned this issue Oct 8, 2020
Merged
craig bot pushed a commit that referenced this issue Nov 12, 2020
@vladlos @andreimatei
@nkodali @jclulow @tbg
Merge #55325 #56346 #56437 #56533 #56591 #56600
b920aab 
55325: ui: Transactions link between Sessions and Statements r=dhartunian a=elkmaster

Resolves: #55131, #56244

Release note (admin ui change): Link to the Transactions page is now shown
between the Sessions and Statements links in the left hand navigation. This more
clearly reflects the hierarchy between the 3 concepts.

56346: testcluster: minor logging improvements r=andreimatei a=andreimatei

Log when TestCluster quiescing starts, and add a node log tag to each
node's quiescing ctx so messages from different nodes can be
disambiguated.

Release note: None

56437: cli, ui: dismiss release notes signup banner per environment variable r=knz,dhartunian a=nkodali

Previously, the signup banner could only be dismissed manually.
For internal testing purposes, this banner is unnecessary. This
change provides a way to dismiss the signup banner upon start of
a cluster via the cli by setting the environment variable
COCKROACH_UI_RELEASE_NOTES_SIGNUP_DISMISSED=true.

Resolves #46998

Release note: none

56533: backupccl: add feature flag support for BACKUP, RESTORE r=otan a=angelapwen

Follow-up to the RFC at #55778. This addresses the SRE use case mentioned in #51643 — instead of moving forward with a global denylist as the RFC indicated, we are prototyping feature flags via cluster settings to turn on/off requested features. The first part of the prototype will be done on `BACKUP` and `RESTORE` commands.

See [this doc](https://docs.google.com/document/d/1nZSdcK7YprL0P4TAuseY-mvlYnd82IaJ_ptAQDoWB6o/edit?) for further details. 

Note that the logic test under `ccl/backupccl/testdata/backup-restore/feature-flags` can be tested with the command `make test PKG=./pkg/ccl/backupccl TESTS='TestBackupRestoreDataDriven'`

— Commit message below — 

Adds a cluster setting to toggle a feature flag for the BACKUP and
RESTORE commands off and on; as well as a broad category for
Bulk IO commands. Currently disabling the cluster setting for Bulk
IO will only disable BACKUP and RESTORE jobs, but other types may
be included in this category in the future..

The feature is being introduced to address a Cockroach Cloud SRE
use case: needing  to disable certain categories of features in
case of cluster failure.

Release note (enterprise change): Adds cluster settings to enable/
disable the BACKUP and RESTORE commands. If a user attempts to use
these features while they are disabled, an error indicating that
the database administrator has disabled the feature is surfaced.

Example usage for the database administrator:
SET CLUSTER SETTING feature.bulkio.backup.enabled = FALSE;
SET CLUSTER SETTING feature.bulkio.backup.enabled = TRUE;
SET CLUSTER SETTING feature.bulkio.restore.enabled = FALSE;
SET CLUSTER SETTING feature.bulkio.restore.enabled = TRUE;
SET CLUSTER SETTING feature.bulkio.enabled = FALSE;
SET CLUSTER SETTING feature.bulkio.enabled = TRUE;

56591: ui: fix Overview screen in OSS builds r=dhartunian a=davepacheco

Previously, when using OSS builds (created with `make buildoss`), when
you loading the DB Console in your browser, you'd get "Page Not Found".
The route for the overview page was missing the leading '/'.  This bug
appears to have been introduced in
722c932.

Release note (admin ui change): This fixes a bug where users of
the OSS builds of CockroachDB would see "Page Not Found" when loading
the Console.

56600: roachpb: remove SetInner in favor of MustSetInner r=nvanbenschoten a=tbg

As of a recent commit, `ErrorDetail.SetInner` became unused, and
we can switch to a `MustSetInner` pattern for `ErrorDetail`. Since
the codegen involved is shared with {Request,Response}Union, those
lose the `SetInner` setter as well; we were always asserting on
the returned bool there anyway so this isn't changing anything.

Release note: None



Co-authored-by: Vlad Los <[email protected]>
Co-authored-by: Andrei Matei <[email protected]>
Co-authored-by: Namrata Kodali <[email protected]>
Co-authored-by: angelapwen <[email protected]>
Co-authored-by: Joshua M. Clulow <[email protected]>
Co-authored-by: Tobias Grieger <[email protected]>
craig bot pushed a commit that referenced this issue Nov 13, 2020
@vladlos
Merge #55325
e68a1de 
55325: ui: Transactions link between Sessions and Statements r=dhartunian a=elkmaster

Resolves: #55131, #56244

Release note (admin ui change): Link to the Transactions page is now shown
between the Sessions and Statements links in the left hand navigation. This more
clearly reflects the hierarchy between the 3 concepts.

Co-authored-by: Vlad Los <[email protected]>
@craig craig bot closed this as completed in 1550ec4 Nov 13, 2020
dhartunian pushed a commit to dhartunian/cockroach that referenced this issue Nov 13, 2020
@vladlos @dhartunian
ui: Transactions link between Sessions and Statements
963cfac 
Resolves: cockroachdb#55131, cockroachdb#56244

Release note (admin ui change): Link to the Transactions page is now shown
between the Sessions and Statements links in the left hand navigation. This more
clearly reflects the hierarchy between the 3 concepts.
vladlos added a commit to vladlos/cockroach that referenced this issue Dec 11, 2020
@vladlos
ui: update components dep
124d536 
requested version of package in admin-ui-components includes:
 - brand update changes (primary color, new link colors)
 - transactions page followups (default per page value, txn font)

Resolves: cockroachdb#56959, cockroachdb#55131

Release note (ui): Changed defualt per page value on Transactions page to 20, minor style updates
@vladlos vladlos mentioned this issue Dec 11, 2020
Merged
craig bot pushed a commit that referenced this issue Dec 14, 2020
@vladlos
Merge #57824
1b3186d 
57824: ui: update components dep r=elkmaster a=elkmaster

requested version of package in admin-ui-components includes:
 - brand update changes (primary color, new link colors)
 - transactions page followups (default per page value, txn font)

Resolves: #56959, #55131

Release note (ui): Changed defualt per page value on Transactions page to 20, minor style updates

cockroachdb/yarn-vendored#45


Co-authored-by: Vlad Los <[email protected]>
dhartunian pushed a commit to dhartunian/cockroach that referenced this issue Dec 17, 2020
@vladlos @dhartunian
ui: update components dep
8172e46 
requested version of package in admin-ui-components includes:
 - brand update changes (primary color, new link colors)
 - transactions page followups (default per page value, txn font)

Resolves: cockroachdb#56959, cockroachdb#55131

Release note (ui): Changed defualt per page value on Transactions page to 20, minor style updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vladlos vladlos

Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ui: Transactions link between Sessions and Statements vladlos/cockroach
2 participants
@dhartunian @vladlos