sql/logictest: TestLogic/local-vec-auto/drop_type timed out under race #54839
Assignees
Labels
branch-master
Failures and bugs on the master branch.
C-test-failure
Broken test (automatically or manually discovered).
O-robot
Originated from a bot.
Milestone
Comments
cockroach-teamcity
added
branch-master
asubiotto
changed the title
|
cc @rytaft. This is a race timeout still with the 4h timeout that is different from #54685. The test itself doesn't seem to be stuck based on the goroutine stacks, but something that's curious is that in the logs I see an |
|
I agree -- this one seems like a legit timeout. I can try removing the verbosity flag, and maybe I'll also just bump the timeout again up to 8h. I think the verbosity flag is enabled on most other tests to provide as much debugging info as possible, but while we're experimenting with this test it's worth a try... |
Under race, I think the verbosity is not as useful as other tests since we're specifically looking for only races. |
craig bot
pushed a commit
that referenced
this issue
Sep 29, 2020
54446: backupccl: clear table stats from manifest on canceled backup r=dt a=pbardea The table statistics that are being backed up are stored in the backup manifest, and thus the job description in v19.2 and v20.1. They are cleared when the job completes successfully. This commit changes backup to also clear the statistics when the job either fails or is canceled. Failing to do this may leave behind unnecassarily large job rows. Release note (bug fix): Clear table statistics from job description in failed and canceled backup jobs. 54489: roachtest: add schemachange/database-version-upgrade r=lucy-zhang a=lucy-zhang This PR adds a new mixed-version roachtest, which tests 2 loosely related things: 1. Correctness of database schema changes during the 20.1/20.2 mixed- version state, in which 20.2 nodes still use the deprecated database cache and non-lease-based schema change implementation. 2. Ability to use ALTER DATABASE ... CONVERT TO SCHEMA WITH PARENT on databases created in 20.1. To these ends, the test creates several databases, runs schema changes on each one at different states in the rolling upgrade process, and runs the reparenting statement on all of them post-finalization. Closes #53568. Release note: None 54792: importccl: improve IMPORT telemetry r=miretskiy a=adityamaru This change reworks how we count import telemetry to a per file format basis. It counts 4 states at different stages of the import: The current states being counted are: - attempted: Counted at the very beginning of the IMPORT. - started: Counted just before the IMPORT job is started. - failed: Counted when the IMPORT job is failed or cancelled. - succeeded: Counted when the IMPORT job completes successfully. Previously we were counting "started" imports in the Resume job method which would lead to incorrect numbers because of job restarts, this change fixes that too. Fixes: #52734 Release note: None 54876: sql: wait for canceled mutations to be at the head of the queue for reverse r=lucy-zhang a=ajwerner Before this commit, we'd totally skip the process of rolling back a mutation if it were not the first mutation in line. This behavior was nonsense. Perhaps there is a more principled change to be made whereby we just remove mutations which are not at the head of the queue. I'm open to making such a change. This seemed more pragmatic, though it may have problems I am not aware of. Fixes #54861 Release note (bug fix): Fixed a bug which can occur when canceling schema changes when there are multiple queued schema changes that could result in future schema changes being stuck. 54950: build: reduce verbosity and bump timeout for SQL Race Logic Test r=rytaft a=rytaft This commit eliminates `TESTFLAGS='-v'` and bumps the timeout to 8 hours. Fixes #54839 Release note: None Co-authored-by: Paul Bardea <[email protected]> Co-authored-by: Lucy Zhang <[email protected]> Co-authored-by: Aditya Maru <[email protected]> Co-authored-by: Andrew Werner <[email protected]> Co-authored-by: Rebecca Taft <[email protected]>
rytaft
added a commit
to rytaft/cockroach
that referenced
this issue
Sep 29, 2020
This commit eliminates TESTFLAGS='-v' and bumps the timeout to 8 hours. Fixes cockroachdb#54839 Release note: None
rytaft
added a commit
to rytaft/cockroach
that referenced
this issue
Sep 29, 2020
This commit eliminates TESTFLAGS='-v' and bumps the timeout to 8 hours. Fixes cockroachdb#54839 Release note: None
rytaft
added a commit
to rytaft/cockroach
that referenced
this issue
Sep 29, 2020
This commit eliminates TESTFLAGS='-v' and bumps the timeout to 8 hours. Fixes cockroachdb#54839 Release note: None
craig bot
pushed a commit
that referenced
this issue
Oct 1, 2020
55021: logictest: remove explicit set_vmodule call in index_join r=rytaft,yuzefovich a=asubiotto The nightly high-verbosity logic tests already take care of testing this. Release note: None (testing change) Addresses #54839 Co-authored-by: Alfonso Subiotto Marques <[email protected]>
jayshrivastava
pushed a commit
that referenced
this issue
Oct 8, 2020
This commit eliminates TESTFLAGS='-v' and bumps the timeout to 8 hours. Fixes #54839 Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
(sql/logictest).TestLogic/local-vec-auto/drop_type failed on master@1be32272030366639be5b4093c6d45bc143978ba:
More
See this test on roachdash
powered by pkg/cmd/internal/issues
The text was updated successfully, but these errors were encountered: