Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql/catalog: SchemaDescriptor should have a Validate method #53439

Closed
thoszhang opened this issue Aug 25, 2020 · 1 comment
Closed

sql/catalog: SchemaDescriptor should have a Validate method #53439

thoszhang opened this issue Aug 25, 2020 · 1 comment
Assignees
@postamar
Labels
A-schema-descriptors Relating to SQL table/db descriptor handling. C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.

Comments

@thoszhang
Copy link
Contributor

Specifically, we should validate that the schema's parent database contains the schema in its schema map.
@thoszhang thoszhang added C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. A-schema-descriptors Relating to SQL table/db descriptor handling. labels Aug 25, 2020
@thoszhang thoszhang changed the title sql: SchemaDescriptor should have a Validate method sql/catalog: SchemaDescriptor should have a Validate method Aug 25, 2020
@isaactwong isaactwong mentioned this issue Sep 1, 2020
Closed
40 tasks
@thoszhang thoszhang assigned postamar and unassigned thoszhang Feb 11, 2021
postamar pushed a commit to postamar/cockroach that referenced this issue Feb 15, 2021
sql: add schema descriptor validation
fca1cfc 
Previously, the Validate() method on catalog.SchemaDescriptor did
nothing. This commit adds validation checks that verify that the
parentID exists and that that database descriptor contains the correct
entry in its `schemas` mapping.

Fixes cockroachdb#53439.

Release note: None
postamar pushed a commit to postamar/cockroach that referenced this issue Feb 16, 2021
sql: add schema descriptor validation
ebd4133 
Previously, the Validate() method on catalog.SchemaDescriptor did
nothing. This commit adds validation checks that verify that the
parentID exists and that that database descriptor contains the correct
entry in its `schemas` mapping.

Fixes cockroachdb#53439.

Release note: None
postamar pushed a commit to postamar/cockroach that referenced this issue Feb 17, 2021
sql: add schema descriptor validation
e5c1473 
Previously, the Validate() method on catalog.SchemaDescriptor did
nothing. This commit adds validation checks that verify that the
parentID exists and that that database descriptor contains the correct
entry in its `schemas` mapping.

Fixes cockroachdb#53439.

Release note: None
postamar pushed a commit to postamar/cockroach that referenced this issue Feb 17, 2021
sql: add schema descriptor validation
efa86f8 
Previously, the Validate() method on catalog.SchemaDescriptor did
nothing. This commit adds validation checks that verify that the
parentID exists and that that database descriptor contains the correct
entry in its `schemas` mapping.

Fixes cockroachdb#53439.

Release note: None
@thoszhang
Copy link
Contributor Author

#60552 does this.

@craig craig bot closed this as completed in 9065522 Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@postamar postamar

Labels
A-schema-descriptors Relating to SQL table/db descriptor handling. C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@postamar @thoszhang