Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: follower-reads/nodes=3 failed #52614

Closed
cockroach-teamcity opened this issue Aug 11, 2020 · 1 comment · Fixed by #52925
Closed

roachtest: follower-reads/nodes=3 failed #52614

cockroach-teamcity opened this issue Aug 11, 2020 · 1 comment · Fixed by #52925
Labels
C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.
Milestone
20.2

Comments

@cockroach-teamcity
Copy link
Member

(roachtest).follower-reads/nodes=3 failed on release-19.2@43947e6e6080136be9e2c643cef12e54da279a6c:

The test failed on branch=release-19.2, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/follower-reads/nodes=3/run_1
	follower_reads.go:196,test_runner.go:754: error verifying node values: pq: AS OF SYSTEM TIME: only constant expressions or experimental_follower_read_timestamp are allowed
More

Artifacts: /follower-reads/nodes=3
Related:

See this test on roachdash
powered by pkg/cmd/internal/issues
@cockroach-teamcity cockroach-teamcity added branch-release-19.2 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Aug 11, 2020
@cockroach-teamcity cockroach-teamcity added this to the 20.2 milestone Aug 11, 2020
@cockroach-teamcity cockroach-teamcity mentioned this issue Aug 11, 2020
Closed
@cockroach-teamcity
Copy link
Member Author

(roachtest).follower-reads/nodes=3 failed on release-19.2@74b1a5cef203cdc2fccfeece5068c4ec26a014fb:

The test failed on branch=release-19.2, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/follower-reads/nodes=3/run_1
	follower_reads.go:196,test_runner.go:754: error verifying node values: pq: AS OF SYSTEM TIME: only constant expressions or experimental_follower_read_timestamp are allowed
More

Artifacts: /follower-reads/nodes=3
Related:

See this test on roachdash
powered by pkg/cmd/internal/issues

This was referenced Aug 14, 2020
Closed
Closed
@nvanbenschoten nvanbenschoten mentioned this issue Aug 17, 2020
Merged
craig bot pushed a commit that referenced this issue Aug 18, 2020
@nvanbenschoten
Merge #52925
35c7b42 
52925: roachtest: continue using experimental_follower_read_timestamp() builtin r=nvanbenschoten a=nvanbenschoten

Fixes #52612.
Fixes #52614.
Fixes #52615.
Fixes #52876.

In 7284376, we removed the "experimental_" prefix from the
`experimental_follower_read_timestamp()` builtin. This accidentally
broke the `follower-reads/nodes=3` roachtest on everything but `master`.
To maintain backwards compatibility, continue using the old form of the
builtin in roachtests.

Co-authored-by: Nathan VanBenschoten <[email protected]>
@craig craig bot closed this as completed in 6a071ce Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.
Projects
None yet
Milestone
20.2
Development

Successfully merging a pull request may close this issue.

roachtest: continue using experimental_follower_read_timestamp() builtin nvanbenschoten/cockroach
1 participant
@cockroach-teamcity