Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: cockroach demo and cockroach start use inconsistent terminology #47977

Closed
knz opened this issue Apr 23, 2020 · 1 comment · Fixed by #62307
Closed

cli: cockroach demo and cockroach start use inconsistent terminology #47977

knz opened this issue Apr 23, 2020 · 1 comment · Fixed by #62307
Labels
A-cli-client CLI commands that pertain to using SQL features C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) S-3-ux-surprise Issue leaves users wondering whether CRDB is behaving properly. Likely to hurt reputation/adoption.

Comments

@knz
Copy link
Contributor

knz commented Apr 23, 2020 •
edited
Loading

The two sub-commands demo and start / start-single-node both report server connection strings on the terminal.

However they do so using different words: "console" vs "webui", "sql" vs "sql/tcp", generally the look & feel is different.

We can make the UX more consistent and regular by sharing the terminology between the two.

(Reported by @jseldess )
@knz knz added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) S-3-ux-surprise Issue leaves users wondering whether CRDB is behaving properly. Likely to hurt reputation/adoption. A-cli labels Apr 23, 2020
@tharun208
Copy link
Contributor

tharun208 commented Mar 1, 2021 •
edited
Loading

@knz, I like to work on this, so, before starting what are the words we are going to use ?. I think we can go with the console as the dashboard title is cockroach console and sql is easier to understand ( But, in the demo cluster, sql/tcp is used to differentiate from UNIX socket name as we are also logging UNIX socket as sql.

tharun208 added a commit to tharun208/cockroach that referenced this issue Mar 1, 2021
@tharun208
cli: fix inconsistent db console naming
ba100d7 
Release justification: non-production code changes

making admin-ui name to be consistent across
start and demo commands

Resolves cockroachdb#56993 cockroachdb#47977

Release note: None

Signed-off-by: Tharun <[email protected]>
@tharun208 tharun208 mentioned this issue Mar 1, 2021
Closed
@knz knz mentioned this issue Mar 20, 2021
Merged
@knz knz added A-cli-client CLI commands that pertain to using SQL features and removed A-cli labels Mar 20, 2021
@craig craig bot closed this as completed in 553942e Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-cli-client CLI commands that pertain to using SQL features C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) S-3-ux-surprise Issue leaves users wondering whether CRDB is behaving properly. Likely to hurt reputation/adoption.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cli/demo: label the URLs consistently with 'start' knz/cockroach
2 participants
@knz @tharun208