-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roachtest: acceptance/version-upgrade failed #47024
Comments
(roachtest).acceptance/version-upgrade failed on release-19.2@07fd3bde66232e2e65ea6c9d7c3e8edf44442646:
More
Artifacts: /acceptance/version-upgrade
See this test on roachdash |
cc @jordanlewis and/or @asubiotto - this looks like a DistSQL-turned-migration-framework issue. Same problem as #44732 (comment) but sort of a bad outcome: The cluster starts out at 19.1, then rolls into 19.2, then rolls one node into the HEAD (=release-19.2) binary and then we see the crash. Full log at https://teamcity.cockroachdb.com/repository/download/Cockroach_Nightlies_WorkloadNightly/1857147:id/acceptance/version-upgrade/run_1/test.log
|
From node 1:
The |
Your sentence triggered a cache hit for #44102 |
And generally #44101 |
#44102 makes the fact that we have an outbox/inbox pair unexpected since those only occur in a distributed flow. It looks like the actual query that failed was trying to read some users when running
Looking at the code ( |
This comment has been minimized.
This comment has been minimized.
Remove a workaround that wasn't necessary any more (since I regenerated the fixtures last week) but which caused flakes of its own because it was re-uploading the binary for predecessorVersion while processes were running using that binary (resulting in occasional 'text file busy' on linux). Closes cockroachdb#44732. Touches cockroachdb#47024. Release note: None
(roachtest).acceptance/version-upgrade failed on release-19.2@3b556da231bb5ac15ac6ff678d61cb1ba516e6f7:
More
Artifacts: /acceptance/version-upgrade
See this test on roachdash |
47690: roachtest: deflake acceptance/version-upgrade r=spaskob a=tbg Remove a workaround that wasn't necessary any more (since I regenerated the fixtures last week) but which caused flakes of its own because it was re-uploading the binary for predecessorVersion while processes were running using that binary (resulting in occasional 'text file busy' on linux). Closes #44732. Touches #47024. Release note: None Co-authored-by: Tobias Schottdorf <[email protected]>
Saw this same failure in a master CI build just now: https://teamcity.cockroachdb.com/viewLog.html?buildId=1957256&buildTypeId=Cockroach_UnitTests_Roachtest&tab=artifacts#%2Facceptance%2Fversion-upgrade |
(roachtest).acceptance/version-upgrade failed on release-19.2@b3ccc2171c393e7c43015d090a8dacdbec499e8c:
More
Artifacts: /acceptance/version-upgrade
See this test on roachdash |
@spaskob it looks like the test gets stuck in
cockroach/pkg/cmd/roachtest/mixed_version_schemachange.go Lines 56 to 60 in e4701a8
I see this from the log output and also from the stack trace Could you take a look? |
…eleases Fixes cockroachdb#47024. Release note (bug fix): The schema change workload is meant for testing the behavior of schema changes on clusters with nodes with min version 19.0. It will deadlock on earlier versions.
49475: opt: create library that determines how joins affect input rows r=andy-kimball a=DrewKimball Previously, there was no simple way to determine whether all rows from a join input will be included in its output, nor whether input rows will be duplicated by the join. This patch adds a library that constructs a Multiplicity struct for join operators. The Multiplicity can be queried for information about how a join will affect its input rows (e.g. duplicated, filtered and/or null-extended). The existing SimplifyLeftJoinWithFilters rule has been refactored to use this library. The Multiplicity library will also be useful for future join elimination and limit pushdown rules. Release note: None 49662: roachtest: don't run schema change workload on 19.2 releases r=spaskob a=spaskob Fixes #47024. Release note (bug fix): The schema change workload is meant for testing the behavior of schema changes on clusters with nodes with min version 19.2. It will deadlock on earlier versions. Co-authored-by: Drew Kimball <[email protected]> Co-authored-by: Spas Bojanov <[email protected]>
…eleases Fixes cockroachdb#47024. Release note (bug fix): The schema change workload is meant for testing the behavior of schema changes on clusters with nodes with min version 19.2. It will deadlock on earlier versions.
(roachtest).acceptance/version-upgrade failed on release-19.2@ee759892738f7f203ff95ec7627b90d7c47b4350:
More
Artifacts: /acceptance/version-upgrade
Related:
See this test on roachdash
powered by pkg/cmd/internal/issues
The text was updated successfully, but these errors were encountered: