Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: add support for COMMENT ON VIEW/SEQUENCE/TYPE/FUNCTION #44135

Open
4 tasks
hueypark opened this issue Jan 20, 2020 · 4 comments
Open
4 tasks

sql: add support for COMMENT ON VIEW/SEQUENCE/TYPE/FUNCTION #44135

hueypark opened this issue Jan 20, 2020 · 4 comments
Labels
A-schema-changes A-sql-pgcompat Semantic compatibility with PostgreSQL C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@hueypark
Copy link
Contributor

hueypark commented Jan 20, 2020 •
edited by rafiss
Loading

  • COMMENT ON VIEW
  • COMMENT ON SEQUENCE
  • COMMENT ON TYPE
  • COMMENT ON FUNCTION (also support predefined comments on builtin functions)

Postgres docs on COMMENT ON: https://www.postgresql.org/docs/current/static/sql-comment.html

Consider the case of a dump when implementation.(#42875).

Jira issue: CRDB-5251
@knz knz added A-sql-pgcompat Semantic compatibility with PostgreSQL C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) labels Jan 20, 2020
@knz
Copy link
Contributor

knz commented Jan 20, 2020

thanks for filing

@knz knz mentioned this issue Jan 27, 2020
Open
@solongordon solongordon mentioned this issue Jun 23, 2020
Closed
elliotcourant added a commit to elliotcourant/cockroach that referenced this issue Jul 18, 2020
@elliotcourant
sql: add support for COMMENT ON VIEW, COMMENT ON SEQUENCE
414a3cb 
Added the CommentOnView and CommentOnSequence tree node and plan node.
These will each append a new type to the system.comments table for views
and sequences respectively.

This would resolve cockroachdb#44135

Release note (sql change): implemented COMMENT ON VIEW/SEQUENCE
@elliotcourant elliotcourant mentioned this issue Jul 18, 2020
Closed
9 tasks
elliotcourant added a commit to elliotcourant/cockroach that referenced this issue Jul 18, 2020
@elliotcourant
sql: add support for COMMENT ON VIEW, COMMENT ON SEQUENCE
8ddf737 
Added the CommentOnView and CommentOnSequence tree node and plan node.
These will each append a new type to the system.comments table for views
and sequences respectively.

This would resolve cockroachdb#44135

Release note (sql change): implemented COMMENT ON VIEW/SEQUENCE
@vy-ton
Copy link
Contributor

vy-ton commented Nov 17, 2020

Mentioned here https://cockroachdb.slack.com/archives/CP4D9LD5F/p1605627118458000

@rafiss rafiss added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label May 12, 2021
@blathers-crl blathers-crl bot added the T-sql-schema-deprecated Use T-sql-foundations instead label Nov 7, 2022
@postamar
Copy link
Contributor

postamar commented Nov 8, 2022

@chengxiong-ruan if you feel like doing this opportunistically, go ahead.

@knz
Copy link
Contributor

knz commented Dec 5, 2022

When picking up this work, be sure to acknowledge the community contributor in #51577.

@knz knz changed the title sql: add support for COMMENT ON VIEW, COMMENT ON SEQUENCE sql: add support for COMMENT ON VIEW, COMMENT ON SEQUENCE, COMMENT ON TYPE Jan 9, 2023
@knz knz changed the title sql: add support for COMMENT ON VIEW, COMMENT ON SEQUENCE, COMMENT ON TYPE sql: add support for COMMENT ON VIEW/SEQUENCE/TYPE/FUNCTION Jan 9, 2023
@rafiss rafiss mentioned this issue Jan 11, 2023
Merged
@knz knz mentioned this issue Jan 16, 2023
Closed
@jiqiang90 jiqiang90 mentioned this issue Feb 19, 2023
Merged
11 tasks
@healthy-pod healthy-pod removed the T-sql-schema-deprecated Use T-sql-foundations instead label May 17, 2023
@chengxiong-ruan chengxiong-ruan removed their assignment Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-schema-changes A-sql-pgcompat Semantic compatibility with PostgreSQL C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: add support for COMMENT ON VIEW, COMMENT ON SEQUENCE elliotcourant/cockroach
7 participants
@knz @rafiss @postamar @chengxiong-ruan @hueypark @vy-ton @healthy-pod