Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: remove auto-init for start without --join. #44116

Closed
knz opened this issue Jan 17, 2020 · 0 comments · Fixed by #51245
Closed

cli: remove auto-init for start without --join. #44116

knz opened this issue Jan 17, 2020 · 0 comments · Fixed by #51245
Assignees
@knz @irfansharif
Labels
C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.

Comments

@knz
Copy link
Contributor

knz commented Jan 17, 2020

The auto-init behavior of cockroach start without --join was marked as deprecated in 19.2. Remove it in 20.1.

Informs (and simplifies) #26722
@knz knz added the C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. label Jan 17, 2020
@knz knz self-assigned this Jan 17, 2020
@knz knz mentioned this issue Jan 17, 2020
Closed
@irfansharif irfansharif mentioned this issue Jul 9, 2020
Merged
irfansharif added a commit to irfansharif/cockroach that referenced this issue Jul 10, 2020
@irfansharif
cli: remove auto-init with cockroach start without --join
9aa5bc1 
Fixes cockroachdb#44116. Informs cockroachdb#24118.
Reviving cockroachdb#44112.

Release note (backward-incompatible change): A CockroachDB node
started with cockroach start without the --join flag no
longer automatically initializes the cluster. The cockrach init
command is now mandatory. The auto-initialization behavior had
been deprecated in version 19.2.
irfansharif added a commit to irfansharif/cockroach that referenced this issue Jul 15, 2020
@irfansharif
cli: remove auto-init with cockroach start without --join
506042b 
Fixes cockroachdb#44116. Informs cockroachdb#24118. Reviving cockroachdb#44112.

We remove the deprecated behavior of crdb where we previously
auto-initialized the cluster when `cockroach start` was invoked without
a corresponding `--join` flag. We update a few tests along the way that
made use of this behavior by changing them to either explicitly init, or
now lean on `roachprod` changes (from cockroachdb#51329) that transparently manage
initialization.

Release note (backward-incompatible change): A CockroachDB node
started with cockroach start without the --join flag no
longer automatically initializes the cluster. The `cockroach init`
command is now mandatory. The auto-initialization behavior had
been deprecated in version 19.2.

Release note (backward-incompatible change): `cockroach start` without
`--join` is no longer supported. It was deprecated in a previous
release.
craig bot pushed a commit that referenced this issue Jul 17, 2020
@irfansharif
Merge #51245
c09ed61 
51245: cli: remove auto-init with `cockroach start` without `--join` r=irfansharif a=irfansharif

Fixes #44116. Informs #24118. Reviving #44112.

Release note (backward-incompatible change): A CockroachDB node
started with cockroach start without the --join flag no
longer automatically initializes the cluster. The cockrach init
command is now mandatory. The auto-initialization behavior had
been deprecated in version 19.2.

Co-authored-by: irfan sharif <[email protected]>
@craig craig bot closed this as completed in b5e7171 Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knz knz

@irfansharif irfansharif

Labels
C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.
Projects
None yet
Milestone
No milestone
2 participants
@knz @irfansharif