Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: internal error: decoding unset EncDatum #39794

Closed
maddyblue opened this issue Aug 21, 2019 · 0 comments · Fixed by #40203
Closed

sql: internal error: decoding unset EncDatum #39794

maddyblue opened this issue Aug 21, 2019 · 0 comments · Fixed by #40203
Assignees
@jordanlewis
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. O-rsg Random Syntax Generator

Comments

@maddyblue
Copy link
Contributor 

SELECT aclexplode(ARRAY[]) 

pq: internal error: decoding unset EncDatum
DETAIL: stack trace:
github.com/cockroachdb/cockroach/pkg/sql/sqlbase/encoded_datum.go:216: EnsureDecoded()
github.com/cockroachdb/cockroach/pkg/sql/distsqlrun/expr.go:129: IndexedVarEval()
github.com/cockroachdb/cockroach/pkg/sql/sem/tree/indexed_vars.go:78: Eval()
github.com/cockroachdb/cockroach/pkg/sql/sem/tree/eval.go:3973: Eval()
github.com/cockroachdb/cockroach/pkg/sql/distsqlrun/expr.go:191: eval()
github.com/cockroachdb/cockroach/pkg/sql/distsqlrun/processors.go:366: ProcessRow()
github.com/cockroachdb/cockroach/pkg/sql/distsqlrun/processors.go:770: ProcessRowHelper()
github.com/cockroachdb/cockroach/pkg/sql/distsqlrun/project_set.go:264: Next()
github.com/cockroachdb/cockroach/pkg/sql/distsqlrun/base.go:171: Run()
github.com/cockroachdb/cockroach/pkg/sql/distsqlrun/processors.go:793: Run()
github.com/cockroachdb/cockroach/pkg/sql/distsqlrun/flow.go:584: Run()
github.com/cockroachdb/cockroach/pkg/sql/distsql_running.go:333: Run()
github.com/cockroachdb/cockroach/pkg/sql/distsql_running.go:958: PlanAndRun()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:808: execWithDistSQLEngine()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:700: dispatchToExecutionEngine()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:416: execStmtInOpenState()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:98: execStmt()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:1211: execCmd()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:1140: run()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:442: ServeConn()
github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:584: func1()
runtime/asm_amd64.s:1337: goexit()
@maddyblue maddyblue added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. O-rsg Random Syntax Generator labels Aug 21, 2019
@jordanlewis jordanlewis mentioned this issue Aug 26, 2019
Merged
@craig craig bot closed this as completed in d0f2003 Aug 26, 2019
@rytaft rytaft mentioned this issue Oct 22, 2019
Closed
@tbg tbg mentioned this issue Nov 27, 2019
Merged
tbg added a commit to tbg/cockroach that referenced this issue Nov 29, 2019
@tbg
storage: call EnsureSafeSplitKey during load-based splits
cec68d5 
We could end up splitting between column families of the same row,
which is illegal. Unfortunately the KV layer has to uphold invariants
here that it doesn't quite have introspection into, but after this
commit it hopefully stops breaking them.

See cockroachdb#16344 for some
additional history.

Possibly the solution for cockroachdb#39794.
Possibly the solution for cockroachdb#36834.
Possibly the solution for cockroachdb#36356.

(Intentionally not closing the above; leaving that to the SQL folks).

Closes cockroachdb#42056 (which is the go-to for reading up on this issue).

Release note (bug fix): prevent a number of panics from the SQL layer
caused by an invalid range split. These would usually manifest with
messages mentioning encoding errors ("found null on not null column" but
also possibly various others).
@tbg tbg mentioned this issue Nov 29, 2019
Merged
@tbg tbg mentioned this issue Nov 29, 2019
Merged
tbg added a commit to tbg/cockroach that referenced this issue Dec 2, 2019
@tbg
storage: call EnsureSafeSplitKey during load-based splits
fad2024 
We could end up splitting between column families of the same row,
which is illegal. Unfortunately the KV layer has to uphold invariants
here that it doesn't quite have introspection into, but after this
commit it hopefully stops breaking them.

See cockroachdb#16344 for some
additional history.

Possibly the solution for cockroachdb#39794.
Possibly the solution for cockroachdb#36834.
Possibly the solution for cockroachdb#36356.

(Intentionally not closing the above; leaving that to the SQL folks).

Closes cockroachdb#42056 (which is the go-to for reading up on this issue).

Release note (bug fix): prevent a number of panics from the SQL layer
caused by an invalid range split. These would usually manifest with
messages mentioning encoding errors ("found null on not null column" but
also possibly various others).
craig bot pushed a commit that referenced this issue Dec 2, 2019
@tbg
Merge #42833
45d709f 
42833: storage: call EnsureSafeSplitKey during load-based splits r=bdarnell a=tbg

We could end up splitting between column families of the same row,
which is illegal. Unfortunately the KV layer has to uphold invariants
here that it doesn't quite have introspection into, but after this
commit it hopefully stops breaking them.

See #16344 for some
additional history.

Possibly the solution for #39794.
Possibly the solution for #36834.
Possibly the solution for #36356.

(Intentionally not closing the above; leaving that to the SQL folks).

Closes #42056 (which is the go-to for reading up on this issue).

Release note (bug fix): prevent a number of panics from the SQL layer
caused by an invalid range split. These would usually manifest with
messages mentioning encoding errors ("found null on not null column" but
also possibly various others).

Co-authored-by: Tobias Schottdorf <[email protected]>
tbg added a commit to tbg/cockroach that referenced this issue Dec 3, 2019
@tbg
storage: call EnsureSafeSplitKey during load-based splits
df8f61f 
We could end up splitting between column families of the same row,
which is illegal. Unfortunately the KV layer has to uphold invariants
here that it doesn't quite have introspection into, but after this
commit it hopefully stops breaking them.

See cockroachdb#16344 for some
additional history.

Possibly the solution for cockroachdb#39794.
Possibly the solution for cockroachdb#36834.
Possibly the solution for cockroachdb#36356.

(Intentionally not closing the above; leaving that to the SQL folks).

Closes cockroachdb#42056 (which is the go-to for reading up on this issue).

Release note (bug fix): prevent a number of panics from the SQL layer
caused by an invalid range split. These would usually manifest with
messages mentioning encoding errors ("found null on not null column" but
also possibly various others).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jordanlewis jordanlewis

Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. O-rsg Random Syntax Generator
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

builtins: fix bug in aclexplode; add tests jordanlewis/cockroach
2 participants
@maddyblue @jordanlewis