-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not able to modify the zone configuration for the system.jobs table directly #39605
Comments
Indeed: cockroach/pkg/config/system.go Lines 259 to 263 in d05f199
The simple fix is to change |
Note that this applies to both manual zone config changes like the one described here and the default zone config that sets the GC for this table (since version 2.0). So the jobs table has in practice been getting the default 24h gc instead of the intended 10m. |
Before this PR we would allow setting zone configurations on system tables but they would not propagate because the GetZoneConfig function would return the zone config for the entire system database. This leaves us in a still weird situation where some system tables will ignore their zone configs but not others. Fixes cockroachdb#39605. Release note (bug fix): Propagate zone configuration to non-gossiped system tables.
39638: config: propagate zone config info for non-gossiped system tables r=nvanbenschoten a=ajwerner Before this PR we would allow setting zone configurations on system tables but they would not propagate because the GetZoneConfig function would return the zone config for the entire system database. This leaves us in a still weird situation where some system tables will ignore their zone configs but not others. Fixes #39605. Release note (bug fix): Propagate zone configuration to non-gossiped system tables. Co-authored-by: Andrew Werner <[email protected]>
Before this PR we would allow setting zone configurations on system tables but they would not propagate because the GetZoneConfig function would return the zone config for the entire system database. This leaves us in a still weird situation where some system tables will ignore their zone configs but not others. Fixes cockroachdb#39605. Release note (bug fix): Propagate zone configuration to non-gossiped system tables.
Describe the problem
Please describe the issue you observed, and any steps we can take to reproduce it:
When I go running the following command
I would expect that when I go to the range report for the ranges making up the jobs table that they would state 128 MiB for
Max Range Size Before Split
. However, after the alter table command above it still shows 64 MiB. It is only when I do the following that I see the value for this range change:Environment:
The text was updated successfully, but these errors were encountered: