Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: expand cockroach demo to allow setting of locality #39450

Closed
awoods187 opened this issue Aug 8, 2019 · 0 comments · Fixed by #39454
Closed

sql: expand cockroach demo to allow setting of locality #39450

awoods187 opened this issue Aug 8, 2019 · 0 comments · Fixed by #39454
Assignees
@rohany
Labels
A-demo A-partitioning A-sql-execution Relating to SQL execution. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@awoods187
Copy link
Contributor

Recently, we expanded Cockroach Demo to include movr by default as well as allow for creating nodes. We should further expand upon this work to allow for setting of locality via Cockroach Demo.

I'm imagining something like:

./cockroach demo movr --nodes 3 --locality=us-east1-b,us-central1-a, us-west1-a

Where each comma separates a locality.

This will make it easier to simulate and test partitioning and other features.
@awoods187 awoods187 added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Aug 8, 2019
@awoods187 awoods187 added A-partitioning A-sql-execution Relating to SQL execution. labels Aug 8, 2019
@rohany rohany mentioned this issue Aug 8, 2019
Merged
@awoods187 awoods187 mentioned this issue Aug 9, 2019
Closed
16 tasks
craig bot pushed a commit that referenced this issue Aug 12, 2019
@rohany
Merge #39454
1e62ef1 
39454: cli: add an option to set node localities in cockroach demo r=rohany a=rohany

The demo command now accepts a --demo-locality= flag,
which sets the locality of the i'th node in the demo to the
i'th locality setting input by the user.

Fixes #39450.

Release note (cli change): Add an option to set node
localities in cockroach demo.

Co-authored-by: Rohan Yadav <[email protected]>
@craig craig bot closed this as completed in #39454 Aug 12, 2019
@ericharmeling ericharmeling mentioned this issue Aug 13, 2019
Closed
3 tasks
@awoods187 awoods187 mentioned this issue Aug 23, 2019
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohany rohany

Labels
A-demo A-partitioning A-sql-execution Relating to SQL execution. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cli: add an option to set node localities in cockroach demo rohany/cockroach
2 participants
@rohany @awoods187