Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: kv/contention/nodes=4 failed #39116

Closed
cockroach-teamcity opened this issue Jul 26, 2019 · 1 comment · Fixed by #39149
Closed

roachtest: kv/contention/nodes=4 failed #39116

cockroach-teamcity opened this issue Jul 26, 2019 · 1 comment · Fixed by #39149
Assignees
@nvanbenschoten
Labels
C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot.
Milestone
19.2

Comments

@cockroach-teamcity
Copy link
Member

SHA: https://github.com/cockroachdb/cockroach/commits/b8554ec29fd1620c0e6af9544d678db57d251f4c

Parameters:

To repro, try:

# Don't forget to check out a clean suitable branch and experiment with the
# stress invocation until the desired results present themselves. For example,
# using stress instead of stressrace and passing the '-p' stressflag which
# controls concurrency.
./scripts/gceworker.sh start && ./scripts/gceworker.sh mosh
cd ~/go/src/github.com/cockroachdb/cockroach && \
stdbuf -oL -eL \
make stressrace TESTS=kv/contention/nodes=4 PKG=roachtest TESTTIMEOUT=5m STRESSFLAGS='-maxtime 20m -timeout 10m' 2>&1 | tee /tmp/stress.log

Failed test: https://teamcity.cockroachdb.com/viewLog.html?buildId=1406588&tab=buildLog

The test failed on branch=release-19.1, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/20190726-1406588/kv/contention/nodes=4/run_1
	ts_util.go:107,kv.go:203,cluster.go:2069,errgroup.go:57: average txns per second 35.915510 was under target 100.000000
	cluster.go:2090,kv.go:206,test_runner.go:691: Goexit() was called
@cockroach-teamcity cockroach-teamcity added this to the 19.2 milestone Jul 26, 2019
@cockroach-teamcity cockroach-teamcity added C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. labels Jul 26, 2019
@nvanbenschoten
Copy link
Member

release-19.1, which has some of the issues described in #36089. I'm going to skip this test for that release, as it isn't expected to reliably pass.

@nvanbenschoten nvanbenschoten mentioned this issue Jul 29, 2019
Merged
@nvanbenschoten nvanbenschoten self-assigned this Jul 29, 2019
craig bot pushed a commit that referenced this issue Jul 30, 2019
@nvanbenschoten
Merge #39149 #39160 #39161
634dc24 
39149: roachtest: skip kv/contention/nodes=4 for release-19.1 r=tbg a=nvanbenschoten

Fixes #39116.

release-19.1 is susceptible to the issues described in #36089, so it won't reliably pass this test.

39160: storage: add DisableRaftLogQueue to StoreTestingKnobs r=tbg a=nvanbenschoten

Pulled from #38954, which I want to keep focused, especially with the PR's new secondary focus on refactoring entry application to be easier to mock and test.

Release note: None

39161: storage: address TODO in TestPushTxnHeartbeatTimeout r=tbg a=nvanbenschoten

Pulled from #38954, which I want to keep focused, especially with the PR's new secondary focus on refactoring entry application to be easier to mock and test.

Release note: None

Co-authored-by: Nathan VanBenschoten <[email protected]>
@craig craig bot closed this as completed in #39149 Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nvanbenschoten nvanbenschoten

Labels
C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot.
Projects
None yet
Milestone
19.2
Development

Successfully merging a pull request may close this issue.

roachtest: skip kv/contention/nodes=4 for release-19.1 nvanbenschoten/cockroach
2 participants
@nvanbenschoten @cockroach-teamcity