Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: learners defaulted on #38902

Closed
11 of 13 tasks
danhhz opened this issue Jul 16, 2019 · 0 comments · Fixed by #39034
Closed
11 of 13 tasks

storage: learners defaulted on #38902

danhhz opened this issue Jul 16, 2019 · 0 comments · Fixed by #39034
Assignees
@danhhz
Labels
A-kv-distribution Relating to rebalancing and leasing. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@danhhz
Copy link
Contributor

danhhz commented Jul 16, 2019 •
edited
Loading

#38149 will merge learners, defaulted off. Afterward, there will be some followups before turning it on, including more production testing and updating some unit tests.
@danhhz danhhz added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-kv-distribution Relating to rebalancing and leasing. labels Jul 16, 2019
@danhhz danhhz self-assigned this Jul 16, 2019
@danhhz danhhz mentioned this issue Jul 22, 2019
Merged
danhhz added a commit to danhhz/cockroach that referenced this issue Jul 23, 2019
@danhhz
storage: default learners to on
d1aca3e 
Closes cockroachdb#37916
Closes cockroachdb#38902

Release note: None
danhhz added a commit to danhhz/cockroach that referenced this issue Jul 29, 2019
@danhhz
storage: handle learner replicas in merge code
5bda9fb 
For simplicity of implementation and concept, learners are disallowed by
AdminMerge. The merge queue now removes them before calling it.

AdminRelocateRange similarly removes them before doing its work (even if
the learner is one of the supplied targets). This is not strictly
necessary for its use in the merge queue, since the merge queue does its
own removal, but decoupling this is appealing. Additionally,
AdminRelocateRange has other callers than the merge queue.

Touches cockroachdb#38902

Release note: None
This was referenced Jul 29, 2019
Merged
Closed
craig bot pushed a commit that referenced this issue Jul 30, 2019
@danhhz
Merge #39151 #39170
8a08c17 
39151: storage: handle learner replicas in merge code r=tbg a=danhhz

For simplicity of implementation and concept, learners are disallowed by
AdminMerge. The merge queue now removes them before calling it.

AdminRelocateRange similarly removes them before doing its work (even if
the learner is one of the supplied targets). This is not strictly
necessary for its use in the merge queue, since the merge queue does its
own removal, but decoupling this is appealing. Additionally,
AdminRelocateRange has other callers than the merge queue.

Touches #38902

Release note: None

39170: opt: stop storing references to WITH expressions r=justinj a=justinj

It's sketchy to include references to RelExprs that are "outside the
system," and we only needed them any more to compute stats, so we'll
just call them unknown for the time being.

Release note: None

Co-authored-by: Daniel Harrison <[email protected]>
Co-authored-by: Justin Jaffray <[email protected]>
danhhz added a commit to danhhz/cockroach that referenced this issue Aug 2, 2019
@danhhz
storage: default learners to on
32274f1 
Closes cockroachdb#38902

Release note: None
danhhz added a commit to danhhz/cockroach that referenced this issue Aug 7, 2019
@danhhz
storage: default learners to on
c4dcc42 
Closes cockroachdb#38902

Release note: None
danhhz added a commit to danhhz/cockroach that referenced this issue Aug 8, 2019
@danhhz
storage: default learners to on
8409a7f 
Closes cockroachdb#38902

Release note: None
danhhz added a commit to danhhz/cockroach that referenced this issue Aug 8, 2019
@danhhz
storage: use learner replicas for replica addition by default
00cb1f7 
This was previously available by flipping a cluster setting that
defaulted to off, this defaults it to on. With any luck, we'll be
confident enough in this to remove the cluster setting in 19.2, which
will allow us to rip out a bunch of code at the beginning of the 20.1
cycle.

Closes cockroachdb#38902

Release note (general change): Replicas are now added using a raft
learner and going through the normal raft snapshot process to catch them
up, eliminating technical debt. No user facing changes are expected.
danhhz added a commit to danhhz/cockroach that referenced this issue Aug 9, 2019
@danhhz
storage: use learner replicas for replica addition by default
cd173ff 
This was previously available by flipping a cluster setting that
defaulted to off, this defaults it to on. With any luck, we'll be
confident enough in this to remove the cluster setting in 19.2, which
will allow us to rip out a bunch of code at the beginning of the 20.1
cycle.

Closes cockroachdb#38902

Release note (general change): Replicas are now added using a raft
learner and going through the normal raft snapshot process to catch them
up, eliminating technical debt. No user facing changes are expected.
craig bot pushed a commit that referenced this issue Aug 13, 2019
@danhhz @rytaft
Merge #39034 #39469
f11604f 
39034: storage: use learner replicas for replica addition by default r=tbg a=danhhz

This was previously available by flipping a cluster setting that
defaulted to off, this defaults it to on. With any luck, we'll be
confident enough in this to remove the cluster setting in 19.2, which
will allow us to rip out a bunch of code at the beginning of the 20.1
cycle.

Closes #38902

Release note (general change): Replicas are now added using a raft
learner and going through the normal raft snapshot process to catch them
up, eliminating technical debt. No user facing changes are expected.

39469: opt: fix panic due to incorrect type of ArrayFlatten r=rytaft a=rytaft

This commit fixes a panic caused by incorrect typing of an `ArrayFlatten`
expression. If the input to an `ArrayFlatten` expression is sorted, there
may be more than one output column (although the columns used for sorting
are hidden). If one of these hidden columns is chosen to infer the type
of the expression, the type could be incorrect. This commit fixes the
problem so that only the requested column is chosen for type inference.

Fixes #38867

Release note (bug fix): Fixed a panic due to incorrect type inference
of some ARRAY(...) expressions.

Co-authored-by: Daniel Harrison <[email protected]>
Co-authored-by: Rebecca Taft <[email protected]>
@craig craig bot closed this as completed in #39034 Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danhhz danhhz

Labels
A-kv-distribution Relating to rebalancing and leasing. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

storage: use learner replicas for replica addition by default danhhz/cockroach
1 participant
@danhhz