storage: TestReplicateQueueRebalance failed under stress #38156
Assignees
Labels
branch-master
Failures and bugs on the master branch.
C-test-failure
Broken test (automatically or manually discovered).
O-robot
Originated from a bot.
Comments
cockroach-teamcity
added
C-test-failure
|
This test is also routinely extremely slow: #38550 |
|
(storage).TestReplicateQueueRebalance failed on master@dba32b33f6eda3af1eef4f8636fb0de592f4cd86: Fatal error: Stack: Log preceding fatal error
ReproParameters:
powered by pkg/cmd/internal/issues |
|
(storage).TestReplicateQueueRebalance failed on master@1a6c7b9c97a121c2a35c45e8b008dff7262614e7: Fatal error: Stack: Log preceding fatal error
ReproParameters:
powered by pkg/cmd/internal/issues |
andreimatei
added a commit
to andreimatei/cockroach
that referenced
this issue
Jan 27, 2020
Before this patch, the refresher interceptor was erroneously asserting its tracking of the refreshed timestamp is in sync with the TxnCoordSender. It may, in fact, not be in sync in edge cases where a refresh succeeded but the TxnCoordSender doesn't hear about that success. Touches cockroachdb#38156 Touches cockroachdb#41941 Touches cockroachdb#43707 Release note: None
andreimatei
added a commit
to andreimatei/cockroach
that referenced
this issue
Jan 29, 2020
Before this patch, the refresher interceptor was erroneously asserting its tracking of the refreshed timestamp is in sync with the TxnCoordSender. It may, in fact, not be in sync in edge cases where a refresh succeeded but the TxnCoordSender doesn't hear about that success. Touches cockroachdb#38156 Touches cockroachdb#41941 Touches cockroachdb#43707 Release note: None
craig bot
pushed a commit
that referenced
this issue
Jan 30, 2020
44407: storage: improve the migration away from txn.DeprecatedOrigTimestamp r=andreimatei a=andreimatei 19.2 doesn't generally set txn.ReadTimestamp. Instead, it sets txn.DeprecatedOrigTimestamp. Before this patch, all code dealing with txn.ReadTimestamp had to deal with the possibility of it not being set. This is fragile; I recently forgot to deal with it in a patch. This patch sets txn.ReadTimestamp to txn.DeprecatedOrigTimestamp when it wasn't set, thereby releaving most other code of they worry. This comes at the cost of an extra txn clone for requests coming from 19.2 nodes. Release note: None 44428: storage: fix handling of refreshed timestamp r=andreimatei a=andreimatei Before this patch, the refresher interceptor was erroneously asserting its tracking of the refreshed timestamp is in sync with the TxnCoordSender. It may, in fact, not be in sync in edge cases where a refresh succeeded but the TxnCoordSender doesn't hear about that success. Touches #38156 Touches #41941 Touches #43707 Release note: None 44503: roachpb: fix txn.Update() commutativity r=andreimatei a=andreimatei Updates to the WriteTooOld field were not commutative. This patch fixes that, by clarifying that the transaction with the higher ReadTimestamp gets to dictate the WriteTooOld value. I'm not sure what consequences this used to have, besides allowing for the confusing case where the server would receive a request with the WriteTooOld flag set, but with the ReadTimestamp==WriteTimestamp. A future commit introduces a sanity assertion that all the requests with the WTO flag have a bumped WriteTimestamp. Release note: None Co-authored-by: Andrei Matei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
SHA: https://github.com/cockroachdb/cockroach/commits/91f2f85c13d1465875326cc1c0ecacdf1874a291
Parameters:
To repro, try:
Failed test: https://teamcity.cockroachdb.com/viewLog.html?buildId=1337745&tab=buildLog
The text was updated successfully, but these errors were encountered: